Closed Bug 38875 Opened 26 years ago Closed 26 years ago

Disable toolbar and menu items while in HTML Source edit mode

Categories

(Core :: DOM: Editor, defect, P1)

PowerPC
Mac System 8.5
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: sfraser_bugs, Assigned: cmanske)

References

Details

(Whiteboard: [nsbeta2+][8/2])

Attachments

(1 file)

Switching to 'HTML source' mode in editor hides all the toolbars, and changes the window to look pretty much blank, with an ugly white border. Clicking between the border and the content causes focus changes that change the content size, causing a nasty shrink/grow effect. I think it would be better to keep the toolbars, and just disable most things when in HTML source mode.
This bug is related to #38877. This bug should be for the focus change issues (if that's ok with everyone).
also when you switch back to Normal mode the screen is dirty with characters....need to clean thisup....seems like we need a refresh here...
We definitely have repaint problems that are not the editor's fault. As far as the toolbars go, I think it would look silly to gray out everything and keep them open, especiall the "Format" (2nd) toolbar. I can see keeping the main toolbar and graying out everything but Open, New, Preview, and Save buttons What's so "nasty" about the change in window size? You are radically changing content and even if window didn't change size, the difference between the 2 modes causes complete redisplay. There is a bad effect in that we loose the scrolled position of the document -- I wish we could fix that. The border styles while in HTML Mode will get fixed when XPFE supplies (or I do after 5/16) a new "plain" version of textfield (Ben promised this). There's also the problem that I can't set initial focus inside the textfield when switching to it. Marking M16 -- hope to address as many of these problems as allowed in post 5/16, pre beta2 period.
Status: NEW → ASSIGNED
Target Milestone: --- → M16
Bijal suggested: Here are two additional options: 1) Simply disable buttons that do not apply 2) Hide buttons that do not apply (we do this in Seamonkey IM when the end user is in the Online tab versus the List Setup tab). I would prefer option 2 since the current UI colors/scheme make it difficult to tell whether something is disabled.
I agree with Bijal. It's easy to hide the buttons on the main toolbar, and completely hide the Format toolbar. That will reduce the window size change that Simon noted.
Question: Should we allow these operations in HTML Source mode: Save, SaveAs, Close, Print, and Preview? If yes, we would have to automatically switch back to normal mode to get the source changes, then contiued with the requested action.
Kathy has correctly pointed out that we should keep enable/disable issues about the HTML Edit mode separate from the paint/border/display issues. Changing Summary to use this for the former problems. Will open a new bug for the latter.
Summary: Composer's HTML source view is ugly, switching is painful → Disable toolbar and menu items while in HTML Source edit mode
What functionality should be present in this tab is a different issue from the refresh problems. Please don't evolve this bug into something else. I don't want to lose the issue of the update ugliness Sujay and Simon wrote about. I will start a discussion in the editor newsgroup for the issue of functionality available in this mode.
*** Bug 38877 has been marked as a duplicate of this bug. ***
Blocks: 14526
Keywords: nsbeta2
Whiteboard: [nsbeta2+] Composer feature work
With latest checkin, the toolbars are no longer hidden, but nothing is disabled. Won't do that until we explore trying to use full Plain Text editor instead, since if we do that we will reevaluate which commands need to be disabled. This UI disabling work was already discussed and approved as [nsbeta2+] in bug 14526, so I'm adding the same status and keywords that 14526 had to this bug.
This is very straightforward UI work and is not "a feature". Requesting more time to complete or designate as 'bug' or M17/Beta3.
Whiteboard: [nsbeta2+] Composer feature work → [nsbeta2+]
*** Bug 41308 has been marked as a duplicate of this bug. ***
Blocks: 41810
M16 has been out for a while now, these bugs target milestones need to be updated.
moving over to m17, adjusted priority and severity
Severity: normal → critical
Priority: P3 → P1
Target Milestone: M16 → M17
Depends on: 34414
Why would we hold beta2 for this? Removing nsbeta2+ for reconsideration. (Plus I went in to check it out, and things looked good to me using 7/6 build)
Whiteboard: [nsbeta2+]
BULLSHIT This was approved. Work is essentially done. Read the entire bug history. This has to be done before beta2.
Whiteboard: [nsbeta2+]
added fix by date in status
Whiteboard: [nsbeta2+] → [nsbeta2+][8/2]
The proper disabling code is checked in, but there are still related problems, which I'll file as separate bugs.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
verified in 7/12 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: