Closed Bug 14526 Opened 25 years ago Closed 24 years ago

Implement HTML Source edit mode

Categories

(Core :: DOM: Editor, enhancement, P5)

enhancement

Tracking

()

VERIFIED FIXED

People

(Reporter: CodeMachine, Assigned: cmanske)

References

Details

(Whiteboard: [nsbeta2+] Composer feature work)

This is a request to add a page source editor to the editing modes of the
editor.  The UI of changing between modes was discussed in bug #11140.

I won't go into all the features that page source editors can have, I'm sure
others know more than me.  The important thing however is that you can edit in
one mode and then change over to the other.  This is obviously non-trivial in
that you need to avoid the graphical editing losing comments and stuff entered
in page source editor mode.
Ideally this editor could be initially designed at least to work with any XML in
preparation to having an arbitrary XML editor in Mozilla.
Assignee: buster → nobody
Priority: P3 → P5
Target Milestone: M20
Summary: Page source editor → [HELP WANTED]Page source editor
*** Bug 16400 has been marked as a duplicate of this bug. ***
The current standard for dual-mode editors has been set by Dreamweaver
<URL:http://www.macromedia.com/software/dreamweaver/>. Macromedia guarantees
that after editing in graphical mode, *no changes whatsoever* will happen to
any line of the file upon saving that were not a direct result of the
graphical editing (Promoting the feature here, not the company).

Now that the bar has been raised to that level I am not sure that it is
worth trying to create a dual-mode editor without meeting that strict
standard of noninterference with hand-coding in source files.

Having said that, it would be absolutely excellent to have such an editor
available in Mozilla, so long as the non-graphical mode also allowed
regex search and replace.
I would imagine regexp would be a feature that would be implemented by the
underlying plaintext editor.
Keywords: helpwanted
Assigning all open "nobody@mozilla.org" bugs to "leger@netscape.com" to weed 
thru.
Assignee: nobody → leger
Summary: [HELP WANTED]Page source editor → Page source editor
Updating assignee for this component.
Assignee: leger → brade
Some tips from akkana on n.p.m.editor for whoever wants to help out with this 
bug

It's not hard to do this (basically, save on focus out, and check
last-mod date on focus in, and voila, you can work with an external
source editor), and would certainly be useful to a lot of people, but we
inside netscape may not have time for it in the first release unless
someone else helps out, which is why the bug is marked helpwanted.

Status: NEW → ASSIGNED
*** Bug 31583 has been marked as a duplicate of this bug. ***
Reassign to cmanske
Assignee: brade → cmanske
Status: ASSIGNED → NEW
Help would be nice, but we are planning to support this feature.
Status: NEW → ASSIGNED
Target Milestone: M20 → M16
*** Bug 33594 has been marked as a duplicate of this bug. ***
*** Bug 36774 has been marked as a duplicate of this bug. ***
Copying over some comments I made in bug 36774, though if we use a tabbed view
(which would be great!), these aren't all relevant:

Our current Insert HTML Source dialog (in the insert menu) is cool in that if
something is selected, the source of that part of the dialog will be loaded into
the dialog when it's brought up.

Several of us agreed at the last editor team meeting that this wasn't very
discoverable, and in any case it's ugly (it's fine as a little dialog, but lousy
for editing entire documents).

We need several changes to give us usable source editing:

1. Make it look more like an editor window.  Ideally, it should look a lot like
the plaintext editor (TextEditorAppShell.xul) -- maybe even use that same xul
file, if possible -- including using normal-size CSS fonts, not the microscopic
fonts that UE insists on using for dialogs.

2. It should probably be somewhere else, like under the Edit menu -- probably
leave the existing little InsertSource dialog where it is, and then let the
marketing/UE people fight about where each one should go.

3. If the selection is collapsed when the dialog is brought up, then instead of
coming up blank (like the insert source dialog), it should get the contents of
the whole document (i.e. it shouldn't include the "selection only" flag when
calling the output routines).
The basic feature is finished. But I have to disable UI that is inappropriate
to HTML editing. That has to be done before beta2, I think, else you could get
into real trouble. I wish we could do that during the beta2 bug fixing phase
(that's not M17, right?) instead of before May 16th. That task is related to
other menu/command enabling/disabling work that needs to be done. I'm not sure
how critical all of that is. Simon?
Keywords: helpwanted
Why wasnt' this marked as nsbeta2 before? Doing so now.
HTML Source editing is done except for disabling UI, so changing summary to
reflect that task.
Part of this is to collapse the toolbars, which currently doesn't work because
of bug 36628
Depends on: 36628
Keywords: nsbeta2
Summary: Page source editor → Disable inappropriate UI for HTML Source editor
Whiteboard: Composer feature work
Putting on [nsbeta2+] radar.
Whiteboard: Composer feature work → [nsbeta2+] Composer feature work
Collapse now works to hide the toolbars. Still need to modify the menu to
allow only limited commands while editing source.
Changin summary back to the general implementation item
Problems with this feature are covered by bugs 38875 and 38972
Depends on: 38875, 38972
Summary: Disable inappropriate UI for HTML Source editor → Implement HTML Source edit mode
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
This feature is finished. Other bugs cover problems.
Note that the HTML Source item is in both the 
Edit and View menus and will do exactly the same: Go to editor's HTML Source
window. We may decide to remove it from one menu or the other later.
verified in 5/19 build.
Status: RESOLVED → VERIFIED
No longer depends on: 38972
You need to log in before you can comment on or make changes to this bug.