389614 - Feature (with patch): Dock Menu to feature New Browser Window, Open Mail Window.

Status: NEW

(SeaMonkey :: UI Design, enhancement)

Description

[Jorgen Lundman]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-GB; rv:1.8.1.5) Gecko/20070724 SeaMonkey/1.1.3
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-GB; rv:1.8.1.5) Gecko/20070724 SeaMonkey/1.1.3

Windows if you click the Iconbar icon it will open a new clean browser Window. In OsX, it will bring any Window to front, even minimzed, or indeed, the Download Manager if that is the last Window.

I have done an initial patch, that adds:

* Click Dock Icon will open a new browser window
* Dock Icon Menu has "New Browser Window"
* Dock Icon Menu has "New Mail Window"

What is missing is:

* Coding standards probably not adhered to(?)
* These options should be customisable with about:config
* If you click Dock Icon, the newly created navigator window does not get the Input Focus (so that you can start typing a URL, like Cmd-N does).
* New Mail Window should really Open the existing Mail window if there is one, just like Cmd-2 does. (I can not find this code to steal it!)



Reproducible: Always

Steps to Reproduce:
1.
2.
3.



Please find external patch here:

http://netbsd.interq.or.jp/~lundman/osx_dock_menu.diff

Since this page don't seem to let me attach files.

If you need things converted to different format, let me know.

Comment 1

[zug_treno]

(In reply to comment #0)
> * Dock Icon Menu has "New Browser Window"
> * Dock Icon Menu has "New Mail Window"

Related to Firefox bug 287954 and Camino bug 191907?

> Since this page don't seem to let me attach files.

You can use the 'Add an attachment' link to attach the patch. See also http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree .

Comment 2

[Philip Chee]

CC various seamonkey developers.

Comment 3

[Philip Chee]

This patch appears to be against branch. For trunk could you have a look at:
<http://lxr.mozilla.org/seamonkey/source/toolkit/xre/nsNativeAppSupportMac.cpp>

Comment 4

[[e-mail]]

Since the native app support is invoked very early on in the startup process I don't think we have access to XPCOM components necessary for generic actions. Perhaps this code can be turned into an XPCOM service that loads at startup.

As for customising the menu, I think the way to go here is to define a second application-specific service which can be easily written in JavaScript. This service would provide a list of dock menuitems and perform the invoked actions.

Comment 5

[Serge Gautherie (:sgautherie)]

Filter "spam" on "guifeatures-nobody-20080610".

Comment 6

[Jorgen Lundman]

I've been copying my nsNativeAppSupportMac.cpp along with all new versions of Seamonkey-1 (since there have been no other changes in this file). But I am trying Seamonkey-2b2 now, and it no longer has this file, and would most likely need to be re-done entirely.

Comment 7

[Tom Dyas]

See bug 415463 for XUL-based Mac OS X dock menu support. (Firefox on trunk now has a "New Window" dock menu item.)

Comment 8

[Philip Chee]

All the backend work was done in 415463. Porting the front end looks trivially possible: http://hg.mozilla.org/mozilla-central/rev/4aec85d30806.

I'd do it but I don't have a Mac.

Stefanh?

Comment 9

[Stefan [:stefanh]]

Yeah, I looked at this for over a year ago, I think I still have the patch somewhere. We need to decide what we want in the menu, though. For example, should we have a mailNews window or just a msgcompose window?

Comment 10

[Rich Gray (:rbgray)]

I've always thought it would be great if it would produce a menu like the menu bar Windows menu, with a choice of what function of SM to go to: browser, mail, irc, composer.  For extra points, add the ability to go directly to the inbox of any e-mail account with new mail.

Comment 11

[Stefan [:stefanh]]

(In reply to comment #10)
> I've always thought it would be great if it would produce a menu like the menu
> bar Windows menu, with a choice of what function of SM to go to: browser, mail,
> irc, composer.

That should be doable. You mean something like this:
----------------------------
New
  Browser window
  Mail & Newsgroups window
  Addressbook window
  Composer window
----------------------------

> For extra points, add the ability to go directly to the inbox
> of any e-mail account with new mail.

That's harder, because the menu is only built upon launch and stays the same until you quit - iirc it's static in the sense that it's not possible to update it.

Comment 12

[Rich Gray (:rbgray)]

Attachment: Dock Options via right click on SM icon

Note that this shows open windows, just like the menu bar Windows option.

Comment 13

[Philip Chee]

Hi Stefan. I think you should get a basic menu up and running. We can then add additional items in followup bugs. Otherwise we'll still be bikeshedding this with the second coming of St Steve.

Comment 14

[Philip Chee]

To summarize what is needed is to port from Firefox:
  Bug 415463 - Dock menu support for Mac OS X (add "New Window" menu item).
And the follow up patches in:
  Bug 548500 - [Mac] Activate application when user selects dock menu item.
  Bug 574229 - [Mac] Choosing "New Window" from Firefox's dock menu does not open the new window in the active Space.

Comment 15

[[e-mail]]

(In reply to Philip Chee from comment #13)
> Hi Stefan. I think you should get a basic menu up and running. We can then
> add additional items in followup bugs. Otherwise we'll still be bikeshedding
> this with the second coming of St Steve.

Or we could provide the same options as the Windows jump list, and then try to keep them in sync.

(FYI the options on the Windows jump list are new tab, new window, new private window, mail & news, new message, address book, new composer page).

Comment 16

[Shubham Jindal [:shubham]]

I am unable to find the suitable files to edit for this. I have looked up the patches for dock menu in Firefox but I am not able to find the files which needs editing in SM.

Comment 17

[Stefan [:stefanh]]

SeaMonkey doesn't have any macBrowserOverlay.xul file, but you could use hiddenWindow.xul instead. In order to set up the Dock menu upon launch, I think the hiddenWindowStartup() function in navigator.js can be used.

Comment 18

[Philip Chee]

Also see the Thunderbird implementation:
Bug 601263 - Add options for Thunderbird Mac dock icon.
http://hg.mozilla.org/comm-central/rev/f90cbb166eb6

Comment 19

[Stefan [:stefanh]]

(In reply to Philip Chee from comment #18)
> Also see the Thunderbird implementation:
> Bug 601263 - Add options for Thunderbird Mac dock icon.
> http://hg.mozilla.org/comm-central/rev/f90cbb166eb6

That includes more than the scope of this bug I think.