548500 - [Mac] Activate application when user selects dock menu item

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Tom Dyas]

I was testing the "New Window" item added by bug 415463 and noticed that Firefox did not come to the foreground when the menu item was selected while Firefox was not the active application.  The attached patches fix this behavior.

The application delegate in toolkit/xre/MacApplicationDelegate.mm already activates the application when the user was selected the dock menu item for a window.  For custom items, however, we should allow the application to choose whether it should be activated.  (For example, you can choose "Get New Mail" from the Mail.app dock menu without activating Mail.app.)

I considered adding support to XUL for a custom attribute specifying whether to activate or not because rejected this idea as I'd rather not modify XUL for a Mac-only feature.  The best place seems to be nsIMacDockSupport as this feature is in support of dock menu commands.

Comment 1

[Tom Dyas]

Attachment: widget v1

Comment 2

[Tom Dyas]

Attachment: firefox v1

Comment 3

[Tom Dyas]

Attachment: widget v2

Forgot to bump the IID on nsIMacDockSupport.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 428876 [details] [diff] [review]
firefox v1

r=mano

Comment 5

[Josh Aas]

Comment on attachment 428879 [details] [diff] [review]
widget v2

This needs obj-c exception guards, you can fix that on checkin.

NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT
NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT

Comment 6

[Tom Dyas]

Attachment: widget v3

Add Obj-C exception guards.

Does the interface change needs superreview?

Josh: I don't have committer access so I'll just flag it for check-in unless you can get to it (assuming it doesn't need superreview).

Comment 7

[Tom Dyas]

Attachment: widget v3.1

#include file was in second patch not first ... fixed now

Comment 8

[Josh Aas]

Comment on attachment 429537 [details] [diff] [review]
widget v3.1

Technically this does need sr.

Comment 10

[Tom Dyas]

Saw that roc landed both patches on trunk:

http://hg.mozilla.org/mozilla-central/rev/290ebc6801ad
http://hg.mozilla.org/mozilla-central/rev/f07ed8839916

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Thanks!