389661 - Can't drag and drop bookmark to toolbar chevron popup (does not open on dragover)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Hideo Oshima]

You can't drag and drop bookmark to overflowed folder
on the bookmark toolbar because << button is not expanded
automatically.

Steps to reproduce:
1. Create bookmark folders on the bookmarks toolbar.
2. Make narrower the width of the browser until << button
  appears on the bookmarks toolbar.
3. Drag a favicon of the location toolbar and move mouse pointer
  to << button.

Actual result:
Nothing happened.

Expected result:
Overflowed folders appear and can drag a bookmark and drop
to the folder.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a7pre) Gecko/2007072621 Minefield/3.0a7pre

Original Japanese report in Bugzilla-jp is
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=5141 .

Comment 1

[Ria Klaassen (not reading all bugmail)]

This is a dupe of bug 383067 I guess.

Comment 2

[Thomas Rutter]

Bug 383067 is separate in that it is concerned with opening the overflow menu and dragging a folder from that menu to somewhere else.  This bug is concerned with dragging a bookmark from somewhere else into the overflow menu.

Confirming on windows, 2008030305 nightly

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch

this uses the overflow timer to open the chevron popup, low impact patch

Comment 4

[Marco Bonardo [:mak]]

s/overflow/overfolder/

Comment 5

[Hideo Oshima]

(In reply to comment #3)
> Created an attachment (id=307933) [details]
> patch
> 
> this uses the overflow timer to open the chevron popup, low impact patch
 
I tried the patch for trunk/Linux.
It looks good.
Thanks for your work.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 307933 [details] [diff] [review]
patch

r=mano

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 307933 [details] [diff] [review]
patch

drivers: this is needed to allow dropping elements into the toolbar chevron.

Comment 8

[Damon Sicore (:damons)]

Comment on attachment 307933 [details] [diff] [review]
patch

a1.9+=damons

Also, thanks for commenting on risk and complexity of the patch.  It really helps!

Comment 9

[Dietrich Ayala (:dietrich)]

Checking in browser/components/places/content/toolbar.xml;
/cvsroot/mozilla/browser/components/places/content/toolbar.xml,v  <--  toolbar.xml
new revision: 1.137; previous revision: 1.136
done

Comment 12

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090128 Shiretoko/3.1b3pre

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv