389732 - GetHandlerAppFromPrefs still partially used in unix helper app service

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P4)

Description

[Dan Mosedale (:dmosedale, :dmose)]

When the protocol handling dialog landed, we got rid of the code that allows a protocol handler to be invoked entirely from information contained in preferences on Unix systems in order to simplify the code (more discussion about that decision will ensue in the newsgroups shortly).  However, the helper app service still looks at that information in OSProtocolHandlerExists and GetApplicationDescription, which could leave it in a confused state for those users who have tweaked this stuff until now.  Thanks to bz for noticing this.

Comment 1

[Mike Schroepfer]

Dmose we gonna get this fixed?

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

With a few exceptions, I'm mostly focused on MailCo-related hacking now.  Reassigning a bunch of bugs to default component owners.  I'm happy to help with brainstorming/advice as needed, however.  

Search for the string MAILMONKEY to delete any bugmail generated by this change.

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch

Not sure if that is enough. Anything else to modify?

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 318362 [details] [diff] [review]
patch

I think this is it.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 318362 [details] [diff] [review]
patch

maybe we should migrate those prefs to the RDF DS?

Comment 6

[Ludovic Hirlimann [:Usul]]

ping for sr ? Shwn

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch (mozilla-central) (checked in)

Comment 8

[Shawn Wilsher :sdwilsh]

This doesn't contain an API change, and so doesn't need sr anymore.

Comment 10

[Wolfgang Rosenauer [:wolfiR]]

http://hg.mozilla.org/mozilla-central/rev/b17077657692

Comment 11

[Magnus Melin [:mkmelin]]

I think we'll need this for thunderbird3, there's been a fair number of reports of people being unable to open links due to this.

Comment 12

[Mark Banner (:standard8)]

Magnus, you're closer to this than I am, can you request 1.9.1 approval with a risk analysis if you think we need to for TB 3. Thanks.

Comment 13

[Magnus Melin [:mkmelin]]

Comment on attachment 395299 [details] [diff] [review]
patch (mozilla-central) (checked in)

Requesting branch approval so we can get this for tb3. This patch affects unix code only. The risk shouldn't be very high, given that it's pretty broken as is for users who had the old prefs set. 

The gain is obvious as not being able to open links in a mail is quite frustrating. I think the prefs were fairly commonly used as it used to be hard to get things working as you wanted without them a few years back.

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 395299 [details] [diff] [review]
patch (mozilla-central) (checked in)

Seems reasonable enough, but I'd like some 1.9.2 testing/baking before approving for 1.9.1

Comment 16

[Daniel Veditz [:dveditz]]

Comment on attachment 395299 [details] [diff] [review]
patch (mozilla-central) (checked in)

Please re-request 1.9.1 approval after this lands on 1.9.2

Since this is a non-blocking bug you may need to track down the drivers via IRC or mail because this may never bubble onto their queries.

Comment 17

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 395299 [details] [diff] [review]
patch (mozilla-central) (checked in)

a192=beltzner

Comment 18

[Mark Banner (:standard8)]

I pushed this to 1.9.2 so we can get some baking time before we need it on 1.9.1 for TB 3: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4114e5200fbb

Comment 20

[Mark Banner (:standard8)]

Comment on attachment 395299 [details] [diff] [review]
patch (mozilla-central) (checked in)

Requesting 1.9.1 branch approval, please see comment 13 for more details.

I've taken a look through the recently filed bugs and not found any regressions filed.

Comment 21

[Daniel Veditz [:dveditz]]

Comment on attachment 395299 [details] [diff] [review]
patch (mozilla-central) (checked in)

Approved for 1.9.1.4, a=dveditz for release-drivers

Comment 22

[Mark Banner (:standard8)]

Checked into 1.9.1 branch:

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d6b7f6c45a8e

Had to adjust the patch slightly because bug 469023 isn't on 1.9.1 - but this just meant not doing a change in an ifdef section.

Comment 23

[Al Billings [:abillings - ex-MoCo]]

Can I get clear repro steps for this issue so QA can verify it is fixed and close it?

Comment 24

[Mark Banner (:standard8)]

(In reply to comment #23)
> Can I get clear repro steps for this issue so QA can verify it is fixed and
> close it?

Bug 480709 was duped to this bug. Bug 480709 comment 19 look like reasonably clear STR (but other comments on that bug might be useful as well).

Comment 25

[Elmar Stellnberger]

I don`t see how this should be resolved!
Thunderbird 3.0b4 still ignores the network.protocol-handler.app.http(s) property and still does not offer a user friendly way to select the default browser.

Comment 26

[Al Billings [:abillings - ex-MoCo]]

Elmar, why do you think it is in Thunderbird, Beta 4? Did someone tell you it was fixed in that build? This was checked into 1.9.1, where Thunderbird 3 is built from, on September 14. I suspect that TB Beta 4 was forked before this went in and you'll need to check in the final release.

You could also get a 1.9.1 Thunderbird nightly at ftp://ftp.mozilla.org/pub/thunderbird/nightly/latest-comm-1.9.1/ and check to see if it is fixed there.

Comment 27

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to comment #25)
> I don`t see how this should be resolved!

This bug was about removing a bunch of code, not about restoring the old functionality.

> Thunderbird 3.0b4 still ignores the network.protocol-handler.app.http(s)
> property and still does not offer a user friendly way to select the default
> browser.

If you feel the UI offered in the Attachments pane of the preferences dialog is insufficient in some way, feel free to file another bug.  You may wish to look through the Gecko file-handling bugs first, as there are already some bugs filed on various deficiencies related to that UI.  Feel free to CC me on any bug you file.

Comment 29

[David Taber]

This bug is still in the code as of Eudora 1.0 rc1 (which I guess is based on T'Bird 3.0.4.

Is the protocol to open a new one, or reopen this one?

Comment 30

[David Taber]

Sorry, I hit the "save" button too soon.

The symptom I'm referring to is "https links in emails don't work."  This is on Windows XP, with Firefox as the target browser for T'Bird

network.protocol-handler.app.https;firefox

Everything works fine with the corresponding ftp and http links.

Comment 31

[Dan Mosedale (:dmosedale, :dmose)]

A new bug would be great; thanks!