scale thumb too narrow on Windows Vista

RESOLVED FIXED

Status

()

Toolkit
XUL Widgets
P4
major
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Steffen Wilberg, Assigned: Neil Deakin)

Tracking

({access, testcase})

Trunk
x86
Windows Vista
access, testcase
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

11 years ago
The thumb on the scale widget is much too small on Windows Vista. IIRC this isn't a problem on Windows XP.
(Reporter)

Comment 1

11 years ago
Created attachment 274993 [details]
testcase

Just a vertical and a horizontal <scale>.
(Reporter)

Comment 2

11 years ago
Created attachment 274995 [details]
screenshot

Updated

11 years ago
Severity: normal → major
Flags: blocking1.9?

Comment 3

11 years ago
I can confirm this bug, I noticed it when using an extension with a slider bar. Specifically a mockup for the solution to Bug 389628. I'd imagine that there are several bugs that depend on this bug being fixed.
(Reporter)

Updated

11 years ago
Blocks: 333484

Updated

11 years ago
Keywords: access

Comment 4

11 years ago
Neil, do we need to use native-theming to get the correct thumb size (can we, even)?
Assignee: nobody → enndeakin
Flags: blocking1.9? → blocking1.9+
(Assignee)

Comment 5

11 years ago
The thumb size is a always a fixed size (30x15 or 15x30) set in css and the native theme code is just calling ::DrawEdge with that size.
(Reporter)

Updated

11 years ago
Blocks: 389628
(Assignee)

Comment 6

11 years ago
Ignore that last comment. I was looking at the wrong thing.

The scale thumb is already native themed, but it seems that GetThemePartSize on Vista returns an incorrect value. We may just want to hardcode some values here, or just disable the native theming and use the default css values.

 
(Reporter)

Updated

11 years ago
Blocks: 401219
No longer blocks: 389628

Updated

11 years ago
Priority: -- → P4
(Assignee)

Comment 7

10 years ago
Created attachment 300657 [details] [diff] [review]
use a hardcoded size on Vista
Attachment #300657 - Flags: ui-review?(roc)
Attachment #300657 - Flags: review?(roc)
Comment on attachment 300657 [details] [diff] [review]
use a hardcoded size on Vista

booooo Vista!
Attachment #300657 - Flags: ui-review?(roc)
Attachment #300657 - Flags: ui-review+
Attachment #300657 - Flags: review?(roc)
Attachment #300657 - Flags: review+
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.