390737 - On Vista, every menulist should be a menubutton

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P3)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Vista applications use menulists instead of menubuttons in their preferences.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Example of menubutton use in Vista (Windows Calendar)

This is an example of menubutton use in Vista, from the application Windows Calendar.  I was unable to find a menulist in any preferences dialog of any application shipping with Vista.

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

Would fixing this require a new theme for Vista?

Comment 3

[Benjamin Smedberg]

It looks like this has the exact same behavior as the current menulist: it's just styled differently. Is that correct? If so, we could probably manage this entirely with nsITheme-ing, though I wouldn't call it easy.

Should this be the case for *all* XUL menulists, or are there cases where we'd still want the old-style white menulist?

Comment 4

[James Ross]

All non-editable drop-downs take on the button-like appearance on Vista. The drop-down list part is unaffected, so it should fairly straighforward use of if(Vista && !editable) in the native theme code for:

 - menulist: background is combobox/5.
 - menulist-button: arrow is combobox/6 (LTR) and combobox/7 (RTL).

Comment 5

[James Ross]

Just to be a bit clearer; the combobox/6 and combobox/7 items are the buttons for editable drop-downs, use of either of those in state 1 (normal) or a system icon gives the drop-down arrow.

Comment 6

[Rob Arnold [:robarnold]]

While we're fixing menulists, we should change the size of those menuitems to be smaller on all windows platforms to match the native size.

Alex, I still think we want a new theme for vista because in trying to fix the scrollbars, I could not find the part/state combination that I need, so we'd need to use an image for some states (scrollbars are the biggest distraction for me right now). Also, for most of the menu changes that I had to do, it would have been much easier/clearer to use CSS in a separate theme. The same might be true in this case, I'm not sure.

Comment 7

[James Ross]

Rob, got a bug# for the scrollbars? I don't know of anything you can't do with them in Vista from the theme API, so I'm interested in your problem.

Comment 8

[Rob Arnold [:robarnold]]

James, see the (recently filed) bug 391541. There are a few more polish bugs for vista that I'd like to see fixed.

Comment 9

[Carsten Book [:Tomcat]]

Litmus Triage Team: i will add the test case in Litmus.

Comment 10

[alexander :surkov (:asurkov)]

Marco, how comboboxes on vista exposed to AT, is there any difference?

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

Nominating for blocking to pick up wanted.

Comment 12

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This is fixed by the patch in bug 418552.