420232 - (vista-theme) use chrome overrides to style winstripe for Vista Aero

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Bug 419319 introduced a strategy for using chrome overrides to allow the winstripe theme to style elements differently for XP (Luna) and Vista (Aero).

This bug will be used to track the various bugs that will be used to create Vista (Aero) specific styling.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Ryan: is the best solution here to just change

chrome://browser/skin/browser.css

to

chrome://platform-browser/skin/browser.css

and then use chrome overrides to point to skin/browser.css and skin/browser-aero.css?

Do we want to start with a patch that does that, allowing all of the patches on these dependent bugs to just modify browser-aero.css?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Assuming we take the second patch in bug 419319, you'll just need to package the files twice, once in the "luna" subdir of the JAR, and once in the "aero" subdir, using different or the same images as needed.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Adding some more dependencies ...

(See also bug 333484 which was used to track several other vista-appearance related fixes)

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

To do chrome overrides, what you want to do is ..:

 - identify the resource you want to change (ex: foo.file)
 - create a new file called foo-aero.file
 - make your modifications in that new file
 - add that new path to the aero part of the manifest file, like

     /skin/classic/aero/global/foo.file            (foo-aero.file)

For CSS, preprocessing can help you such that you can include the original resource, like:

 *  /skin/classic/aero/global/foo.css              (foo-aero.css)

foo-aero.css

%include foo.css

//overrides and changes here