Bug 420232 (vista-theme)

use chrome overrides to style winstripe for Vista Aero

VERIFIED FIXED in Firefox 3

Status

()

defect
VERIFIED FIXED
12 years ago
10 years ago

People

(Reporter: beltzner, Unassigned)

Tracking

(Depends on 1 bug, {meta})

Trunk
Firefox 3
x86
Windows Vista
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Bug 419319 introduced a strategy for using chrome overrides to allow the winstripe theme to style elements differently for XP (Luna) and Vista (Aero).

This bug will be used to track the various bugs that will be used to create Vista (Aero) specific styling.
Version: unspecified → Trunk
Ryan: is the best solution here to just change

chrome://browser/skin/browser.css

to

chrome://platform-browser/skin/browser.css

and then use chrome overrides to point to skin/browser.css and skin/browser-aero.css?

Do we want to start with a patch that does that, allowing all of the patches on these dependent bugs to just modify browser-aero.css?
No longer blocks: 420234
Depends on: 420234
No longer blocks: 420236
Depends on: 420236
Depends on: 420237
Assuming we take the second patch in bug 419319, you'll just need to package the files twice, once in the "luna" subdir of the JAR, and once in the "aero" subdir, using different or the same images as needed.
Adding some more dependencies ...

(See also bug 333484 which was used to track several other vista-appearance related fixes)
Depends on: 390737, 392644, 418537, 418552, 419383
Alias: vista-theme
Depends on: 420414
Keywords: meta
To do chrome overrides, what you want to do is ..:

 - identify the resource you want to change (ex: foo.file)
 - create a new file called foo-aero.file
 - make your modifications in that new file
 - add that new path to the aero part of the manifest file, like

     /skin/classic/aero/global/foo.file            (foo-aero.file)

For CSS, preprocessing can help you such that you can include the original resource, like:

 *  /skin/classic/aero/global/foo.css              (foo-aero.css)

foo-aero.css

%include foo.css

//overrides and changes here
No longer depends on: 426712
No longer depends on: 390734
No longer depends on: 392644
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 3
You need to log in before you can comment on or make changes to this bug.