391447 - Mingw build error - error: no matching function for call to `nsDerivedSafe<nsICaseConversion>::ToUpper

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Martijn Wargers (dead)]

After I updated my tree, I get this build error:
-Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -m
ms-bitfields -pipe  -DDEBUG -D_DEBUG -DDEBUG_mw -DTRACING -g   -DMOZILLA_CLIENT
-include ../../../../mozilla-config.h /cygdrive/c/mozilla/mozilla/extensions/spe
llcheck/hunspell/src/suggestmgr.cpp
In file included from c:/mozilla/mozilla/extensions/spellcheck/hunspell/src/sugg
estmgr.hxx:74,
                 from c:/mozilla/mozilla/extensions/spellcheck/hunspell/src/sugg
estmgr.cpp:69:
c:/mozilla/mozilla/extensions/spellcheck/hunspell/src/atypes.hxx:65:30: warning:
 anonymous variadic macros were introduced in C99
csutil.cpp
/cygdrive/c/mozilla/mozilla/build/cygwin-wrapper g++ -mno-cygwin -o csutil.o -c
 -DMOZILLA_INTERNAL_API -DOSTYPE=\"WINNT5.1\" -DOSARCH=WINNT  -I../../../../dist
/include/xpcom -I../../../../dist/include/string -I../../../../dist/include/ucon
v -I../../../../dist/include/unicharutil -I../../../../dist/include/spellchecker
 -I../../../../dist/include/xulapp -I../../../../dist/include   -I../../../../di
st/include/hunspell -I../../../../dist/include/nspr  -DMOZ_PNG_READ -DPNG_NO_MMX
_CODE -DMOZ_PNG_WRITE   -I../../../../dist/sdk/include       -fno-rtti -fno-exce
ptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsy
nth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -mms-b
itfields -pipe  -DDEBUG -D_DEBUG -DDEBUG_mw -DTRACING -g   -DMOZILLA_CLIENT -inc
lude ../../../../mozilla-config.h /cygdrive/c/mozilla/mozilla/extensions/spellch
eck/hunspell/src/csutil.cpp
In file included from c:/mozilla/mozilla/extensions/spellcheck/hunspell/src/csut
il.cpp:68:
c:/mozilla/mozilla/extensions/spellcheck/hunspell/src/atypes.hxx:65:30: warning:
 anonymous variadic macros were introduced in C99
c:/mozilla/mozilla/extensions/spellcheck/hunspell/src/csutil.cpp: In function `s
hort unsigned int unicodetoupper(short unsigned int, int)':
c:/mozilla/mozilla/extensions/spellcheck/hunspell/src/csutil.cpp:5221: error: no
 matching function for call to `nsDerivedSafe<nsICaseConversion>::ToUpper(short
unsigned int&, short unsigned int*)'
../../../../dist/include/unicharutil/nsICaseConversion.h:56: note: candidates ar
e: virtual nsresult nsICaseConversion::ToUpper(PRUnichar, PRUnichar*) <near matc
h>
../../../../dist/include/unicharutil/nsICaseConversion.h:65: note:
   virtual nsresult nsICaseConversion::ToUpper(const PRUnichar*, PRUnichar*, PRU
int32)
c:/mozilla/mozilla/extensions/spellcheck/hunspell/src/csutil.cpp: In function `s
hort unsigned int unicodetolower(short unsigned int, int)':
c:/mozilla/mozilla/extensions/spellcheck/hunspell/src/csutil.cpp:5241: error: no
 matching function for call to `nsDerivedSafe<nsICaseConversion>::ToLower(short
unsigned int&, short unsigned int*)'
../../../../dist/include/unicharutil/nsICaseConversion.h:59: note: candidates ar
e: virtual nsresult nsICaseConversion::ToLower(PRUnichar, PRUnichar*) <near matc
h>
../../../../dist/include/unicharutil/nsICaseConversion.h:68: note:
   virtual nsresult nsICaseConversion::ToLower(const PRUnichar*, PRUnichar*, PRU
int32)
make[6]: *** [csutil.o] Error 1
make[6]: Leaving directory `/cygdrive/c/mozilla/mozilla/extensions/spellcheck/hu
nspell/src'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/cygdrive/c/mozilla/mozilla/extensions/spellcheck/hu
nspell'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/cygdrive/c/mozilla/mozilla/extensions/spellcheck'
make[3]: *** [libs_tier_toolkit] Error 2
make[3]: Leaving directory `/cygdrive/c/mozilla/mozilla'
make[2]: *** [tier_toolkit] Error 2
make[2]: Leaving directory `/cygdrive/c/mozilla/mozilla'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/cygdrive/c/mozilla/mozilla'
make: *** [alldep] Error 2

I guess this happens because bug 319778 is fixed now.

Comment 1

[Németh László]

I don't know, what is the problem. Maybe you did't update or rebuild the full tree, including unicharutil. Warnings about anonymous variadic macros solved in the bug 391147.

Comment 2

[Martijn Wargers (dead)]

Attachment: workaround

This is how I workaround the build error. So this is the place where the build error occurs.

I think I see in struct cs_info * get_current_cs some code that makes the necessary conversions for mingw, but I'm not sure.

Comment 3

[Martijn Wargers (dead)]

Attachment: patch

Comment 4

[Németh László]

Martijn, thanks for your patch.
Does type casting work on MinGW? If yes, I will use that:

PRUnichar ch2;
getcaseConv()->ToUpper((PRUnichar) c, &ch2);

(In reply to comment #3)
> Created an attachment (id=277516) [details]
> patch
> 

Comment 5

[Martijn Wargers (dead)]

Attachment: patchv2

Yeah, that seems to work fine.

Comment 6

[Martijn Wargers (dead)]

Attachment: patchv2

oops, wrong file.

Comment 7

[Németh László]

Thanks for the quick check and the patch. It seems, it will be good for the other platforms, too.

(In reply to comment #6)
> Created an attachment (id=277540) [details]
> patchv2
> 
> oops, wrong file.
> 

Comment 8

[Martijn Wargers (dead)]

Ok, so what next?
Will this be fixed upstream and fixed in Mozilla as soon as hunspell is updated in Mozilla?
Or should I check the patch already in Mozilla? (as soon as I have the appropriate reviews)

Comment 9

[Németh László]

I release Hunspell 1.1.10 with this patch within a hour. Scott?

Comment 10

[Scott MacGregor]

ryan enjoys porting the latest hunspell releases into the mozilla repository :)

Comment 11

[Martijn Wargers (dead)]

Comment on attachment 277540 [details] [diff] [review]
patchv2

Ok, that's great to hear.
Go, Ryan, go! ;)

Comment 12

[Martijn Wargers (dead)]

This should be fixed now that bug 394261 landed.