392812 - Restart button in Installation tab remains grayed out after an update of multiple extensions

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Peter van der Woude [:Peter6]]

Attachment: screenshot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081910 Minefield/3.0a8pre ID:2007081910

repro:
set extensions.checkCompatibility false
Open the add-ons manager and check for update(s)
When you're lucky, AM jumps to the installation tab
Install the update(s)

result:
the updates are installed, but the Resyart button remains grayed out.
when you go to the extensions tab, the Restart button can be used.

expected:
the restart button in the installation tab to work

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Is this related to bug 390878?

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Or bug 351819, more likely.

Comment 3

[Peter van der Woude [:Peter6]]

bug 351819 is branch, and I really don't know if the trunk add-ons manager (code) is the same.

bug 390878 has too little information about how to reproduce.
extensions.checkCompatibility false wasn't mentioned

Comment 4

[Robert Strong (they/them - no direct email)]

Bug 351819 at one point was also trunk though I haven't verified whether we reenable the button with the change to the ui code.

Can you reproduce without extensions.checkCompatibility set to false. extensions.checkCompatibility is for testing and is use at your own risk so if this is the only way to reproduce this bug will be a lower priority.

Comment 5

[Peter van der Woude [:Peter6]]

(In reply to comment #4)
> Can you reproduce without extensions.checkCompatibility set to false.
> extensions.checkCompatibility is for testing and is use at your own risk so if
> this is the only way to reproduce this bug will be a lower priority.
> 

Yeah, same happens when extensions.checkCompatibility is true
(neither extension is compatible with FF3.0A7 though)

Comment 6

[Robert Strong (they/them - no direct email)]

This sounds like it is a dupe of Bug 351819 in that we don't update the state after a compatibility check (due to there being nothing to inform us at present).

Comment 7

[Dave Townsend [:mossop]]

This is a somewhat different case to bug 351819 (which now appears fixed). This bug only happens when updating extensions, and from my tests it appears only when updating multiple extensions. When the updates are running the restart button is enabled, when all the updates have finished the restart button disabled.

The extensions I was testing with required no compatibility update check.

Comment 9

[Dave Townsend [:mossop]]

Attachment: patch rev 1

There's a combination of failures going on here:

updateOptionalViews isn't resetting gInstallCount.

updateOptionalViews (correctly I think) counts downloads that are waiting and will in the future send DOWNLOAD_START.

The DOWNLOAD_START and INSTALL_DONE handlers are not called if we are viewing a pane of the add-ons UI that doesn't contain the relevant add-on.

The patch removes the gInstallCount increment and instead ensures we always call updateOptionalViews and updateGlobalCommands after any new downloads are added (I think that should be happening anyway). Then I ensure that the INSTALL_DONE handler is always used. This has a side effect of displaying installation errors even when not on the install pane, I think that's sensible too.

There is also a minor change to the extension manager, not actually needed but I can't see why we should maintain multiple entries in the transactions list for a single transaction. And deleting a function parameter apparently does nothing and there appears no need to anyway.

Comment 10

[Gerd]

Just a remark: The Restart button is also grayed out after updating a _single_ extension (not only after updating multiple extensions as the topic suggests).

Comment 11

[Dave Townsend [:mossop]]

Checking in toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <--  extensions.js
new revision: 1.141; previous revision: 1.140
done
Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.246; previous revision: 1.245
done