351819 - When installing an incompatible extension that is made compatible via its update rdf the Restart button is not enabled (1.8 branch only)

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Pavel Cvrcek [:JasnaPaka]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060908 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060908 BonEcho/2.0b2

Latest Thunderbird 2.0 NB:
1. Open Add-ons dialog.
2. Choose Install, select extension from local drive, confirm install dialog. 

Reproducible: Always

Actual Results:  
Section "Installation" is showed but button "Restart Thunderbird" is disabled.

Expected Results:  
Section "Installation" is showed, button "Restart Thunderbird" is enabled.

When I choose section "Extensions" and next "Installation", button is enabled. Maybe same problem in latest Firefox 2.0 NB but there is Install button disabled by default.

Comment 1

[Adam Guthrie]

This is an Add-ons manager problem. I saw this early this summer and pointed it out to Robert Strong, but I guess it never got filed.

Comment 2

[Adam Guthrie]

The problem can be reproduced with the Mouse Gestures extension for Firefox. https://addons.mozilla.org/firefox/39/

Comment 3

[Adam Guthrie]

*** Bug 352164 has been marked as a duplicate of this bug. ***

Comment 4

[Bob Clary [:bc] (inactive)]

The version of Adblock that I installed in Bug 352164 wasn't incompatible fwiw.

Comment 5

[Robert Strong (they/them - no direct email)]

(In reply to comment #4)
> The version of Adblock that I installed in Bug 352164 wasn't incompatible fwiw.
Actually, the version of adblock you installed in Bug 352164 was only compatible with versions up to 2.0a3 and has a minVersion of 0.7. So, unless you were using 2.0a3 or below it was incompatible.

Comment 6

[Robert Strong (they/them - no direct email)]

*** Bug 356647 has been marked as a duplicate of this bug. ***

Comment 7

[Carsten Book [:Tomcat]]

*** Bug 358545 has been marked as a duplicate of this bug. ***

Comment 8

[Dave Miller [:justdave]]

With the number of extensions that *didn't* break between 1.5 and 2.0, this is pretty visible now (because there's a lot of extensions that didn't have to be updated for 2.0 and only had their maxVersion bumped on the addons site).  I've run into this on almost every extension I've installed in 2.0 so far.

Comment 9

[Dave Miller [:justdave]]

Attachment: screenshot

Comment 10

[Jay Patel [:jay]]

Not blocking, but we will take a patch is something turns up.  Rob says they're going to figure this out for 3.0 eventually... so we can port it to the branches then.

Comment 15

[Scott MacGregor]

I've been getting a lot of reports from thunderbird users running into this too.

Comment 17

[Martijn Wargers (dead)]

Attachment: This 'fixes' it

Comment 18

[Robert Strong (they/them - no direct email)]

iirc when I looked at this a while back this won't fix it when on a slow connection and the update rdf is not cached due to doing an install instead of an update? I think the better solution is to rewrite the EM service to handle it but if this does in fact fix it in the case I asked then I am all for it until the EM can be rewritten.

Comment 19

[Martijn Wargers (dead)]

Ah,I guess that explains why I have to use such a large timer. I guess this won't work for slow connections. I don't know anything about this code. The patch is just a hack. Clearly, something more sensible should be done.

Comment 22

[Dave Townsend [:mossop]]

This appears fixed by bug 369075 (or one of its dependencies)

Comment 25

[François Gagné]

Should this be reopened by comment #19? This bug affect Firefox 2.0.0.x

Comment 26

[Robert Strong (they/them - no direct email)]

2.0 Branch only. Fixed on trunk by bug 369075

Comment 27

[Bill Gianopoulos [:WG9s]]

(In reply to comment #26)
> 2.0 Branch only. Fixed on trunk by bug 369075
> 

Well,now that there is no longer a permanent restart button on trunk either (which is what bug 369075 did to fix this) this seems to be back there as well.

Comment 28

[Bill Gianopoulos [:WG9s]]

(In reply to comment #27)
> (In reply to comment #26)
> > 2.0 Branch only. Fixed on trunk by bug 369075
> > 
> 
> Well,now that there is no longer a permanent restart button on trunk either
> (which is what bug 369075 did to fix this) this seems to be back there as well.
> 
Hmm. Guess I should have done this first.  When I went back to document the steps to reproduce I could not reproduce it.  Something must have recently changed as i did run into this when applying updates within the last couple of weeks.

Either that or there is something else required to run into the issue.  In either event it would appear to be different than this bug.

Comment 29

[Dave Townsend [:mossop]]

This was fixed on trunk by bug 396129 which is not viable for the branch.

Comment 30

[Dave Townsend [:mossop]]

Per comment 29 this is fixed in Firefox 3, we're not going to be porting a fix back to Firefox 2.

Comment 31

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #30)
> Per comment 29 this is fixed in Firefox 3, we're not going to be porting a fix
> back to Firefox 2.

In that case we should close this bug, which is about mozilla1.8, as WONTFIX and not FIXED. As you have said bug 396129 is about mozilla1.9.