392820 - Bookmarks "star" panel should capture keyboard shortcuts

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Click the bookmark star on a page that is already bookmarked.
2. Press Esc.
     Expected: the panel should close.
     Result: nothing happens.
3. Press Cmd+W.
     Expected: the panel should close.
     Result: the browser tab closes!!!  (But the panel remains!)

It captures mouse clicks outside of itself, so it should capture keyboard shortcuts too.  (That includes Cmd+T, Cmd+], etc.)

Comment 1

[Mike Connor [:mconnor]]

I think this is a known bug with panels.  IMO Cmd+W should be a no-op, this isn't a window.

Comment 2

[Dietrich Ayala (:dietrich)]

(In reply to comment #1)
> I think this is a known bug with panels.  IMO Cmd+W should be a no-op, this
> isn't a window.
> 

I agree wrt to Cmd+W. However, Esc (or some other intuitive shortcut) should close the panel.

Comment 5

[Asaf Romano (gone)]

Attachment: some improvements

* block accel+w/accel+shift+w
 * close the panel on enter/esc
 * focus the name-field/picker and select its contents when opening the panel.
 * focus the content-area when the panel is closed.

Comment 6

[Jesse Ruderman]

> focus the content-area when the panel is closed.

It would be better to return focus to where it was before you clicked the star or pressed Cmd+D.  This would be more in line with how dialogs work.

Comment 7

[Asaf Romano (gone)]

Jesse: please file a follow once I land this patch, implementing that may not be trivial given the current double-click+popup interaction.

Comment 8

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-places.js 1.47

Comment 9

[Tracy Walker [:tracy]]

verified with - Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre

Comment 10

[Jesse Ruderman]

I filed bug 402499 on the restoring-focus issue (comment 6).

Comment 11

[Steve England [:stevee]]

It looks like this caused bug 409155

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv