392980 - nsFaviconLoadListener needs to list nsIRequestObserver in its IMPL_ISUPPORTS line (###!!! ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr')

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

###!!! ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr', file ../../../dist/include/xpcom/nsCOMPtr.h, line 594

It's because nsFaviconLoadListener inherits from nsIRequestObserver but can't be QI'd to it:

800 NS_IMPL_ISUPPORTS3(FaviconLoadListener,
801                    nsIStreamListener, // is a nsIRequestObserver
802                    nsIInterfaceRequestor,
803                    nsIChannelEventSink)

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in toolkit/components/places/src/nsFaviconService.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsFaviconService.cpp,v  <--  nsFaviconService.cpp
new revision: 1.16; previous revision: 1.15
done

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv