Open Bug 393733 Opened 17 years ago Updated 2 years ago

Allow resizing the search bar in Customize Toolbars mode

Categories

(Firefox :: Toolbars and Customization, enhancement, P4)

enhancement

Tracking

()

People

(Reporter: jruderman, Unassigned)

References

Details

Attachments

(1 file)

I think it should be possible to resize the search bar and address bar by just dragging while in Customize Toolbars mode.  Reasons:

1) Users coming from Firefox 2 might not have the splitter on the toolbar. (Bug 267831 added the splitter to the default set, used by new profiles, but did not make changes to existing profiles.)

2) Many users want the search bar to be a size other than the default but don't want to resize it often enough to justify having a splitter.  For these users, resizing it takes a zillion steps (enter CT mode, put the splitter on the toolbar, exit CT mode, resize, enter CT mode again, remove the splitter, exit CT mode again).
Blocks: 267831
Blocks: 398023
Flags: blocking-firefox3?
Blocking on me for a ui-decision and a confab with Neil
Assignee: nobody → beltzner
Flags: blocking-firefox3? → blocking-firefox3+
Keywords: uiwanted
Target Milestone: --- → Firefox 3 M10
If you're going to do this, the splitter should be removed from the default set ASAP, so that it doesn't creep in new profiles of users trying out Beta 1.
Beltzner's bug 400327 suggests an alternate solution: automatically add splitter whenever location bar and search bar are adjacent.
OS: Mac OS X → All
Hardware: PC → All
Blocks: 393718
Priority: -- → P2
Blocks: 403732
Blocks: 405072
No longer blocks: 405072
I would like there to always be a splitter between the fields, but to only give it a visual affordance (grippy things) when the customization pallet is visible.
I should add that Dao notes in bug 393718 that this is a non-trivial change, so likely out of scope for 3.
That was merely a guess, probably Enn can tell how hard it really is.
Is this still on table after the fix for bug 393718 which made the "grippy" invisible.  It needs to be discoverable somehow!
>It needs to be discoverable somehow!

The mouse cursor change makes the feature discoverable (albeit really hard to discover).  But I'm still in favor of displaying a visual affordance when the customization window is up.
(In reply to comment #5)
> I should add that Dao notes in bug 393718 that this is a non-trivial change, so
> likely out of scope for 3.

Just tried it ... adding a splitter is trivial and it's actually functional. However, the width of the url and search bars don't persists, presumably because the splitter doesn't change their width directly but instead the width of the wrapper elements that we add in the customizing mode (#wrapper-urlbar-container, #wrapper-search-container).
Attached patch WIPSplinter Review
I think this works, still need to test it.
Assignee: beltzner → dao
Status: NEW → ASSIGNED
Keywords: uiwanted
Summary: Allow resizing the search bar in Customize Toolbars mode (without adding a splitter) → Allow resizing the search bar in Customize Toolbars mode
Target Milestone: Firefox 3 M10 → Firefox 3 M11
Attachment #296825 - Attachment description: WIP → patch
Attachment #296825 - Flags: review?(mano)
Comment on attachment 296825 [details] [diff] [review]
WIP

Ok, so I think this doesn't work good enough and is not worth it.
Attachment #296825 - Attachment description: patch → WIP
Attachment #296825 - Flags: review?(mano)
Assignee: dao → nobody
Status: ASSIGNED → NEW
Target Milestone: Firefox 3 beta3 → ---
Priority: P2 → P4
Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.
Flags: wanted-firefox3+
Flags: blocking-firefox3-
Flags: blocking-firefox3+

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: