393748 - Active tasks are dimmed (grey) in task list while completed tasks are shown in black

Status: VERIFIED FIXED

(Calendar :: Tasks, enhancement)

Description

[AnyFile]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4pre) Gecko/20070614 Sunbird/0.5

At the moment completed task are displayed full color (black) and struck, while not-completed task are displayed dimmed (grey).

I think that people should need to read easier task to-be-done (not-completed) than task completed. Moreover to-do task should be more evident than completed task. 

So I think it would be better if not-completed task would in in full color (black) and completed task in dimmed (and struck).

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Martin Schröder [:mschroeder]]

Christian, what is your opinion as Calendar UI/UX guy? :)

Comment 2

[Michael]

I was going to make this exact same comment.  The color scheme for tasks seems backwards, with pending tasks dim (in silver) and completed tasks more obvious (in black).  This is true in both the task pane proper and the task portion of the Today pane.  

Even if you do not want to make the change universal, allowing custom fonts or font colors for those items would fix the problem, although the easiest solution would be to just reverse the current color scheme for completed and pending tasks.

Comment 3

[Michael]

So I just took a look and this is very trivial to fix.  All you have to do is reverse the color of the following two fields:

.calendar-task-tree > treechildren::-moz-tree-cell-text(future) {
    color: gray;
}

.calendar-task-tree > treechildren::-moz-tree-cell-text(completed) {
    text-decoration: line-through;
    color: black;
}

Maybe no one particularly wants to change it (it's certainly not a bug as much as a UI choice), but it still seems very odd to me to emphasize (with the darker text) completed tasks and deemphasize (with the lighter text) pending tasks.

Comment 4

[Christian Jansen]

(In reply to comment #1)
> Christian, what is your opinion as Calendar UI/UX guy? :)

I do not like the current color coding. I agree that it would be better to change it. 
* not-completed -> black
* completed tasks -> gray (and struck).

Comment 5

[Stefan Sitter [:ssitter]]

If the proposal from comment #4 will be implemented this would fix Bug 367190 too.

Comment 6

[Thomas D. (:thomas8)]

Which file do I have to change if I want to change the css as suggested in bug 393748, comment #3?

Comment 7

[Thomas D. (:thomas8)]

Which file do I have to change if I want to change the css as suggested in bug
393748, comment #3?
I am using lightning 0.9 with TB 2 on Windows XP

Comment 8

[Michael]

Those lines are found in the calendar.jar file

Comment 9

[AnyFile]

Thanks to all

I have done the change proposed in comment #3 and all worked perfectly.

The file that need to be changed is the file skin/classic/calendar/calendar-task-tree.css that is inside the calendar.jar

Is this change to be include in future releases?

Comment 10

[Simon Paquet [:sipaq]]

Attachment: Patch v1

I changed the issue described in the bug and also moved some color definitions over to system colors.

Before patch:
Without selection: http://www.babylonsounds.com/calendar/task-view-old-unselected.png
With selection: http://www.babylonsounds.com/calendar/task-view-old-selected.png

After patch:

Without selection: http://www.babylonsounds.com/calendar/task-view-new-unselected.png
With selection: http://www.babylonsounds.com/calendar/task-view-new-selected.png

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 342934 [details] [diff] [review]
Patch v1

Looks good, r=philipp

Comment 12

[Stefan Sitter [:ssitter]]

> I changed the issue described in the bug and also moved
> some color definitions over to system colors.

Does this help to solve the issue from Bug 351145? Or does the new color schema has the same issue?

Comment 13

[Simon Paquet [:sipaq]]

(In reply to comment #12)
>> I changed the issue described in the bug and also moved
>> some color definitions over to system colors.
> 
> Does this help to solve the issue from Bug 351145? Or does the new color schema
> has the same issue?

This fixes the issue for the task list. I don't know what the status for the unifinder is.

Comment 14

[Christian Jansen]

Comment on attachment 342934 [details] [diff] [review]
Patch v1

looks good for me.
Thanks for improving the colors.
r=christian

Comment 15

[Simon Paquet [:sipaq]]

Pushed changeset 614:553e9cd0297a to comm-central.

Comment 16

[Andreas Treumann]

checked with nightly build 200801015052201 -> VERIFIED

Comment 18

[Philipp Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".