39389 - No context menus in "view source" window

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, enhancement, P1)

Description

[Jerry Baker]

Mozilla has regressed to the lowly state of NS 4.X's view source window - with 
no way to use the mouse to copy text. I am not sure when this happened, but 
there did use to be context menus in the view source window.

Build: 2000051520

Comment 1

[Asa Dotzler [:asa]]

Um, this is not a Browser General bug.  Updating component.  Jerry Baker, 
please take a look at http://bugzilla.mozilla.org/describecomponents.cgi?
product=Browser (the word 'Component' links to this component description 
page).  You will find that bugs get addressed much more swiftly when they are 
assigned to the proper component and owners.  Browser General is reserved for 
issues that do not fall into one of the other components.  View Source belongs 
to XPApps.  Thanks for your help in testing Mozilla and reporting bugs.

Comment 2

[Jerry Baker]

Yeah, I looked through the entire list. I wasn't sure whether it was an XPApp 
bug because it occured in a View Source window, or if it was an XPMenus thing 
because it involves a context menu.

Comment 3

[Asa Dotzler [:asa]]

over to XPApps

Comment 4

[sairuh (rarely reading bugmail)]

this'd be good... it'd go hand in hand with bug 26593.

Comment 5

[Chris McAfee]

over to Bill, Mr. Context Menu

Comment 6

[gabriel]

It would be cool if the context menu had 'find in source' and 'find again'. Is
that part of the spec ?

Comment 7

[sairuh (rarely reading bugmail)]

spam: adding se-radar so that a query gets this easily.

Comment 8

[sairuh (rarely reading bugmail)]

over to blake, per conversation over irc.

Comment 9

[Zach Lipton [:zach]]

keyword

Comment 10

[Blake Ross]

view source is next big priority.

Comment 11

[Blake Ross]

alright, so, other than "copy" and "select all", what items do we need in a 
context menu?  Keep in mind that we will have a [limited] menubar, so we don't 
necessarily need items like Find to be in the context menu

Comment 12

[Matthew T (active 1999-2002)]

Hummm.

  Find _Previous        [finds previous occurrence of selection]
  Find _Next            [finds next occurrence of selection]
----------------------
  _Copy
----------------------
  Select _All

That's my best guess right now. It maintains consistency of position of `Copy' 
between the context menu for View Source and the context menu for a text field 
(unfortunately we can't do the same for `Select All'); and the `Find Previous' 
and `Find Next' (which I would imagine being two of the most common activities in 
the view source window) are symmetrical with the `Back' and `Forward' in the 
context menu for a Web page.

Comment 13

[gabriel]

I'd like just plain 'find' in there as well. Otherwise it can be a nightmare
finding the exact right piece of source you're interested in.

Comment 14

[Blake Ross]

Doron, want to take this one also along with your other view source menu work?

Comment 15

[Doron Rosenberg (IBM)]

ok, i'll tackle this, since the view source menu is done and pending review. 
The only thing really here is to write a function for the find previous.

Comment 16

[Blake Ross]

-> Doron

Comment 17

[Doron Rosenberg (IBM)]

-> 0.9.1, patch is ready, need viewsourcemenu to land first.

Comment 18

[Doron Rosenberg (IBM)]

depends also on 77704, inorder to get "find previous: to work in a contextmenu

Comment 19

[Skewer]

We do need the "Find" option in the CM for view source. Find works in that
window anyway if you use Ctrl+F. Another thought, maybe we should have a word
wrap option? I'm not sure if there's a right way to do this with HTML files, but
it's worth a shot for sites with much-too-wide source code...

Comment 20

[Doron Rosenberg (IBM)]

there is a wordwrap bug filed

Comment 21

[gabriel]

Ctrl-F in the view source window does not work for me (Linux 2001042721).

Comment 22

[Simon Fraser [no longer active]]

What does that have to do with this bug?

Comment 23

[Skewer]

Ctrl-F is the standard keyboard shortcut for "Find" in Windows. Maybe it's
different for Linux?

Comment 24

[sairuh (rarely reading bugmail)]

i believe the Find issue is covered by bug 71173. as for unix, ^F [ctrl+F] moves
forward one character at a time in textfields and textareas --methinks this
wouldn't be an issue for the view source window since it's read-only.

Comment 25

[Doron Rosenberg (IBM)]

this is fixed with the viewsource menu patch (ctrl-f)

Comment 26

[sairuh (rarely reading bugmail)]

sorry, i'm confused --did you mean this was supposedly fixed for the same thing
as in bug 71173? [if so, it isn't with my 16:44 debug build.] or, were you
referring to a fix which hasn't been checked in yet [well, post 16:44 :) ]? tia!

Comment 27

[Doron Rosenberg (IBM)]

i think so, if not, it will be fixed with the viewsource menu ui, as it works
locally ;)

Comment 28

[sairuh (rarely reading bugmail)]

oh, heh --i might be running into bug 78725 in my 5/8 verif build and bug 79720
in my debug build from y'day...

Comment 29

[Doron Rosenberg (IBM)]

->1.0, depends on when 77704 goes in

Comment 30

[Doron Rosenberg (IBM)]

accepting

Comment 31

[Boris Zbarsky [:bzbarsky]]

*** Bug 101062 has been marked as a duplicate of this bug. ***

Comment 32

[Boris Zbarsky [:bzbarsky]]

doron, I thought you had this working....

Comment 33

[Doron Rosenberg (IBM)]

Attachment: proposed patch

Comment 34

[Doron Rosenberg (IBM)]

Attachment: better patch

Comment 35

[Boris Zbarsky [:bzbarsky]]

r=bzbarsky.  Nice.

Comment 36

[Doron Rosenberg (IBM)]

cc: alecf for sr= check.

the "find next" to viewsource.dtd will be removed when my find next/find
previous patch lands.

Comment 37

[Alec Flett]

Comment on attachment 50552 [details] [diff] [review]
better  patch

sure, why not. sr=alecf

Comment 38

[Blake Ross]

Those observes="*" should be command="*"

Comment 39

[Boris Zbarsky [:bzbarsky]]

Attachment: patch addressing blake's comment

Comment 40

[Doron Rosenberg (IBM)]

Comment on attachment 50950 [details] [diff] [review]
patch addressing blake's comment

my bad, r=doron

Comment 41

[Boris Zbarsky [:bzbarsky]]

checked in with sr=blake on irc

Comment 42

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2001.11.08.0x-comm bits on linux rh6.2, winnt and mac os 10.1.

the context menu in View Source contains three items:

Find Next
Copy
Select All

Comment 43

[Jerry Baker]

Mass removing self from CC list.

Comment 44

[Jerry Baker]

Now I feel sumb because I have to add back. Sorry for the spam.