monitor/manage disk usage of offline apps in the UI

RESOLVED FIXED in Firefox 3 beta4

Status

()

Firefox
General
P3
normal
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

({late-l10n})

unspecified
Firefox 3 beta4
late-l10n
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

v3
15.35 KB, patch
Neil Deakin
: review+
mconnor
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Created attachment 282184 [details] [diff] [review]
v1

This patch adds a disk usage column to the offline app management UI, and adds a disk usage warning when the app uses up too much disk space.
Attachment #282184 - Flags: review?(mconnor)
(Assignee)

Updated

11 years ago
Blocks: 398161
(Assignee)

Updated

11 years ago
Attachment #282184 - Attachment is patch: true
Attachment #282184 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 1

11 years ago
I thought I'd asked for blocking on this...

Should I be updating this patch?
Flags: blocking-firefox3?
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P3
Target Milestone: --- → Firefox 3 beta4
(Assignee)

Comment 2

10 years ago
Created attachment 302718 [details] [diff] [review]
v2

Updated patch.
Attachment #282184 - Attachment is obsolete: true
Attachment #302718 - Flags: review?(mconnor)
Attachment #282184 - Flags: review?(mconnor)
(Assignee)

Updated

10 years ago
Keywords: late-l10n
(Assignee)

Updated

10 years ago
Attachment #302718 - Flags: ui-review?(beltzner)
Comment on attachment 302718 [details] [diff] [review]
v2

>+offlineApps.usage=This website (%S) is using more than %SMB of data on your computer.
>+offlineApps.manageUsage=Show offline data use
>+offlineApps.manageUsageAccessKey=S

some wording nits:

offlineApps.usage=This website (%S) is now storing more than %SMB of data on your computer for offline use.
offlineApps.manage=Show settings

I think we can just remove the "Allow" button entirely, for now. I don't want to give the impression that the user has a choice here beyond going into their settings and blocking the site or deleting the data.

Otherwise ui-r=beltzner.
Attachment #302718 - Flags: ui-review?(beltzner) → ui-review+
pre-facto-a+ on a string-only patch in case this doesn't get reviewed in time to hit the string freeze
(Assignee)

Comment 5

10 years ago
Checked in strings with requested changes:

Checking in browser.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.properties,v  <--  browser.properties
new revision: 1.66; previous revision: 1.65
done
Checking in preferences/preferences.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.properties,v  <--  preferences.properties
new revision: 1.29; previous revision: 1.28
done
Comment on attachment 302718 [details] [diff] [review]
v2


>+    return win;
>   }
>   else
>-    openDialog("chrome://browser/content/preferences/preferences.xul",
>-               "Preferences", features, paneID);
>+    return openDialog("chrome://browser/content/preferences/preferences.xul",
>+                      "Preferences", features, paneID);
>+}

else after return, ew.

>diff --git a/browser/components/preferences/advanced.css b/browser/components/preferences/advanced.css
>new file mode 100644
>--- /dev/null
>+++ b/browser/components/preferences/advanced.css

is there an existing content css file for preferences that we can tack onto, rather than having a mostly-spam file?

otherwise looks ok
Attachment #302718 - Flags: review?(mconnor) → review+
(Assignee)

Comment 7

10 years ago
Created attachment 305617 [details] [diff] [review]
v3

* Removes "Allow" button and the logic to not show the warning again
* Moves the bindings to handlers.css/xml.  We should probably rename those to preferences.css/xml, I'll file a followup.
* Fixes else-after-return.

Neil should take a look at the nsDOMStorage.cpp change...
Attachment #302718 - Attachment is obsolete: true
Attachment #305617 - Flags: review?(enndeakin)

Updated

10 years ago
Attachment #305617 - Flags: review?(enndeakin) → review+
Comment on attachment 305617 [details] [diff] [review]
v3

rs=me on the domstorage change
Attachment #305617 - Flags: superreview+
(Assignee)

Comment 9

10 years ago
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.977; previous revision: 1.976
done
Checking in browser/base/content/utilityOverlay.js;
/cvsroot/mozilla/browser/base/content/utilityOverlay.js,v  <--  utilityOverlay.js
new revision: 1.62; previous revision: 1.61
done
Checking in browser/components/preferences/advanced.js;
/cvsroot/mozilla/browser/components/preferences/advanced.js,v  <--  advanced.js
new revision: 1.33; previous revision: 1.32
done
Checking in browser/components/preferences/handlers.css;
/cvsroot/mozilla/browser/components/preferences/handlers.css,v  <--  handlers.css
new revision: 1.3; previous revision: 1.2
done
Checking in browser/components/preferences/handlers.xml;
/cvsroot/mozilla/browser/components/preferences/handlers.xml,v  <--  handlers.xml
new revision: 1.6; previous revision: 1.5
done
Checking in dom/src/storage/nsDOMStorage.cpp;
/cvsroot/mozilla/dom/src/storage/nsDOMStorage.cpp,v  <--  nsDOMStorage.cpp
new revision: 1.23; previous revision: 1.22
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

10 years ago
Filed 419699 about renaming handlers.[css,xml]

Updated

10 years ago
Depends on: 419840

Comment 12

10 years ago
after this checkin, 

with new profile,
Advanced>Network >>> Offline Strage
Use up to 50000 MB ....

I think this is too large. 

before this checkin, cache is 50MB.
(Assignee)

Comment 13

10 years ago
(In reply to comment #12)
> after this checkin, 
> 
> with new profile,
> Advanced>Network >>> Offline Strage
> Use up to 50000 MB ....
> 
> I think this is too large. 
> 
> before this checkin, cache is 50MB.

This should be fixed by the patch in 419840.
(Assignee)

Updated

10 years ago
Depends on: 424017
You need to log in before you can comment on or make changes to this bug.