397417 - monitor/manage disk usage of offline apps in the UI

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[Dave Camp (:dcamp)]

Attachment: v1

This patch adds a disk usage column to the offline app management UI, and adds a disk usage warning when the app uses up too much disk space.

Comment 1

[Dave Camp (:dcamp)]

I thought I'd asked for blocking on this...

Should I be updating this patch?

Comment 2

[Dave Camp (:dcamp)]

Attachment: v2

Updated patch.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 302718 [details] [diff] [review]
v2

>+offlineApps.usage=This website (%S) is using more than %SMB of data on your computer.
>+offlineApps.manageUsage=Show offline data use
>+offlineApps.manageUsageAccessKey=S

some wording nits:

offlineApps.usage=This website (%S) is now storing more than %SMB of data on your computer for offline use.
offlineApps.manage=Show settings

I think we can just remove the "Allow" button entirely, for now. I don't want to give the impression that the user has a choice here beyond going into their settings and blocking the site or deleting the data.

Otherwise ui-r=beltzner.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

pre-facto-a+ on a string-only patch in case this doesn't get reviewed in time to hit the string freeze

Comment 5

[Dave Camp (:dcamp)]

Checked in strings with requested changes:

Checking in browser.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.properties,v  <--  browser.properties
new revision: 1.66; previous revision: 1.65
done
Checking in preferences/preferences.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.properties,v  <--  preferences.properties
new revision: 1.29; previous revision: 1.28
done

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 302718 [details] [diff] [review]
v2


>+    return win;
>   }
>   else
>-    openDialog("chrome://browser/content/preferences/preferences.xul",
>-               "Preferences", features, paneID);
>+    return openDialog("chrome://browser/content/preferences/preferences.xul",
>+                      "Preferences", features, paneID);
>+}

else after return, ew.

>diff --git a/browser/components/preferences/advanced.css b/browser/components/preferences/advanced.css
>new file mode 100644
>--- /dev/null
>+++ b/browser/components/preferences/advanced.css

is there an existing content css file for preferences that we can tack onto, rather than having a mostly-spam file?

otherwise looks ok

Comment 7

[Dave Camp (:dcamp)]

Attachment: v3

* Removes "Allow" button and the logic to not show the warning again
* Moves the bindings to handlers.css/xml.  We should probably rename those to preferences.css/xml, I'll file a followup.
* Fixes else-after-return.

Neil should take a look at the nsDOMStorage.cpp change...

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 305617 [details] [diff] [review]
v3

rs=me on the domstorage change

Comment 9

[Dave Camp (:dcamp)]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.977; previous revision: 1.976
done
Checking in browser/base/content/utilityOverlay.js;
/cvsroot/mozilla/browser/base/content/utilityOverlay.js,v  <--  utilityOverlay.js
new revision: 1.62; previous revision: 1.61
done
Checking in browser/components/preferences/advanced.js;
/cvsroot/mozilla/browser/components/preferences/advanced.js,v  <--  advanced.js
new revision: 1.33; previous revision: 1.32
done
Checking in browser/components/preferences/handlers.css;
/cvsroot/mozilla/browser/components/preferences/handlers.css,v  <--  handlers.css
new revision: 1.3; previous revision: 1.2
done
Checking in browser/components/preferences/handlers.xml;
/cvsroot/mozilla/browser/components/preferences/handlers.xml,v  <--  handlers.xml
new revision: 1.6; previous revision: 1.5
done
Checking in dom/src/storage/nsDOMStorage.cpp;
/cvsroot/mozilla/dom/src/storage/nsDOMStorage.cpp,v  <--  nsDOMStorage.cpp
new revision: 1.23; previous revision: 1.22
done

Comment 10

[Dave Camp (:dcamp)]

Filed 419699 about renaming handlers.[css,xml]

Comment 11

[Jim Jeffery not reading bug-mail 1/2/11]

This fix may have caused: https://bugzilla.mozilla.org/show_bug.cgi?id=419840

Comment 12

[pal-moz]

after this checkin, 

with new profile,
Advanced>Network >>> Offline Strage
Use up to 50000 MB ....

I think this is too large. 

before this checkin, cache is 50MB.

Comment 13

[Dave Camp (:dcamp)]

(In reply to comment #12)
> after this checkin, 
> 
> with new profile,
> Advanced>Network >>> Offline Strage
> Use up to 50000 MB ....
> 
> I think this is too large. 
> 
> before this checkin, cache is 50MB.

This should be fixed by the patch in 419840.