Closed Bug 398689 Opened 17 years ago Closed 17 years ago

Missing access key for Preferences -> Advanced -> Network -> Cache -> Clear Now

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3 beta3

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

(Keywords: access)

Attachments

(1 obsolete file)

Attached patch Add the access key (obsolete) — — Splinter Review 
The Clear Now button in the Advanced tab of Preferences, the Network section does not have an access key.  The attached patch adds this access key defined in mozilla/browser/locales/en-US/chrome/browser/preferences/privacy.dtd.
Attachment #283685 - Flags: review?(mano)
Target Milestone: --- → Firefox 3 M9
Comment on attachment 283685 [details] [diff] [review]
Add the access key

This conflicts with privacy.xul's usage...
Attachment #283685 - Flags: review?(mano) → review-
(In reply to comment #1)
> (From update of attachment 283685 [details] [diff] [review])
> This conflicts with privacy.xul's usage...

Hmmm, I'm not sure I understand what you mean here.

The Clear Now button comes from bug 352447, where the patch in attachment 238160 [details] [diff] [review] pulls off the labels from privacy.dtd, and needless to say, privacy.xul already uses the label.

My patch just uses the corresponding access key from privacy.dtd.  I don't see how that would conflict with privacy.xul's usage...  Unless what you mean is copying the strings into advanced.dtd, and get rid of the privacy.dtd dependency altogether.
Comment on attachment 283685 [details] [diff] [review]
Add the access key

Re-requesting review based on comment 2...
Attachment #283685 - Flags: review- → review?(mano)
Comment on attachment 283685 [details] [diff] [review]
Add the access key

Requesting review from gavin, since this has been sitting in mano's queue for a long time...
Attachment #283685 - Flags: review?(mano) → review?(gavin.sharp)
Whiteboard: [has patch] [needs review gavin]
Target Milestone: Firefox 3 M9 → Firefox 3 M11
Looks like this exact patch was landed as part of bug 406387.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [has patch] [needs review gavin]
Attachment #283685 - Attachment is obsolete: true
Attachment #283685 - Flags: review?(gavin.sharp)
Verifying:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2007121305 Minefield/3.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: