399468 - Can open multiple bookmark popups on clicking folders after right-click context menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Martijn Wargers (dead)]

To reproduce:
- Open Bookmarks menu
- Right-click on a bookmark
- Click on one or more folders

Actual result:
- Folder opens, but context menu stays open too. When clicking on more folders, more folder popups open, but the previous ones don't close.

Expected result:
- Folder opens and the context menu should disappear.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Is this a regression?

Comment 2

[Martijn Wargers (dead)]

Yes, this regressed between 2007-07-04 and 2007-07-05, so I guess a regression from bug 279703.

Comment 3

[Neil Deakin]

This is an easy fix but I also notice a regression of bug 385616 while testing the fix which I'm going to investigate as well as both involve the same block of code. Sadly, we can't make automnated tests here as they require a means of sending native messages to a window.

Comment 4

[Neil Deakin]

Attachment: check context menu state

When building the list of widgets for the open submenus, stop when reaching a menu that is not a context menu. This way, the parent non-context menu (the bookmarks menu in this test) isn't considered part of the menu chain, and the mouse click causes the menus to roll up rather than fire the mousedown at the menu.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 285106 [details] [diff] [review]
check context menu state

Sure.

It's worth finding someone else to learn this code so you don't have to rely on me for all the reviews...  Pretty soon now those are going to be very laggy.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 285106 [details] [diff] [review]
check context menu state

a=endgame drivers for after M9 freeze

Comment 8

[Reed Loden [:reed]]

Checking in layout/xul/base/src/nsXULPopupManager.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsXULPopupManager.cpp,v  <--  nsXULPopupManager.cpp
new revision: 1.32; previous revision: 1.31
done

Comment 9

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2) Gecko/2007121014 Firefox/3.0b2

Comment 10

[Aakash Desai [:aakashd]]

Test case https://litmus.mozilla.org/show_test.cgi?id=7480 has been created on litmus for any future regression testing on this bug.