Need pref for IMAP expunge threshold

RESOLVED FIXED in Thunderbird 3

Status

Thunderbird
Preferences
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Jeff Beckley, Assigned: Dale Wiggins)

Tracking

Trunk
Thunderbird 3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

10 years ago
When an IMAP account is using the IMAP delete model (i.e. deleted messages are not removed from the mailbox right away, but instead just marked as deleted), messages marked as deleted don't get permanently removed ("expunged" in IMAP terminology) until a certain number of messages have been marked as deleted.

Currently, that threshold is hard-coded at 20 messages.  It should instead be a preference which the user can set.
(Reporter)

Comment 1

10 years ago
Created attachment 284944 [details] [diff] [review]
Pref added and used
Attachment #284944 - Flags: superreview?
Attachment #284944 - Flags: review?(bienvenu)
(Reporter)

Comment 2

10 years ago
Created attachment 284945 [details] [diff] [review]
Pref added and used

Here's an implementation of the pref, which is named "mail.imap.expunge_threshold_number".
Attachment #284945 - Flags: superreview?(mscott)
Attachment #284945 - Flags: review?(bienvenu)
(Reporter)

Updated

10 years ago
Attachment #284944 - Attachment is obsolete: true
Attachment #284944 - Flags: superreview?
Attachment #284944 - Flags: review?(bienvenu)
(Reporter)

Updated

10 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 3

10 years ago
Re-assigning to Dale Wiggins <dwiggins@qualcomm.com> since he's the one that wrote the code (I'm just submitting it for him).
Assignee: beckley → dwiggins
Status: ASSIGNED → NEW

Comment 4

10 years ago
+static PRBool gExpungeThreshold = 20;

PRInt32 might work better;)
(Reporter)

Comment 5

10 years ago
Created attachment 284951 [details] [diff] [review]
Fix for pref type

Argh!  Had that change locally, but it didn't make it in to the first patch.  Here it is now.
Attachment #284945 - Attachment is obsolete: true
Attachment #284951 - Flags: superreview?(mscott)
Attachment #284951 - Flags: review?(bienvenu)
Attachment #284945 - Flags: superreview?(mscott)
Attachment #284945 - Flags: review?(bienvenu)

Comment 6

10 years ago
Comment on attachment 284951 [details] [diff] [review]
Fix for pref type

looks good, thx
Attachment #284951 - Flags: review?(bienvenu) → review+

Comment 7

10 years ago
Comment on attachment 284951 [details] [diff] [review]
Fix for pref type

looks good!
Attachment #284951 - Flags: superreview?(mscott) → superreview+

Comment 8

10 years ago
Checking in mailnews/mailnews.js;
/cvsroot/mozilla/mailnews/mailnews.js,v  <--  mailnews.js
new revision: 3.308; previous revision: 3.307
done
Checking in mailnews/imap/src/nsImapProtocol.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.cpp,v  <--  nsImapProtocol.cpp
new revision: 1.672; previous revision: 1.671
done

->FIXED
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.