Last Comment Bug 399998 - some preference dialogs have an access key for close and some don't
: some preference dialogs have an access key for close and some don't
Status: RESOLVED FIXED
: polish
Product: Firefox
Classification: Client Software
Component: Preferences (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 6
Assigned To: Johannes Buchner
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-10-16 05:38 PDT by timeless
Modified: 2011-06-29 05:19 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Escape now closes the permission manager (1.87 KB, patch)
2009-08-06 23:24 PDT, Johannes Buchner
sdwilsh: review+
faaborg: ui‑review+
Details | Diff | Splinter Review
Escape now closes the cookie manager (1.65 KB, patch)
2009-08-06 23:46 PDT, Johannes Buchner
sdwilsh: review+
faaborg: ui‑review+
Details | Diff | Splinter Review

Description timeless 2007-10-16 05:38:27 PDT
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101304 Minefield/3.0a9pre

steps
1. tools>options
2. in each tab click all buttons that have ellipsis and look for Cancel/Close/OK.

Certificate Manager: OK (no access key, escape closes)
Manage CRLs: Close (no access key, escape closes)
Device Manager: OK (no access key, escape closes)
Don't Remember Passwords: Close (no access key, escape closes)
Remember Passwords: Close (no access key, escape closes)
Cookies: Close (access key "C", escape is ignored outside search field, in search field it triggers clear button)
Exceptions - Images: Close (access key "C", escape is ignored)

I know that some of these windows are sizable and some aren't, but I think the behaviors here are strange. If I want to close a window, I can always use alt-f4, so I see no reason to offer alt-L.
Comment 1 Johannes Buchner 2009-08-06 23:24:11 PDT
Created attachment 393139 [details] [diff] [review]
Escape now closes the permission manager

requesting review
requesting 'rs= '

This lets the Exceptions window close (Images & Popups).
Comment 2 Johannes Buchner 2009-08-06 23:46:30 PDT
Created attachment 393140 [details] [diff] [review]
Escape now closes the cookie manager

requesting review
requesting 'rs= '

This lets the Cookie window close on escape.
Comment 4 Shawn Wilsher :sdwilsh 2011-05-02 12:58:26 PDT
Comment on attachment 393139 [details] [diff] [review]
Escape now closes the permission manager

r=sdwilsh
Comment 5 Shawn Wilsher :sdwilsh 2011-05-02 12:59:00 PDT
Comment on attachment 393140 [details] [diff] [review]
Escape now closes the cookie manager

r=sdwilsh
Comment 6 Phil Ringnalda (:philor, back in August) 2011-05-14 21:16:19 PDT
http://hg.mozilla.org/mozilla-central/rev/8b6d6c128641
Comment 7 George Carstoiu 2011-06-29 05:19:36 PDT
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110629 Firefox/7.0a1

I am still unable to close the Security -> Saved passwords window using the ESC key.

Wasn't that also expected?

Note You need to log in before you can comment on or make changes to this bug.