Closed Bug 399998 Opened 17 years ago Closed 13 years ago

some preference dialogs have an access key for close and some don't

Categories

(Firefox :: Settings UI, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 6

People

(Reporter: timeless, Assigned: buchner.johannes)

Details

(Keywords: polish)

Attachments

(2 files)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101304 Minefield/3.0a9pre

steps
1. tools>options
2. in each tab click all buttons that have ellipsis and look for Cancel/Close/OK.

Certificate Manager: OK (no access key, escape closes)
Manage CRLs: Close (no access key, escape closes)
Device Manager: OK (no access key, escape closes)
Don't Remember Passwords: Close (no access key, escape closes)
Remember Passwords: Close (no access key, escape closes)
Cookies: Close (access key "C", escape is ignored outside search field, in search field it triggers clear button)
Exceptions - Images: Close (access key "C", escape is ignored)

I know that some of these windows are sizable and some aren't, but I think the behaviors here are strange. If I want to close a window, I can always use alt-f4, so I see no reason to offer alt-L.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
Assignee: nobody → buchner.johannes
requesting review
requesting 'rs= '

This lets the Exceptions window close (Images & Popups).
Attachment #393139 - Flags: review?
Attachment #393139 - Flags: review? → review?(gavin.bugzilla)
OS: Windows XP → All
Hardware: x86 → All
requesting review
requesting 'rs= '

This lets the Cookie window close on escape.
Attachment #393140 - Flags: review?
Attachment #393140 - Flags: review? → review?(gavin.bugzilla)
Attachment #393139 - Flags: review?(gavin.bugzilla) → review?(gavin.sharp)
Attachment #393140 - Flags: review?(gavin.bugzilla) → review?(gavin.sharp)
Attachment #393140 - Flags: ui-review?(faaborg)
Attachment #393139 - Flags: ui-review?(faaborg)
Attachment #393139 - Flags: ui-review?(faaborg) → ui-review+
Attachment #393140 - Flags: ui-review?(faaborg) → ui-review+
Comment on attachment 393139 [details] [diff] [review]
Escape now closes the permission manager

r=sdwilsh
Attachment #393139 - Flags: review?(gavin.sharp) → review+
Comment on attachment 393140 [details] [diff] [review]
Escape now closes the cookie manager

r=sdwilsh
Attachment #393140 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mozilla-central/rev/8b6d6c128641
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110629 Firefox/7.0a1

I am still unable to close the Security -> Saved passwords window using the ESC key.

Wasn't that also expected?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: