283613 - windows do not exit on pressing the escape button.

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[Joël Kuiper]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050225 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050225 Firefox/1.0+

In the new Options UI
"Block Popups [allowed sites]" , "Install software [allowed sites]" and "load
images [exceptions]" windows do not exit on pressing the escape button. 

Reproducible: Always

Comment 1

[Steve England [:stevee]]

Confirming

Comment 2

[Mike Connor [:mconnor]]

These are windows, not dialogs, therefore Escape is not a valid close key. 
Ctrl-W works.

Comment 3

[Joël Kuiper]

Then they should be dialogs. Or all the other windows(Connect Settings,Download
History,View saved passwords) should have the 'close on escape' function removed.
The way it is right now is just horribly inconsistant

Comment 4

[Mike Connor [:mconnor]]

That's probably true, although connection settings is a dialog, not a window.

Comment 5

[Anton van Bohemen]

Besides that, they were dialogs in the old options panel.

Comment 6

[Worcester12345]

(In reply to comment #4)
> That's probably true, although connection settings is a dialog, not a window.

Then there should be a new bug to fix that inconsistency problem.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

They cannot be dialogs due to dialog depth problems. 

Comment 8

[Anton van Bohemen]

I'm not a programmer, but what exactly is the depth problem here?

Options -> General -> Connection Settings seems 2 layers deep te me
Options -> Content -> Fonts section, Advanced... also seems 2 layers deep.
Both are dialogs and can be closed with escape. Both windows as well as the
Allowed Sites/Excepions windows have no further buttons to open a new (deeper)
window. So to me it seems that those windows can also be dialogs.

I found only some options that go deeper than 2 windows:
Downloads -> View and edit actions -> Change action
Advanced -> Security -> View Certificates -> View
and a few other Advanced - Security options

If 2 dialogs deep is the limit, I think it can (and should) be used for the
allowed sites/exceptions options.

Comment 9

[Mike Connor [:mconnor]]

*** Bug 283747 has been marked as a duplicate of this bug. ***

Comment 10

[Michael Kristensen]

*** Bug 295256 has been marked as a duplicate of this bug. ***

Comment 11

[:Gavin Sharp [email: [e-mail]]]

*** Bug 306195 has been marked as a duplicate of this bug. ***

Comment 12

[:Gavin Sharp [email: [e-mail]]]

*** Bug 308026 has been marked as a duplicate of this bug. ***

Comment 13

[Nuno Gonçalo Brito]

In connection with bug 308026 I made a survey of all the windows launched from
the "Options" dialog and found that the only ones which are windows instead of
modal dialogs are:
Button name:            -> Dialog/Window name:
-------------------------------------------------
View Saved Passwords    -> Password Manager
View Download History   -> Downloads
View Cookies            -> Cookies
Exceptions              -> Exceptions - Cookies
Allowed Sites           -> Allowed Sites - Popups
Allowed Sites           -> Software Installation
Exceptions              -> Exceptions - Images
View & Edit Actions     -> Download Actions

Except for the "Downloads" window can anybody give me a good reason for having
any of the other windows lying arround instead of being modal dialogs? Is there
some situation where it may be necessary? Is it usefull in some specific
scenario? If there is then ok, but if there isn't then it should be changed
because the current behaviour is not coherent.
I use Firefox since version 0.8 and I except for the "Downloads" window, I only
used them for something in the configuration ("Options").
In Firefox 1.0.6, all the windows launched from the "Options" dialog are
themselves modal dialogs. In my view, that is what the users are expecting (at
least Microsoft Windows users). From my experience using Microsoft Windows
applications, any window launched from a modal dialog is itself a modal dialog
or behaves like one.

Comment 14

[Reed Loden [:reed]]

*** Bug 317656 has been marked as a duplicate of this bug. ***

Comment 15

[:Gavin Sharp [email: [e-mail]]]

*** Bug 339146 has been marked as a duplicate of this bug. ***

Comment 16

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change