400854 - XUL menulist reacts to command keys with modifiers

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Milan Zamazal]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a9pre) Gecko/2007102316 Minefield/3.0a9pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a9pre) Gecko/2007102316 Minefield/3.0a9pre

When I define a global key command in a XUL page, bind the command to Control+SOMETHING and then try to invoke the command when some drop-down list element happens to be focused, the drop-down list changes its selected value (if SOMETHING matches some of its items) and invokes its own command (if any is bound to the menuitem). It behaves the same way as if SOMETHING was pressed without the Control modifier.

Reproducible: Always

Steps to Reproduce:
1. Open the XUL URL given above.
2. Press TAB to get the combo box element in focus.
3. Press Control+A and watch the raised dialogs.
Actual Results:  
Combo box selected value changes from "xxxxx" to "abcde", the menuitem command is called and only then the actual command bound to Control-A gets called.

Expected Results:  
Combo box value does not change after pressing the Control+A key combination (it remains "xxxxx") and the menuitem command doesn't get called.  Only the command bound to Control+A in <keyset> is called.

Comment 1

[Aaron Leventhal]

This is a blocker for folks wanting to use XUL as a cross platform GUI toolkit.

Comment 2

[[e-mail]]

Attachment: Proposed patch

Comment 3

[[e-mail]]

Attachment: -w version for review

What's happening is that the menulist's key handler's modifier mask is being ignored because the binding isn't specifying a key or char code.

Comment 4

[[e-mail]]

Pushed changset 92611f230d1c to mozilla-central.