Closed Bug 401856 (fx3-wsl10n-cs) Opened 17 years ago Closed 16 years ago

Web service changes in Czech Firefox 3

Categories

(Mozilla Localizations :: cs / Czech, defect)

Product:
Mozilla Localizations
Component:
cs / Czech
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: p.franc, Assigned: p.franc)

References

Details

Attachments

(2 files, 1 obsolete file)

Requested SE changes
6.58 KB, patch
Details | Diff | Splinter Review
Additional SE changes
6.88 KB, patch
Pike
: review+
Details | Diff | Splinter Review 
This is a bug for requesting overall approval for changes in Search engines, Bookmarks, RSS feed, etc in Czech Firefox 3

*Search engines*
For FF2 approval see bug 348094

  google
  seznam-cz
- centrum-cz
  jyxo-cz
  mall-cz
  slunecnice-cz
+ wikipedia-cz

Wikipedia added by decision in bug 380785, centrum (yahoo like portal) removed due its "not-so-big" popularity. Seznam.cz and Slunecnice.cz plugins were updated to their new versions to reflect the search engine parameters changes.

*RSS feed handler*
For FF2 approval see bug 350912

Seznam.cz
- Clanky.cz (Jyxo)
+ Clanky.Jyxo.cz
Bloglines

Same service and RSS feed handler provider, for more see bug 399585

*Bookmarks*
No changes

*Live bookmark feed*
No changes


Axel, could you assign this bug to the right MoCo person please.
Mic, any thoughts on centrum-cz? I'll attach a diff that already landed for the changes at large, we'll need the site owners to review and approve those changes, I guess?
Whiteboard: needs-mic
hi
i'll do a review of new suggestions and get back to you'all shortly
we will need permission for new additions from providers. 
mic

I reverted the trunk SE changes back to MOZ1.8 state due the the b1 release.
The attached patch contains requested SE changes for FF3
Attachment #286802 - Attachment is obsolete: true
reviewed change to search engine's ok - no need for permission from wikipedia for addition
question on Feed Reader change - given that the provider is the same and the domain is only different I do not believe we need permission from them. team can you confirm this?
adding new protocol handlers to this bug as well for tracking purposes:
mailto protocol:
Seznam Email (able to handle mailto protocol) should be added as default. Can you please provide me a contact there to ask for permission for this change.
Atlas is also important mail app in cs but not currently able to handle mailto protocol

calendar protocol:
no suggestions at present, so US defaults will be enabled. Mic will look for market data to see if there are any other options
(In reply to comment #5)
> question on Feed Reader change - given that the provider is the same and the
> domain is only different I do not believe we need permission from them. team
> can you confirm this?

We have permission from Michal Illich in bug 399585.
thanks axel
team - I need seznam current email address (my last contact email doens't seem to work anymore) to gain permission for mailto protocol
pavel - can you get permission from seznam for mailto protocol and the correct URL and place that inofmration in this bug ASAP

on search: 
Jyxo: noticed that you changed the name for jyxo to jyxo-cz -- any reason for that? can you document that in this bug and also any changes to parameters or urls
Obchody: noticed changes as well to Obchody MALL.cz -- same thing please explain.

it shows up on our diff tests and so we flag it if we don't have a documented capture of that change.
thanks
(In reply to comment #10)
> pavel - can you get permission from seznam for mailto protocol and the correct
> URL and place that inofmration in this bug ASAP
Petr send an email about providing the mailto handler on January 11. I'll check with him what the status is.

> on search: 
centrum-cz.xml ... no changes (although I would be fond of removing it) 

jyxo-cz.xml ... updated ShortName, Description and removed unused parameter skip=0 to match http://jyxo.cz/jyxo-osd.xml

mall-cz.xml ... updated ShortName, Description and Url to match http://www.mall.cz/static/mallcz/opensearch.xml

seznam-cz.xml ... updated Description and Url to match http://download.seznam.cz/opensearch/seznam-cz.xml

slunecnice-cz.xml ... update the whole plugin to reflect complete site redesign

wikipedia-cz.xml ... new plugin according the en-US

Do we need an explicit permission from the site owners for such changes. If yes, I'll send them email and ask.


First of all, you need explicit review from Mozilla. That is, Mic, or someone she defers to for technical reviews, likely me or Gavin.

Updating to whatever a site currently uses may or may not be fine, that's totally dependent on the actual change.

Looking at the actual changes:
Removing centrum-cz, that needs Mic, and I guess you should detail on your reasoning, if you haven't done so outside of this bug.

jyxo is probably fine, dropping them a note would be nice.

mall.cz needs confirmation from the site, you're changing the tracking flags. They might actually use that to track different distribution channels.

slunecnice, do we need to fix that plugin on the branch, like, is it broken right now?

wikipedia is probably OK, the url should be http://cs.wikipedia.org/wiki/Speci%C3%A1ln%C3%AD:Search (or the non-encoded utf-8 of that). Still adding wikipedia is a decision that's made on a per-locale basis, so just referring to en-US doesn't cut it.

Basically, any check-in to region.properties or searchengines needs a reviewed patch, and the check-in comment should reference that bug. Not just any bug vaguely related.

We let this slip for B3, but for final release, we need traction here.
Assignee: l10n → p.franc
Blocks: fx3-l10n-cs
I'm a little bit confused. In comment #5 Mic said that "reviewed change to search engine's ok - no need for permission from wikipedia for addition". So I assumed that they are ok.

jyxo.cz ... Mik (CCing), would you mind to tell to Michal.
mall.cz .. I'll ask them.
slunecnice.cz ... branch should be fine, they are backward compatible right now
wikipedia ... oked by comment #5, search url based on http://wiki.mozilla.org/Firefox3/L10n_Requirements#Wikipedia

centrum.cz ... It has about 1-1.5% of fulltext SE market share and we already have 3 fulltext SE's - Seznam, Google, Jyxo. Personally I would rather prefer less cluttered SE list or some specialized not fulltext SE such as mapy.cz (high quality map engine with the local company search). 

(In reply to comment #13)
> jyxo.cz ... Mik (CCing), would you mind to tell to Michal.

Michal Illich (owner of Jyxo) was informed and he replied it should be ok.
Mall.cz do a small improvments to their plugin http://s.mall.cz/webs2/mallcz/opensearch.xml and ask to remove the .php extension in url and change their icon. They will send their confirmation to Mic afterwards.
Ah, slowly grokking the details of this bug again. We backed the initial patch out for B1 and B2. Comments 4 and 5 slipped my attention.

To make sure that that doesn't happen again, there are two pieces of review, at least, one is the review of the search set and setup, that's on Mic's lap. As well as making sure that we have permission by all of them. And then there's the review of the technical implementation, where either I or gavin jump in.

The change is really only considered to be reviewed once the patch has an r+ flag by me, or by someone appointed by Mic, likely gavin.

Mic, make sure you state that more explicitly when noting your review?
hi guys following up on comments #5 and #13.
following from email discussion on January 6th, we did in fact agree that wikipedia-cz would replace centrum-cz. Centrum is more of a portal so not as good value to users as wikipedia and it's less popular.

only thing outstanding as I understand now is mailto protocol from Seznam (and possibly Atlas). 

Pavel, please LMK if I missed anything, otherwise, an updated patch is probably warranted at this point
Whiteboard: needs-mic → needs-mic, needs-patch
ping
Whiteboard: needs-mic, needs-patch → needs-patch
Did we get approval on mall-cz changes?

Jyxo has an errornous '>' in the ShortName.

slunecnice seems to be OK technically, we should probably drop them a note that we're using the other API now.

wikipedia could use an update of the ShortName to match the new title on the site, "Wikipedie (cs)".

Seznam needs at least a note, too, the checked-in changes drop the "mod=f" parameter, and switch from w=test to q=test for the actual search parameter.

Thus, we need a bit of paper work, and a patch for the technical nits.
Whiteboard: needs-patch → needs-mic, needs-patch
Oh, and we still have centrum.cz in there, if you want to really remove that, we need a patch for that, too.
pavel, shall I contact these folks per Axel's comments 19 and 20 or will you?
- Centrum.cz removed
- Jyxo.cz and Wikipedia has fixed ShortName
- Mall.cz has new icon and url per comment #15
Attachment #310187 - Flags: approval1.9?
I don't understand comment 15.

> They will send their confirmation to Mic afterwards.

Should that confirmation be with Mic by now? Or is there some other thing after which they'd send confirmation to Mic?
PS: Mind changing the approval1.9 request on attachment 310187 [details] [diff] [review] into a review request on me?
Comment on attachment 310187 [details] [diff] [review]
Additional SE changes

Mall.cz (Michal Táborský <michal.taborsky@mall.cz>) asked me to do above changes. I have their confirmation+this request in email in Czech.
Attachment #310187 - Flags: approval1.9? → review?(l10n)
ok, thanks for update on permissions
what about mailto protocol handler for seznam - do we have permission and have they done their side to enable the protocol?
Comment on attachment 310187 [details] [diff] [review]
Additional SE changes

r=me, please check this in with a review comment referencing this bug and my review, something like "bug 401856, remove centrum, fix nits in other plugins, r=l10n@mozilla.com" would do.
Attachment #310187 - Flags: review?(l10n) → review+
pavel - ping about comment #26 on mailto for seznam
also never received anything from mall.cz - i will email mall.cz as well. pavel, I did recieve your summary email on march 10 with all other permissions, etc.
Summary: Approve changes in Czech Firefox 3 → Web service changes in Czech Firefox 3
Alias: fx3-wsl10n-cs
can i move the discussion for mailto and webcal out to another bug? so we can close this one for fx3?
cs doesn't have a single mail handler yet, we should at least land en-US' yahoo mail default, with a bump to defaultHandlersVersion.
agreed. pavel - can you handle landing that?
We're moving the yahoo mail handler addition off the 3.0 release blockers and into a separate bug 428475.

Reference is http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/a01c2c640cdd/reference/HEAD/cs/ for now.

Marking FIXED, really just for unblocking 3.0. Depending on timing, we might want to take patches for 428475 for 3.0, even.
Blocks: 428475
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: needs-mic, needs-patch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: