402117 - menu shortcuts are right aligned when opening menu first time

Status: RESOLVED WORKSFORME

(Toolkit :: UI Widgets, defect)

Description

[Elmar Ludwig]

When a menu is opened in a Firefox window for the first time, the keyboard shortcuts are displayed right aligned. After closing and reopening the menu they are left aligned (in a second column). I think the latter one is the intended behaviour.

Steps to reproduce:

1. Open new Firefox window
2. Open Edit menu, shortcuts are right aligned
3. Close and reopen Edit menu, shortcuts are now left aligned

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007110104 Minefield/3.0a9pre ID:2007110104

Comment 1

[Ria Klaassen (not reading all bugmail)]

Regression range is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2007-07-03+20%3A00&maxdate=2007-07-04+22%3A00
So it is caused by Bug 279703 I think.

Comment 2

[Neil Deakin]

This is because the boxobject width will be 0 during the popupshowing handler in popup.xml which sets the width of the accelltext label.

Comment 3

[[e-mail]]

Well, the quick hack is to use the popupshown event...

Comment 7

[Wayne Mery (:wsmwk)]

Thunderbird too of course

Comment 8

[Pardal Freudenthal (:ShareBird)]

I've noticed this doesn't happen on my theme because I use this rule:

menuitem > hbox{
-moz-box-pack:end;
}

Comment 9

[Bryan]

(In reply to comment #8)
> I've noticed this doesn't happen on my theme because I use this rule:
> 
> menuitem > hbox{
> -moz-box-pack:end;
> }

They should be left aligned, not right like the above css code does.

~B

Comment 10

[Pardal Freudenthal (:ShareBird)]

 (In reply to comment #9)
> 
> They should be left aligned, not right like the above css code does.
> 
> ~B
> 
Hmmm... Obviously I don't think so (and many other applications under Windows XP too). Anyway, this issue is not a matter of CSS as explained on comment #2. Sorry...

Comment 11

[Kai Liu]

(In reply to comment #10)
> > They should be left aligned
> Hmmm... Obviously I don't think so (and many other applications under Windows
> XP too).
> 
Huh?  Every native app that I've seen has left-aligned keyboard shortcuts... at least that is the case on the English version of Windows.  Does the German version do things differently?

Comment 12

[Pardal Freudenthal (:ShareBird)]

(In reply to comment #11)

> Huh?  Every native app that I've seen has left-aligned keyboard shortcuts... at
> least that is the case on the English version of Windows.  Does the German
> version do things differently?
> 

I've never investigated this issue under other languages, I don't really know if it has to do with German version, but I guess the whole Microsoft Office 2000 has right-aligned shortcuts(I have seen this on Outlook 2000, Word 2000 and Excel 2000). 

Comment 13

[Kai Liu]

(In reply to comment #12)
> I've never investigated this issue under other languages, I don't really know
> if it has to do with German version, but I guess the whole Microsoft Office
> 2000 has right-aligned shortcuts(I have seen this on Outlook 2000, Word 2000
> and Excel 2000). 
> 

Indeed.  Wow, I've never noticed that before!  Then again, Office doesn't use native widgets, and this isn't the only place where they deviate from native Windows behavior.

Comment 14

[Bryan]

(In reply to comment #12)
> 
> > Huh?  Every native app that I've seen has left-aligned keyboard shortcuts... at
> > least that is the case on the English version of Windows.  Does the German
> > version do things differently?
> > 
> 
> I've never investigated this issue under other languages, I don't really know
> if it has to do with German version, but I guess the whole Microsoft Office
> 2000 has right-aligned shortcuts(I have seen this on Outlook 2000, Word 2000
> and Excel 2000). 

Well we should be comparing FF to IE and in the case of IE, they are left-aligned as are every other native application that is included with Win2000, WinXP and I believe Vista.

Hopefully we can get this fixed soon!

~B

Comment 15

[Robert Strong (they/them - no direct email)]

Attachment: Vista screenshots w/ Shiretoko after opening the menu one time

Comment 16

[Bryan]

Classic theme on XP, IE 8 menu shortcuts are left-aligned.  Anyone know if this is polish-easy or polish-hard?

~B

Comment 17

[Bryan]

Any chance in getting this fixed or a way to force these to be left aligned in userChrome.css?  I've added 

menuitem > hbox{
-moz-box-pack:Start;
}

This still doesn't work properly as the menu items are right aligned upon starting FF until a second click of the menu, then they become left aligned.

~B

Comment 19

[Liviu Cirdei]

User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID 	20160415030231

Works as expected on latest Firefox release (45.0.2) and latest Nightly. The keyboard shortcuts are left aligned. Considering this, I will close the bug as Worksforme. If anyone can still reproduce the issue on a current Firefox build, fell free to reopen it.