403155 - Style new bookmark contextual dialog on Vista

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

The dialog created when clicking the star icon in the location bar needs to be styled for Vista.  I will follow up with a mockup.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Mockup of options (still in progress, but I really like the first one):

http://people.mozilla.com/~faaborg/files/granParadisoUI/contextulDialogStyleVista_i1.png

Comment 2

[AndrewM]

Looks good to me :)

One question though: Are you planning on having the same effect where it connects to the icon (the favicon in this case) like in State 2 of the Bookmark Contextual Dialog mockup: http://people.mozilla.com/~faaborg/files/granParadisoUI/places_NewBookmarkDialog_i9.png ?

I think that would look better than the sort-of arrow pointing at the favicon that you've got at the moment :)

Also, I think the 'More Information' button is an improvement over the current 'Tell me more about this web site...' link.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

yeah, I forgot to update the mockup.  OS X will use the arrow, and windows will have the overlaying square creating a tab like appearance.  I'll try to get new mockups up for XP and Vista.  In the meantime, just use the i9 bookmark context dialog as a reference.

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Here is the style spec: Here is the style spec: http://people.mozilla.com/~faaborg/files/granParadisoUI/contextualDialogSpec_i1.png

Comment 5

[Asaf Romano (gone)]

I'm not doing the styling work for windows at the moment.

Comment 6

[AndrewM]

I see that unlike bug 403157 (for XP) and bug 403158 (for OS X), this bug isn't targeted for Beta 4. Should it be?

Also, if Vista-specific styling doesn't make it into the final release, what will users on Vista see? The current implementation, or the XP version?

Comment 7

[Ryan A. C.]

-moz-appearance: tooltip will give you the intended gradient natively.
This one should be blocking-firefox3 the same as the others in Comment #6

Comment 8

[Lim Chee Aun]

Attachment: Vista identity popup with -moz-appearance: tooltip

From Comment #7, applying -moz-appearance: tooltip

#identity-popup{
-moz-appearance: tooltip !important;
}
#identity-popup-container{
background-color: transparent !important;
}

Comment 9

[Lim Chee Aun]

Attachment: Vista edit bookmark popup with -moz-appearance: tooltip

From Comment #7, applying -moz-appearance: tooltip

#editBookmarkPanel{
-moz-appearance: tooltip !important;
}

Comment 10

[Wesley Johnston (:wesj)]

Attachment: Tooltip on Vista Classic

I like this styling (at least I think its better than what we have, even if the tabs aren't implemented). What's the desired appearance on Classic? Screenshot shows what it looks like with the tooltip appearance applied.

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

>What's the desired appearance on Classic?

-moz-appearance: -moz-dialog

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

This will be fixed by the patch in bug 413060.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Alex, the bottom padding of the dialog is a bit to small when comparing it to the left padding. Is that by design? 

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #13)
> Alex, the bottom padding of the dialog is a bit to small when comparing it to
> the left padding. Is that by design? 

Alex, as you told me on IRC you wanted to file a new bug for that issue. Have you done this meanwhile?

Comment 15

[(no longer active)]

(In reply to comment #14)
> (In reply to comment #13)
> > Alex, the bottom padding of the dialog is a bit to small when comparing it to
> > the left padding. Is that by design? 
> 
> Alex, as you told me on IRC you wanted to file a new bug for that issue. Have
> you done this meanwhile?

That's bug 432529.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #15)
> > Alex, as you told me on IRC you wanted to file a new bug for that issue. Have
> > you done this meanwhile?
> 
> That's bug 432529.

Ehsan, your mentioned bug is about the identity dialog but doesn't handle the bookmark contextual dialog.

Comment 17

[(no longer active)]

Oops, you're right!  Please disregard my comment.  (Wishing Bugzilla would let me delete comments now...)

Comment 18

[Alex Faaborg [:faaborg] (Firefox UX)]

>Alex, as you told me on IRC you wanted to file a new bug for that issue. Have
>you done this meanwhile?

just got around to it now, bug 436402

Comment 19

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv