40343 - Filter UI: remove Local Folders and News from account selection dropdown

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P1)

Description

[laurel]

Using may23 m16 commercial build

We should remove the following items from the "Filters For" account selection
dropdown in the Message Filters:

Local Folders:  remove this unless we implement "Manual Filtering" a.k.a. "After
the Fact Filtering" for any folder selection (reference bug #11033 and Message
Filters spec, listing manual filtering as P3 -- note the spec has this feature
broken into two items, one for manually filtering only the default inbox and the
other for manually filtering any folder selection).   Even for POP accounts,
seamonkey has an inbox within the account hierarchy, Local Folders would not be
a valid incoming mailbox.

News accounts:  remove this item based on M20 target (reference bug #17483) for
the backend implementation of news filters. 


I'm logging this as a tracking bug, I know final decisions are not really FINAL
yet.

Comment 1

[Alec Flett]

ah, I need to make the picker only show servers that can accept messages.
I know there's an RDF property for that.
Adding seth, but I'm sure I can find it myself

Comment 2

[(not reading, please use [e-mail] instead)]

nc:CanFileMessages

see mailWindowOverlay.xul

we use it for move / file menu picker in the 3 pane.

Comment 3

[scottputterman]

adding keyword b3mail

Comment 4

[selmer (gone)]

Adding nsbeta3 to b3mail bugs.

Comment 5

[selmer (gone)]

Removing b3mail keyword (these bugs have been promoted now.)

Comment 6

[laurel]

QA note when verifying: Local Folders and News (both account and folder levels)
are valid for search ui, verify the fix for this does not affect search ui.

Comment 7

[lchiang]

- per mail triage

Comment 8

[David :Bienvenu]

whoa, this is bad to allow the user to specify filters that won't work! I'll 
take this bug, and clear the nsbeta3-.

Comment 9

[laurel]

Finally... YAY! Thank you, David!

Comment 10

[selmer (gone)]

Plussing on the assumption your fix is to remove the bogus stuff from the UI.

Comment 11

[David :Bienvenu]

ok, now I'm confused. Is there some other way of fixing this? The bug is to
remove them from the selection dropdown. We also need to remove newsgroups from
the filter targets.

Comment 12

[Alec Flett]

it's not as easy as it sounds.. I have to reflect the fact that a server can
handle filters into RDF, and then filter out the servers that can't hold
filters.

I'll see what I can do.

bienvenu: as for removing invalid filter targets, I have that fix in my tree,
since we already have reflected what folders can and cant accept messages.

Comment 13

[David :Bienvenu]

OK, I'm going to reassign this back to Alec since this would be a lot easier for
him. I'll see if he has other bugs that I can work on.

Comment 14

[Alec Flett]

I've started working on this in my tree, I'll post a patch soon

Comment 15

[Alec Flett]

marking in progress so others don't waste time on this

Comment 16

[Srilatha Moturi]

Attachment: List of dialogs

Comment 17

[Srilatha Moturi]

oops created the attachment for the wrong bug. Please ignore the attachment.

Comment 18

[Alec Flett]

Attachment: make datasource support the "SupportsFilters" RDF property

Comment 19

[Alec Flett]

ok, that's the first part of the patch, which also fixes the leak described in 
bug 44626..

adding [e-mail] for a review
(XUL patch coming up)

Comment 20

[Alec Flett]

Attachment: make news and Local Folders return errors trying to get the filter list

Comment 21

[Alec Flett]

Attachment: make the filter UI only show servers w/filters

Comment 22

[Alec Flett]

ok, all I need is a review on these three files, and I'm ready to go

Comment 23

[scottputterman]

r=scottip

Comment 24

[Alec Flett]

fix is in, thanks scott

Comment 25

[David :Bienvenu]

Thanks *alot* for fixing this, Alec!

Comment 26

[laurel]

In august 28 build:
 -  Good: the filter scope "filters for" selection dropdown doesn't offer
invalid servers
 -  Bad:  the MoveToFolder action still shows invalid choices.  This is
mentioned as part of this bug 40343 as Selmer and David mentioned in each of
their comments of aug17.  Originally that specific area was covered in bug 40357
and bug 40358, both still stand futured.  

I'm assuming we still mean this bug to cover the bogus invalid selections for
the MoveToFolder, too?  Or are we going to un-future 40357-58?

Reopening for target selection dropdown, comments please.

Comment 27

[Alec Flett]

the other two bugs cover target selection just fine. We may want to consider 
un-futuring them/renominating them... this bug, as it original stands (and as my 
patches were for) is just for the Filters for: combo box, which should now be 
fixed

Wouldn't you know it, I have fixes for the other two bugs in my tree, I don't 
know how long they've been there for! I'll attach to bug 40357, re-nominate, and 
get a review.

Comment 28

[laurel]

OK using aug30 commercial build, linux rh6.0, NT 4.0 and Mac OS 9.0

Problem with invalid selections in filter actions will be addressed separately,
bug 40357.

Comment 29

[scottputterman]

Removing the mail1 keyword.