403952 - fix 3.0b1 rc3 mar files

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

The 3.0b1 rc3 win32 mar files all appear to have a '..work' directory on them. This directory is supposed to be '../work', and therefore not in the mar. Rhelmer has speculated that it may be a weird path issue in the mozilla/release/testing scripts that has issues with msys.

We should repack these mars without those directories, no need to do an rc4 over this.

Comment 1

[Robert Helmer [:rhelmer]]

This "..work" directory only appear in the signed MARs, not the unsigned MARs. It looks like this is a bug in the signing process.

Comment 2

[Robert Helmer [:rhelmer]]

http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/3.0b1-candidates/rc3/win32_signing_rc3.log
excerpt:
processing ..work/temp-filelist
bzip2: Can't open input file ./..work/temp-filelist: No such file or directory.

Comment 3

[[e-mail] (:bhearsum)]

OK. I've repacked the mars on staging-trunk-automation. In /tmp/3.0b1-rc3-repack/. The script I've used is there, as well as attached (in a sec).

Comment 4

[Robert Helmer [:rhelmer]]

This was a problem for 3.0b1 rc1 as well. This is not a problem with 2.0.0.10-candidates/rc1 which is using the same signing and update-packaging tools and versions.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: repack script

Comment 6

[[e-mail] (:bhearsum)]

Unassigning myself. Rob/Nick, take it away.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Thanks for getting this started Ben.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Updated repack script

Extends the previous script to
* use the same permissions as original mar (666 for files, 777 for executable files)
* trim the ./ from the start of the filenames
* remove the ..work/temp-filelist line from update.manifest, with before vs after diff
* rearrange slightly 
* handle the files a little differently (input and output dirs)
* add some verbosity

This was run on build-console.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 289309 [details]
Updated repack script

There's a bug here (leaving behind update.manifest.new), and another glitch (bug 404340). Since we don't need these mar files until generating updates for b2, I'm going to punt on fixing them until after b1 is safely out the door.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: v3 repack script

Fixes
* problem with update.manifest.new
* substitutes freebl3.exe and softokn3.dll from the installer

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: repack.log

Output from the v3 script, when run in build-console:/builds/cf/3.0b1-rc3-repack-cf/.

I did a couple of spot checks that the complete update applied, going from a8 en-US to b1 en-US and b1 de. In the first case, the recursive diff between updated a8 and unpacked b1 installer was:
Only in a8/a8-b1-repacked-cf_en-US-2/: .autoreg
Only in a8/a8-b1-repacked-cf_en-US-2/: active-update.xml
Only in a8/a8-b1-repacked-cf_en-US-2/: removed-files
Only in a8/a8-b1-repacked-cf_en-US-2/res/html: gopher-audio.gif
Only in a8/a8-b1-repacked-cf_en-US-2/res/html: gopher-binary.gif
Only in a8/a8-b1-repacked-cf_en-US-2/res/html: gopher-find.gif
Only in a8/a8-b1-repacked-cf_en-US-2/res/html: gopher-image.gif
Only in a8/a8-b1-repacked-cf_en-US-2/res/html: gopher-menu.gif
Only in a8/a8-b1-repacked-cf_en-US-2/res/html: gopher-movie.gif
Only in a8/a8-b1-repacked-cf_en-US-2/res/html: gopher-sound.gif
Only in a8/a8-b1-repacked-cf_en-US-2/res/html: gopher-telnet.gif
Only in a8/a8-b1-repacked-cf_en-US-2/res/html: gopher-text.gif
Only in a8/a8-b1-repacked-cf_en-US-2/res/html: gopher-unknown.gif
Only in a8/a8-b1-repacked-cf_en-US-2/uninstall: uninstall.update
Only in a8/a8-b1-repacked-cf_en-US-2/: updates
Only in a8/a8-b1-repacked-cf_en-US-2/: updates.xml

That looks normal for an in-app update; the gopher files is bug 404327, and will be fixed by updating removed-files.in in time for b2.

I've uploaded the repacked mars to 
  firefox/nightly/3.0b1-candidates/rc3/
and will now stage them and push out to the mirrors in 
  firefox/releases/3.0b1/update

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Complete.