404647 - CTRL+F shortcut should focus the search box in the download manager

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect, P2)

Description

[Marco Bonardo [:mak]]

Add CTRL+F to the download manager to focus the search box.

spin-off from Bug 404524 on Beltzner request

Comment 1

[u278084]

Attachment: seems easy

Looked easy and I had a few minutes. Hopefully it was done right.

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 289599 [details] [diff] [review]
seems easy

I know this seems odd that I'm requesting review from myself, but it's really just to get it on my radar ;)

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 289599 [details] [diff] [review]
seems easy

>+function setSearchboxFocus() {
>+  document.getElementById('searchbox').focus();
>+}
>+
nit: newline for opening brace please
nit: use " instead of ' with getElementById

>+    <key id="key_find"    key="&cmd.find.commandKey;"   oncommand="setSearchboxFocus()" modifiers="accel"/>
I know the formatting of this part of the file is sucky...
Can you not do the extra spacing to line up the keys and make sure that the line wrapping is at 80 chars for this new one please?

r=sdwilsh with these fixed.

Comment 4

[u278084]

Attachment: same patch revised

My haste has made me careless. Fixed the patch

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 289765 [details] [diff] [review]
same patch revised

Drivers - this is low risk.

Comment 6

[Reed Loden [:reed]]

Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd,v  <--  downloads.dtd
new revision: 1.17; previous revision: 1.16
done
Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.104; previous revision: 1.103
done
Checking in toolkit/mozapps/downloads/content/downloads.xul;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.xul,v  <--  downloads.xul
new revision: 1.34; previous revision: 1.33
done

Comment 7

[Gabriel Chadwick]

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 6.0; fr; rv:1.9b2pre) Gecko/2007112605 Minefield/3.0b2pre ID:2007112605

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; although this is indeed fixed on both trunk Windows and Linux builds, it's broken on Mac OS X (10.4), where all it does is generate the "thud" sound, meaning it can't set focus.

https://litmus.mozilla.org/show_test.cgi?id=5002

in-litmus+

Comment 9

[Jesse Ruderman]

I wonder why this (Cmd+F) doesn't work on Mac.  The patch correctly uses "accel" for Ctrl on Windows and Cmd on Mac.

I noticed that the "Find" command in the Edit menu is disabled.  Maybe another Find command, associated with that menu, is getting in the way.  (And it would be good for that menu item to be enabled when the Download Manager has focus.)

Comment 10

[Jesse Ruderman]

"Not working on Mac" split off into bug 405696.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified with Windows and Linux trunk builds, since we split-off Mac in comment 10.