404884 - Add "Show all History" command to the history menu

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Mirroring the "Show all Bookmarks" command being created in the bookmarks menu (bug# 404084), the history menu needs a "Show all History" menu item.  It should appear at the end of the menu, below "Show in Sidebar."

This menu item should open the Library window (formerly places organizer), navigated to the history item in the left pane.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Agreed. Patch coming.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Hm, actually, patch not coming - do we have a command that I can have the menuItem call which will open the Places Organizer with focus on "All History"? :)

Comment 3

[Asaf Romano (gone)]

No. ;)

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

mconnor points out that it should probably replace the "Show History in Sidebar" entry, which I'd support, as that's duplicated in View > Sidebar.

Comment 5

[Asaf Romano (gone)]

Attachment: patch

Comment 6

[Dietrich Ayala (:dietrich)]

Comment on attachment 290039 [details] [diff] [review]
patch

nit: the commands are ShowBookmarks/ShowHistory, but the labels etc are ShowAll*. Can you make them consistent one way or the other?

>+
>+  selectLeftPaneQuery: function PO_selectLeftPaneQuery(aQueryName) {
>+    var itemId = PlacesUtils.leftPaneQueries[aQueryName];
>+    this._places.selectItems([itemId]);
>+    // Forcefully exapnd all-bookmarks

nit: s/exapnd/expand/

r=me otherwise.

Comment 7

[Asaf Romano (gone)]

Attachment: as checked in

mozilla/browser/base/content/browser-menubar.inc 1.120
mozilla/browser/base/content/browser-places.js 1.67
mozilla/browser/base/content/browser-sets.inc 1.106
mozilla/browser/components/places/content/places.js 1.115
mozilla/browser/components/places/content/utils.js 1.79
mozilla/browser/locales/en-US/chrome/browser/browser.dtd 1.79

Comment 8

[pal-moz]

no accesskey ?

Comment 9

[Asaf Romano (gone)]

no, see bug 308812.

Comment 10

[David Tenser [:djst]]

Verified on both Mac OS and Windows Vista.

I would argue that "Show All Bookmarks..." would be better placed at the bottom of the Bookmarks menu, but I doubt this is the right place for it. :)

Comment 11

[[:Aleksej]]

Also verified with Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2pre) Gecko/2007112704 Minefield/3.0b2pre.
The properties panel at the bottom of Places Organizer doesn’t work properly for those history items, though.

Comment 12

[pal-moz]

(In reply to comment #8)
> no accesskey ?
> 

(In reply to comment #9)
> no, see bug 308812.
> 

mistake.
not accesskey but shortcutkey ?

"Show All Bookmarks..." is ctrl+shift+B
("Show in Sidebar" is/was ctrl+H)
"Show All History..." is ?

Comment 13

[David Tenser [:djst]]

"Show in Sidebar" (actually View > Sidebar History) is still using Ctrl+H (Shift+Cmd+H on the Mac).

Comment 14

[Alex Faaborg [:faaborg] (Firefox UX)]

>I would argue that "Show All Bookmarks..." would be better placed at the bottom
>of the Bookmarks menu

This would hide the menuitem when the user has enough bookmarks to create a scroll widget at the bottom of the menu.  If we want to go for consistency, it would be better to move show all history to the start of the history menu.

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv