405276 - History sidebar should show stars and tags

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, enhancement)

Description

[Jared Stafford]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b1) Gecko/2007110903 Firefox/3.0b1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b1) Gecko/2007110903 Firefox/3.0b1

The history sidebar currently does not indicate starred pages. I think this would be helpful, since starring too many pages without actually adding them as bookmarks causes older ones to be bumped off the places menu. Also, maybe the history could have a view option to only view starred items.

Reproducible: Always

Comment 1

[Ria Klaassen (not reading all bugmail)]

Confirming as a new feature request. Seems a desirable feature. I did a search but couldn't find an obvious dupe.

Comment 2

[Marco Bonardo [:mak]]

Attachment: add star to the history panel

this is an attempt to implement that, it is working fine, but i'm not sure it is the right place to set the image (maybe a css should be used?) and if 40px fixed width is fine for the column. 
I'm waiting for input before asking review...

Comment 3

[Marco Bonardo [:mak]]

Attachment: Show star in the history sidebar

Comment 4

[Marco Bonardo [:mak]]

in Bug 405549 Beltzner said "The history sidebar should show stars and tags like the locationbar drop down does, but the bookmarks sidebar should just show tags."
updating title to indicate it should also show tags

Comment 5

[Marco Bonardo [:mak]]

note: implementing a star column could be unified with bug 387747

questions:
1. column type should be called COLUMN_TYPE_BOOKMARKED or COLUMN_TYPE_STARRED?
2. should the star be clickable or only an indicator?
3. should unstarred items show empty stars or nothing (connected to 2.)
4. there is a better way of getting the chrome star icon than hardcoding its url?
5. should star column come before or after title? if it comes before will be strange when grouped since there will be 2 icons after the group glyph and then the title

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Marco, is there any ongoing work on this bug?

Comment 7

[Marco Bonardo [:mak]]

Alex has marked as a WONTFIX the library starring ui so i doubt if also this is somehow a WONTFIX. needs ui def

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

(In reply to comment #7)
> Alex has marked as a WONTFIX the library starring ui so i doubt if also this is
> somehow a WONTFIX. needs ui def

Alex, any related comments from your side?

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

Personally I think instead of spending too many cycles on the history sidebar we should get started on completely redesigning our history UI.  The sidebar is a pretty ineffective way to find something out of your history.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Alex, a complete rewrite would take its time. We already have a patch on hand on this bug? Shouldn't we try to get this in? I believe that would be a nice improvement to see already bookmarked pages.

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

Can you attach a screen shot so I can get a sense of how the UI changes with this patch?

Comment 12

[Marco Bonardo [:mak]]

unassigning, sidebar needs a redesign, no reason to take temporary hacks

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 14

[Marco Bonardo [:mak]]

considered the sidebar is "old-style" technology that we are evaluating to remove, this is not worth the time.

Comment 15

[[:Aleksej]]

Now when screens are wide, is it not a time to *start* using sidebars?