407098 - Running "firefox [url]" while in Print Preview creates new tabs & can trigger crash

Status: RESOLVED WORKSFORME

(Toolkit :: Printing, defect)

Description

[rforums]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b1) Gecko/2007110904 Firefox/3.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b1) Gecko/2007110904 Firefox/3.0b1

i had two sites opened in different tabs. i put print preview option for the second tab. then i opened a saved web page on my hard disk. then i started closing the tabs in the order i opened them. after closing the saved page tab and the print preview tab firefox crashed.

Reproducible: Always

Steps to Reproduce:
1.open firefox and goto page www.yahoo.com
2.open a new tab and goto page www.google.com
3.goto File>Print preview option for the second tab
4.Now open a saved html page in your hard disk which opens in a third tab
5.now close the third tab, then the second tab which is in the print preview mode.
Actual Results:  
firefox crashes. tried it 3 times. 2 times, firefox crash reporter came. the third time the windows xp error reporting pop up came up.

Expected Results:  
firefox should have not crashed and the first tab should have come to focus.

in my firefox i have disabled the option to show the tab bar if one tab is present.

Comment 1

[Mats Palmgren (inactive)]

> i put print preview option for the second tab.

This is odd. The default Print Preview replaces replaces the entire
window with the PP view, there's no way to open new tabs when in
PP mode.  Have you installed any add-ons to get this feature?

Comment 2

[rforums]

>  Have you installed any add-ons to get this feature?
no add-ons for that feature. when PP view is activated, yes, entire window is replaced. after this i just open a saved html page. the tabbar comes into view and shows the saved page. i then close the saved page tab, then the second one which is the print preview tab, then firefox crashes. this happens only when there is atleast 1 tab remaining after closing the print preview one.

Comment 3

[rforums]

After the crash, i went to windows event viewer. in the application window, one error and one information entry was there.
The error entry said:
Faulting application firefox.exe, version 0.0.0.0, faulting module xul.dll, version 0.0.0.0, fault address 0x00259ccd.

The information entry said(source was Dr. Watson):
The application, C:\Program Files\Mozilla Firefox 3 Beta 1\firefox.exe, generated an application error The error occurred on 12/09/2007 @ 23:16:19.796 The exception generated was c0000005 at address 60609CCD (xul!JSD_IsLocked)

Comment 4

[Mats Palmgren (inactive)]

Ok, I'm stupid, I didn't get point 4 at first.  To clarify step 4 above:
 4a. open a Windows file explorer window
 4b. double-click a HTML file in some folder

This opens the file in a new tab in the Firefox window, and reveals the
tab bar under print preview bar.  This shouldn't happen.  I think we're
supposed to pick an existing window that isn't in print preview mode,
or if none is available, open a new window.

The bug also occurs in Firefox 2.0.0.11

Comment 5

[Mats Palmgren (inactive)]

What's the ID of your crash report?  (you can find it in the Crash Reports
folder -- see http://kb.mozillazine.org/Breakpad)

Comment 6

[rforums]

Crash ID: bp-b204d342-a6d9-11dc-afc5-001a4bd43e5c

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Pretty odd use case, wanted-not-blocking.

Comment 10

[Daniel Holbert [:dholbert]]

Updating title to reflect the real bug here, as reflected in comment 4.

Comment 11

[Daniel Holbert [:dholbert]]

(In reply to comment #7)
> Pretty odd use case, wanted-not-blocking.

IMHO, this actually isn't that odd of a use-case.  The issue isn't the crash, it's that we allow new tabs to be opened in the foreground during print-preview.

I'm posting the steps-to-reproduce from duplicate-bug 458902, because they're much simpler than the steps given in this bug here.

(Quoting bug 458902 comment #0)
> Steps to reproduce:
>  1. Open exactly one session of Firefox, with exactly one window open.
>  2. Load about:blank (or any URL) and Print-Preview it.
>  3. Make Firefox open up a new tab, by...
>     a) running "firefox google.com" in the command line
>       or...
>     b) clicking on a link in another program
and I'd add another alternate option under step 3:
      c) double-clicking a HTML file in your OS's file-explorer

Comment 12

[Daniel Holbert [:dholbert]]

(In reply to comment #11)
> (In reply to comment #7)
> > Pretty odd use case, wanted-not-blocking.
> IMHO, this actually isn't that odd of a use-case.

I meant to add that I've been running into this bug pretty much daily -- I'll be debugging an issue in print-preview, and then I absentmindedly click a link in Thunderbird, and then my Firefox session is broken.

Comment 13

[Michael Ryan]

See also bug 409181, which is just about not being able to close print preview. Just fixing that issue should be a bit simpler than fixing the whole "allowing new tabs to open in a print preview window" issue.

Comment 16

[Martijn Wargers (dead)]

Attachment: patch

This seems to fix it.

Comment 17

[Dão Gottwald [:dao]]

I think the correct fix is to make sure "win" isn't in print preview mode in the OPEN_NEWTAB case, similar to how we bypass popup windows.

Comment 18

[Martijn Wargers (dead)]

I tried that, that didn't work.

Comment 19

[Daniel Veditz [:dveditz]]

Let's drive this in!

Comment 20

[:Gavin Sharp [email: [e-mail]]]

Attachment: alternate patch

This isn't tested, but if it works I think this is a better fix.

Comment 21

[Daniel Veditz [:dveditz]]

Gavin: ping -- where are we with this one?

Comment 22

[Wayne Mery (:wsmwk)]

(In reply to comment #21)
> Gavin: ping -- where are we with this one?

Martijn, does patch work for you?