Closed Bug 407635 Opened 12 years ago Closed 12 years ago

Update browser/toolkit copyright dates to 2008

Categories

(Firefox :: General, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 3 beta3

People

(Reporter: philor, Assigned: philor)

Details

(Keywords: verified1.8.1.12)

Attachments

(3 files)

Attached patch Trunk v.1Splinter Review
+++ This bug was initially created as a clone of Bug #365553 +++

It's the most wonderful time of the year, with the kids jingle-belling, and everyone telling you "Maybe this will be the year that you can actually get branch locale copyright dates changed, but certainly we'll at least ship Fx3 with the right dates."
Flags: blocking-firefox3?
Attachment #292352 - Flags: review?(gavin.sharp)
Attached patch Branch v.1Splinter Review
Rather than thrash the dates in the help content, which we very much expect not to change during 2008 on the branch, I'd like to just leave them alone this year, in hopes that the tiny impact on locales will make whoever's actually responsible for making the decision (someone who didn't show their head in bug 365553, or really in bug 322172) think it would be a good idea to have locales change their aboutDialog.dtds, since we'll be shipping off 1.8 for more than half of 2008.
Attachment #292354 - Flags: review?(gavin.sharp)
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P3
Is this change really so important that the no-l10n-changes-on-branch policy should be broken? Gerv said in bug 322172 comment#17 that the copyright won't expire in our lifetime anyway.
Flags: blocking-firefox3+ → blocking-firefox3?
Priority: P3 → --
Oops, it seems I somehow accidentally removed the blocking-firefox3 flag. Please, can someone with the right privileges restore it?  
Priority: -- → P3
Flags: blocking-firefox3? → blocking-firefox3+
Attachment #292352 - Flags: review?(gavin.sharp) → review+
Attachment #292354 - Flags: review?(gavin.sharp) → review+
Attachment #292354 - Flags: approval1.8.1.12?
Forgot my bug 369060 comment 4 promise to spam build with this year's set.

"so important" as in, does it have any legal meaning? I certainly hope not - I didn't check shipping vs. not beyond at least some of the 2005's being shipping locales, but on 1.8 we currently have 43 "2006", 11 "2005", 3 "2007" and 1 "2004" (plus one I can't read).

Assuming I'm correct that we would be claiming in any copyright dispute that we first published in the US, even for localizations, then a copyright notice should only be required when we are claiming Universal Copyright Convention coverage somewhere that we don't have Berne Convention coverage, which I think is Andorra, Laos, Saudi Arabia, Turkmenistan and Uzbekistan.

I just apparently misunderstood things like bug 365553 comment 14 and various things from bug 322172 comment 23 onward, and the other bugs in several locales' own components, as meaning that localizers actually wanted the opportunity to have their locales not look old and outdated. Between you and Axel, I get the impression I was very wrong about that, so I won't be doing anything other than trying to land the en-US changes as we've always done in the past. 
Comment on attachment 292354 [details] [diff] [review]
Branch v.1

approved for 1.8.1.12, a=dveditz for release-drivers
Attachment #292354 - Flags: approval1.8.1.12? → approval1.8.1.12+
browser/app/macbuild/Contents/Info.plist.in 1.17
browser/app/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in 1.4
browser/app/application.ini 1.11
browser/base/content/credits.xhtml 1.30
browser/locales/en-US/chrome/browser/aboutDialog.dtd 1.10
browser/locales/en-US/chrome/help/platformStrings.dtd 1.11
toolkit/locales/en-US/chrome/global/about.dtd 1.5
toolkit/content/license.html 1.16
toolkit/locales/en-US/chrome/mozapps/help/welcome.xhtml 1.7
toolkit/mozapps/update/src/updater/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in 1.3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
browser/app/macbuild/Contents/Info.plist.in 1.11.4.4
browser/app/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in 1.1.2.3
browser/app/nsBrowserApp.cpp 1.31.2.5
browser/base/content/credits.xhtml 1.10.4.17
browser/locales/en-US/chrome/browser/aboutDialog.dtd 1.5.8.3
toolkit/locales/en-US/chrome/global/license.dtd 1.2.18.7
toolkit/content/license.html 1.1.2.11
toolkit/mozapps/update/src/updater/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in 1.1.2.3
Keywords: fixed1.8.1.12
verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008010204 Minefield/3.0b3pre.
Status: RESOLVED → VERIFIED
You missed toolkit/crashreporter/client/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in ;)
Attached patch FollowupSplinter Review
Attachment #295584 - Flags: review?(gavin.sharp)
Attachment #295584 - Flags: review?(gavin.sharp) → review+
toolkit/crashreporter/client/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in 1.4

Thanks for the eyeball :)
Verified for 1.8 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.12) Gecko/2008012822 Firefox/2.0.0.12.
You need to log in before you can comment on or make changes to this bug.