Closed
Bug 407937
Opened 17 years ago
Closed 17 years ago
Popup with left/top attributes can expand outside of content area
Categories
(Core :: XUL, defect, P3)
Tracking
()
RESOLVED
FIXED
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(2 files)
|
597 bytes,
application/vnd.mozilla.xul+xml
|
Details | |
|
7.98 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Popups in content shells should be constrained to the content area. There are two issues:
1. the left/top attributes set the screen position, while the anchor is also set. The check at http://lxr.mozilla.org/mozilla/source/layout/xul/base/src/nsMenuPopupFrame.cpp#1009 asserts and runs the wrong code path.
2. ensure that the y position is checked to ensure it is above the bottom of the screen.
This is a trunk only issue.
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #292627 -
Flags: superreview?(roc)
Attachment #292627 -
Flags: review?(roc)
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → ASSIGNED
Flags: blocking1.9?
Attachment #292627 -
Flags: superreview?(roc)
Attachment #292627 -
Flags: superreview+
Attachment #292627 -
Flags: review?(roc)
Attachment #292627 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 3•17 years ago
|
||
one of the tests here is disabled because it failed on linux and windows
|
||
Comment 4•17 years ago
|
||
The landing of this patch appears to have caused Bug 409427 – Status Bar Add-on Icon Tooltips Only Flash Up On Mouse Pointer Hover
|
|
Assignee | |
Updated•17 years ago
|
Flags: in-testsuite+
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
|
|
Assignee | |
Comment 5•16 years ago
|
||
Fixed the test as part of bug 487631.
You need to log in
before you can comment on or make changes to this bug.
Description
•