Closed Bug 407937 Opened 15 years ago Closed 15 years ago

Popup with left/top attributes can expand outside of content area

Categories

(Core :: XUL, defect, P3)

x86
macOS
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(2 files)

Attached file testcase
Popups in content shells should be constrained to the content area. There are two issues:

1. the left/top attributes set the screen position, while the anchor is also set. The check at http://lxr.mozilla.org/mozilla/source/layout/xul/base/src/nsMenuPopupFrame.cpp#1009 asserts and runs the wrong code path.
2. ensure that the y position is checked to ensure it is above the bottom of the screen.

This is a trunk only issue.
Attached patch patch with testSplinter Review
Attachment #292627 - Flags: superreview?(roc)
Attachment #292627 - Flags: review?(roc)
Status: NEW → ASSIGNED
Flags: blocking1.9?
Yea - we want this...
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
Attachment #292627 - Flags: superreview?(roc)
Attachment #292627 - Flags: superreview+
Attachment #292627 - Flags: review?(roc)
Attachment #292627 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
one of the tests here is disabled because it failed on linux and windows
Depends on: 409242
The landing of this patch appears to have caused Bug 409427 – Status Bar Add-on Icon Tooltips Only Flash Up On Mouse Pointer Hover
Flags: in-testsuite+
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
Fixed the test as part of bug 487631.
You need to log in before you can comment on or make changes to this bug.