409242 - Fix test from bug 407937

Status: RESOLVED DUPLICATE of bug 487631

(Toolkit :: UI Widgets, defect)

Description

[Neil Deakin]

Attachment: fixes issues

This fixes a number of issues with the hastily written test for bug 407937

- rounds the position numbers
- uses the if/else blocks properly
- remove a couple of menuitems so that the menu fits into the little test iframe
- when appending menuitems, append a lot more to ensure that it is larger than the screen for large monitors
- also fixes test_popup_scaled.xul to reset the scale after the test so as not to affect later tests

Comment 1

[Asaf Romano (gone)]

Comment on attachment 294067 [details] [diff] [review]
fixes issues

r=mano

Comment 2

[Neil Deakin]

Comment on attachment 294067 [details] [diff] [review]
fixes issues

Test only changes

Comment 3

[Reed Loden [:reed]]

Comment on attachment 294067 [details] [diff] [review]
fixes issues

Approval isn't require for tests.

Comment 4

[Reed Loden [:reed]]

s/require/required/

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I suspect this caused win2k03 to turn orange with failures in these tests, so I backed it out. (It turned red immediately after this was checked in due to box sickness, and the failures showed up several hours later when the box was kicked.)

*** 45373 ERROR FAIL | mouse click on trigger after_start position |  | /tests/toolkit/content/tests/widgets/test_popup_button.xul
*** 45425 ERROR FAIL | open popup anchored after_start position |  | /tests/toolkit/content/tests/widgets/test_popup_button.xul
*** 45432 ERROR FAIL | open popup anchored after_end position |  | /tests/toolkit/content/tests/widgets/test_popup_button.xul
*** 45488 ERROR FAIL | open popup anchored with attribute after_start position |  | /tests/toolkit/content/tests/widgets/test_popup_button.xul
*** 45495 ERROR FAIL | open popup anchored with attribute after_end position |  | /tests/toolkit/content/tests/widgets/test_popup_button.xul
*** 45658 ERROR FAIL | open popup with open property after_start position |  | /tests/toolkit/content/tests/widgets/test_popup_button.xul
*** 45762 ERROR FAIL | large menu top |  | /tests/toolkit/content/tests/widgets/test_popupincontent.xul
*** 45763 ERROR FAIL | large menu bottom |  | /tests/toolkit/content/tests/widgets/test_popupincontent.xul
*** 45768 ERROR FAIL | shorter menu again height shortened | got 0, expected 74 | /tests/toolkit/content/tests/widgets/test_popupincontent.xul

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

winxp01 has been showing failures in these tests too, intermittently all day:

*** 45762 ERROR FAIL | large menu top |  | /tests/toolkit/content/tests/widgets/test_popupincontent.xul
*** 45763 ERROR FAIL | large menu bottom |  | /tests/toolkit/content/tests/widgets/test_popupincontent.xul
*** 45768 ERROR FAIL | shorter menu again height shortened | got -1, expected 74 | /tests/toolkit/content/tests/widgets/test_popupincontent.xul

Comment 7

[Andrew Schultz]

> - also fixes test_popup_scaled.xul to reset the scale after the test so as not
> to affect later tests

I just retracked this down... it's causing at least one test failure for me.  Can at least this part re-land?

Comment 8

[Neil Deakin]

I fixed this as part of bug 487631.