408389 - Live Titles don't have selection

Status: VERIFIED FIXED

(Firefox Graveyard :: Microsummaries, defect, P3)

Description

[Tracy Walker [:tracy]]

Seen on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2007121404 Minefield/3.0b3pre

STR:

   1. Open http://people.mozilla.com/~myk/microsummaries/tests/microsummary-updates.html
   2. Select "Bookmarks Toolbar" from the Folder menu.
   3. Go to Bookmarks | Bookmark This Page to open the Bookmarking popup.
   4. Select the numeric live title from the Name editable menu.

Expected Results:
In this case, a large number should be available in the Live Titles menu

Tested Results:
Nothing is available below Live Titles.

note: this works in b2. so it must have regressed since b2 freeze date.

this is part of litmus test case: https://litmus.mozilla.org/show_test.cgi?id=4229

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Looking at this.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

This is a regression from the fix for bug 401509, which accidentally removed a necessary line from the code that builds the microsummary picker.  The fix is just to add back in the line.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 295747 [details] [diff] [review]
patch v1: fixes problem

r=mano

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Checking in browser/components/places/content/editBookmarkOverlay.js;
/cvsroot/mozilla/browser/components/places/content/editBookmarkOverlay.js,v  <--  editBookmarkOverlay.js
new revision: 1.16; previous revision: 1.15
done

Comment 5

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020418 Firefox/3.0b3.   Test URL now shows "50140611083360" under Live Titles and can be selected as the bookmark title.