408906 - Do major update for TB150fourteen -> 2.0.0.14

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[J. Paul Reed [:preed]]

This is like bug 385137, only refreshing the Thunderbird major update path, so it updates 1.5.0.14 (end of life) clients to the (supported) 2.0 path.

I believe it's the last major update we have to do for Thunderbird (since 1.5.0.14 is the last release of the 1.5-line).

Filing since TB 1.5.0.14 is about to ship, and to keep track of this (which is on http://wiki.mozilla.org/Releases, but doesn't have a release date set yet), and to track the website tweaking dependency.

Comment 1

[J. Paul Reed [:preed]]

Cc'ing the Usual Suspects. :-)

Also, since it looks like all the configs are in public CVS (yay), as well as the tools, I can help out generating and testing these snippets.

I'd need someone on the MoCo side with access to aus2.m.o to post the snippets, though. Should take about a half hour of coordination for that.

Comment 2

[J. Paul Reed [:preed]]

D'oh! Sorry for the bugspam; I thought ":ss" was Mr. Sidler, not Mr. Spitzer. Fixed. :-)

Comment 3

[J. Paul Reed [:preed]]

Since no one is working on this, I'll take it; patch on its way.

Comment 4

[J. Paul Reed [:preed]]

Attachment: major update config changes, v1

Pretty simple; I got the 2009 build IDs from moz18-branch-patcher2.cfg and the 150fourteen build IDs from the _info.txt files in http://stage.mozilla.org/pub/mozilla.org/thunderbird/nightly/1.5.0.14-candidates/rc1/

I would've had this working last night, but as you can see from the config, I used the bits in the thunderbird/release directory, and 1.5.0.14 was released today.

Comment 5

[J. Paul Reed [:preed]]

Comment on attachment 293983 [details] [diff] [review]
major update config changes, v1

Adding rhelmer to the r?, for the module; cf for content/sanity.

Comment 6

[J. Paul Reed [:preed]]

Attachment: AUS snippets generated from this config (.tar.bz2)

The prime the pipeline a bit here, these are the snippets (aus2, aus2.test directories) from a run of patcher:

./patcher2.pl --config ../patcher-configs/moz180-branch-major-update-patcher2.cfg --app=Thunderbird --create-patches 2>&1 | tee create-patches.log

Patcher had the following local patch applied to it:

Index: patcher2.pl
===================================================================
RCS file: /cvsroot/mozilla/tools/patcher/patcher2.pl,v
retrieving revision 1.25
diff -u -2 -r1.25 patcher2.pl
--- patcher2.pl 4 Dec 2007 18:11:10 -0000       1.25
+++ patcher2.pl 20 Dec 2007 03:28:08 -0000
@@ -118,5 +118,5 @@

     if ($config->RequestedStep('create-patches')) {
-        CreatePartialPatches(config => $config);
+        #CreatePartialPatches(config => $config);
         CreateCompletePatches(config => $config);
     }

(Basically, since we don't use the partials at all, don't bother [attempting] to create them, which failed anyway...)

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 293983 [details] [diff] [review]
major update config changes, v1

I know this got moved out till next year, but here's some things I noticed.

>     <complete>
>-      path = "thunderbird-2.0.0.6.%locale%.%platform%.complete.mar"
>-      url = "http://download.mozilla.org/?product=thunderbird-2.0.0.6-complete&os=%bouncer-platform%&lang=%locale%"
>+      path = "thunderbird-2.0.0.9.%locale%.%platform%.complete.mar"
>+      url = "http://download.mozilla.org/?product=thunderbird-2.0.0.9-complete&os=%bouncer-platform%&lang=%locale%"
>       betatest-url= "http://stage.mozilla.org/pub/mozilla.org/thunderbird/nightly/2.0.0.6-candidates/rc2/thunderbird-2.0.0.6.%locale%.%platform%.complete.mar"

Need to bump the version in betatest-url too.

>     </complete>
>     <partial>
>-      path = "thunderbird-2.0.0.6.%locale%.%platform%.complete.mar"
>-      url = "http://download.mozilla.org/?product=thunderbird-2.0.0.6-complete&os=%bouncer-platform%&lang=%locale%"
>+      path = "thunderbird-2.0.0.9.%locale%.%platform%.complete.mar"
>+      url = "http://download.mozilla.org/?product=thunderbird-2.0.0.9-complete&os=%bouncer-platform%&lang=%locale%"
>       betatest-url= "http://stage.mozilla.org/pub/mozilla.org/thunderbird/nightly/2.0.0.6-candidates/rc2/thunderbird-2.0.0.6.%locale%.%platform%.complete.mar"

Same as above.

> <release 2.0.0.9>
...
>     locales = be bg ca cs da de el en-GB en-US es-AR es-ES eu fi fr ga-IE \
>               hu it ja ja-JP-mac ko lt mk nb-NO nl nn-NO pa-IN pl pt-BR \

Between 2.0.0.6 and 2.0.0.9, the Hebrew locale (he) was added for win32 & linux - need to add that here and in the exceptions block.

Comment 9

[J. Paul Reed [:preed]]

Attachment: major update config changes, v2

Fixed; I also fixed the URLs to point to the releases/ area, not the 2.0.0.9 candidates area.

I took a second look at the locales and fixed that as well; of course, eyeballing it is never perfect. ;-)

Interdiff is likely your friend here.

Comment 10

[Przemyslaw Bialik]

There is related - Bug 387605 but it looks like it can be closed ?

Comment 11

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #10)
> There is related - Bug 387605 but it looks like it can be closed ?
Good spot. Yep, 387605 closed.


Tweaking subject to match schedule at http://wiki.mozilla.org/Releases.

Comment 12

[J. Paul Reed [:preed]]

(In reply to comment #11)
> Tweaking subject to match schedule at http://wiki.mozilla.org/Releases.

Resetting summary.

joduinn: please see 

https://bugzilla.mozilla.org/page.cgi?id=etiquette.html, specifically 2-1.

Comment 13

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #12)
> (In reply to comment #11)
> > Tweaking subject to match schedule at http://wiki.mozilla.org/Releases.
> Resetting summary.
> joduinn: please see 
> https://bugzilla.mozilla.org/page.cgi?id=etiquette.html, specifically 2-1.

My apologies. 

Bug#392551 (a preexisting bug already tracking TB major update) was closed as DUP by someone else yesterday. Instead of reopening bug#392551, I thought it made more sense to update the summary of bug#408906 to make it consistent with the public release schedule at http://wiki.mozilla.org/Releases. I'm sorry for modifying your bug; I see you've already reverted my changes to the summary. I have now reopened bug#392551, since they are not tracking the same issue.

Again, sorry, I thought I was doing the right thing.

Given the agreed public schedule, should we close bug#408906 as WONTFIX?

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 294751 [details] [diff] [review]
major update config changes, v2

r+ if you add 
  he   linux-i686, win32
to the exceptions block of the 2.0.0.9 release.

Comment 15

[J. Paul Reed [:preed]]

(In reply to comment #13)

> I'm sorry for
> modifying your bug; I see you've already reverted my changes to the summary. I
> have now reopened bug#392551, since they are not tracking the same issue.

I think everyone else thinks they are tracking exactly the same issue; can you explain why you think they aren't?

> Given the agreed public schedule, should we close bug#408906 as WONTFIX?

I don't particularly care which bug the work is tracked in.

I'm more interested in getting the work done, myself.

I don't see a reason that bug 392551 shouldn't be re-closed as a dup of this bug, but please explain why you think that's wrong.

You refer to an "agreed public schedule," but you've mentioned in (private) email that this meeting was not a public meeting; it was a schedule agreed upon in a private, Corporation-only meeting. The schedule is "public" insomuch as it was published on the public wiki, but "public" != "participatory."

I note this because there was a discussion on IRC (#200x) right before the holidays with a group of committed people (QA, build, etc.) about getting some people together to get this major update done and out, so we could finally retire the 1.8.0 branch, and you claimed there weren't enough time/resources/etc. to do the major update testing or release.

I'm somewhat confused by this claim, because the work itself was done in about an hour (by me, in this bug), there's some QA work to be done (and various QA peeps in IRC were interested in getting it finished up), and there was an hour or so of someone's time from the MoCo Build team to push out the snippets.

So I guess the claim you're making is that there is not a free hour (or heck, let's triple it, and say three) of time on the build side until the end of February? Am I interpreting that correctly?

Comment 16

[Mike Schroepfer]

> You refer to an "agreed public schedule," but you've mentioned in (private)
> email that this meeting was not a public meeting; it was a schedule agreed upon
> in a private, Corporation-only meeting. The schedule is "public" insomuch as it
> was published on the public wiki, but "public" != "participatory."
> 
> I note this because there was a discussion on IRC (#200x) right before the
> holidays with a group of committed people (QA, build, etc.) about getting some
> people together to get this major update done and out, so we could finally
> retire the 1.8.0 branch, and you claimed there weren't enough
> time/resources/etc. to do the major update testing or release.
> 
> I'm somewhat confused by this claim, because the work itself was done in about
> an hour (by me, in this bug), there's some QA work to be done (and various QA
> peeps in IRC were interested in getting it finished up), and there was an hour
> or so of someone's time from the MoCo Build team to push out the snippets.
> 
> So I guess the claim you're making is that there is not a free hour (or heck,
> let's triple it, and say three) of time on the build side until the end of
> February? Am I interpreting that correctly?

Nice straw man.   

Since you quoted bug Etiquette here I'd ask you to re-read 1-2 "No obligation".  You are signing other folks up for work.

This is an issue of priorities.  The build team is trying to shore up our infra from the last release to reduce total time spent doing releases.  What's the emergency in getting this out?  We've already done 1 major update.  We don't force folks to update so this is only for people who ignored the first one.   

If you think the release priorities are wrong let's have the discussion in a sane way.  I've cc'd MScott since I haven't heard from anyone on the thunderbird side expressing a concern that this should get out sooner.   But if there is a reason to change priorities let's hear it...

Comment 17

[Myk Melez [:myk] [@mykmelez]]

Even if this isn't a build team priority, it's a build team goal, and capable and motivated outside contributors like preed are a rare and precious resource, so it would behoove us to be looking for ways to take advantage of their contributions, even if that involves doing some necessary enabling work if we can't find ways to make it possible for them to do it.

Comment 18

[Nick Thomas [:nthomas] (UTC+12)]

Hope you don't me taking this Paul, we have a short window to get this done.

Comment 19

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [checked in] major update config for 1.5.0.14 --> 2.0.0.14

Updates the paths and locale lists to the latest releases for 1.5.0.x and 2.0.0.y. I've dropped the betatest-url lines because QA might as well test from the mirrors (to avoid retesting later) - it'll makes betatest and releasetest identical.

Comment 21

[[e-mail] (:bhearsum)]

Comment on attachment 324027 [details] [diff] [review]
[checked in] major update config for 1.5.0.14 --> 2.0.0.14

>Index: moz180-branch-major-update-patcher2.cfg
>===================================================================
>     details = "http://%locale%.www.mozilla.com/%locale%/thunderbird/2.0.0.0/details/index.html"
>     license = "http://%locale%.www.mozilla.com/%locale%/thunderbird/2.0.0.0/eula/index.html"

I'm not sure if this URL is right. http://en-us.www.mozilla.com/en-US/thunderbird/2.0.0.0/details/index.html gives me a page saying 'your version is out of date, blah blah'. Using 2.0.0.14 in the URL is a 404 though.


>     <partial>
>-      path = "thunderbird-2.0.0.6.%locale%.%platform%.complete.mar"
>-      url = "http://download.mozilla.org/?product=thunderbird-2.0.0.6-complete&os=%bouncer-platform%&lang=%locale%"
>-      betatest-url= "http://stage.mozilla.org/pub/mozilla.org/thunderbird/nightly/2.0.0.6-candidates/rc2/thunderbird-2.0.0.6.%locale%.%platform%.complete.mar"
>+      path = "thunderbird-2.0.0.14.%locale%.%platform%.complete.mar"
>+      url = "http://download.mozilla.org/?product=thunderbird-2.0.0.14-complete&os=%bouncer-platform%&lang=%locale%"

No partials for major updates, I'm assuming?

>-  <release 1.5.0.12>
>-  <release 2.0.0.6>

Everything else looks fine, but this is confusing. Did you remove these two sections, or is diff just playing tricks with my mind?

Comment 22

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 324027 [details] [diff] [review]
[checked in] major update config for 1.5.0.14 --> 2.0.0.14

(In reply to comment #21)
> I'm not sure if this URL is right.
> http://en-us.www.mozilla.com/en-US/thunderbird/2.0.0.0/details/index.html gives
> me a page saying 'your version is out of date, blah blah'. Using 2.0.0.14 in
> the URL is a 404 though.

That's the "scary" message that appears in the update dialog for major updates. We just use the one URL for all MUs.
 
> No partials for major updates, I'm assuming?

Not real ones, you get two bites at the complete cherry.
 
> >-  <release 1.5.0.12>
> >-  <release 2.0.0.6>
> Everything else looks fine, but this is confusing. Did you remove these two
> sections, or is diff just playing tricks with my mind?

I morphed them rather than adding new blocks, then diff played with your mind. ;-)

Checking in moz180-branch-major-update-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz180-branch-major-update-patcher2.cfg,v  <--  moz180-branch-major-update-patcher2.cfg
new revision: 1.2; previous revision: 1.1
done

Comment 23

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [checkd in] Updated verify configuration

This updates the buildID, version, and uses the files in the releases part of the ftp rather than nightly.

Comment 24

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 324045 [details] [diff] [review]
[checkd in] Updated verify configuration

Checking in moz180-thunderbird-linux-major.cfg;
/cvsroot/mozilla/testing/release/updates/moz180-thunderbird-linux-major.cfg,v  <--  moz180-thunderbird-linux-major.cfg
new revision: 1.2; previous revision: 1.1
done
Checking in moz180-thunderbird-mac-major.cfg;
/cvsroot/mozilla/testing/release/updates/moz180-thunderbird-mac-major.cfg,v  <--  moz180-thunderbird-mac-major.cfg
new revision: 1.2; previous revision: 1.1
done
Checking in moz180-thunderbird-win32-major.cfg;
/cvsroot/mozilla/testing/release/updates/moz180-thunderbird-win32-major.cfg,v  <--  moz180-thunderbird-win32-major.cfg
new revision: 1.2; previous revision: 1.1
done

Comment 25

[Nick Thomas [:nthomas] (UTC+12)]

I committed a follow up patch to replace the %20's with a space in the from & to vars for linux & mac. That's what we used for Firefox but I'd forgotten to check.

Comment 26

[Nick Thomas [:nthomas] (UTC+12)]

The preliminary results of the update verify run are
* gu-IN fails to find an update on linux and win32 because there's no 2.0.0.14 build to go to (we didn't ship 1.5.0.14 mac) - that's expected
* there are some files left over (source is the updated copy, target is 2.0.0.14)
** Win32:
Only in source/bin/components: myspell
Only in source/bin/defaults: isp
diff -r source/bin/defaults/pref/channel-prefs.js target/bin/defaults/pref/channel-prefs.js
1c1
< //@line 2 "/cygdrive/c/builds/tinderbox/Tb-Mozilla1.8.0-Release/WINNT_5.2_Depend/mozilla/mail/app/profile/channel-prefs.js"
---
> //@line 2 "/cygdrive/e/builds/tinderbox/Tb-Mozilla1.8-Release/WINNT_5.0_Depend/mozilla/mail/app/profile/channel-prefs.js"
Only in source/bin: removed-files
Only in source/bin/uninstall: uninstall.ini

** Mac:
Only in target/Thunderbird.app/Contents/MacOS/chrome: installed-chrome.txt
Only in source/Thunderbird.app/Contents/MacOS/components: downloadmanager.xpt
Only in source/Thunderbird.app/Contents/MacOS/components: myspell
Only in source/Thunderbird.app/Contents/MacOS/components: sidebar.xpt
Only in source/Thunderbird.app/Contents/MacOS/defaults: isp
diff -r source/Thunderbird.app/Contents/MacOS/defaults/pref/channel-prefs.js target/Thunderbird.app/Contents/MacOS/defaults/pref/channel-prefs.js
1c1
< //@line 2 "/builds/tinderbox/Tb-Mozilla1.8.0-Release/Darwin_8.7.0_Depend/mozilla/mail/app/profile/channel-prefs.js"
---
> //@line 2 "/builds/tinderbox/Tb-Mozilla1.8-Release/Darwin_8.7.0_Depend/mozilla/mail/app/profile/channel-prefs.js"
Only in source/Thunderbird.app/Contents/MacOS/res: bloatcycle.html

** Linux:
Only in target/thunderbird/chrome: installed-chrome.txt
Only in source/thunderbird/components: downloadmanager.xpt
Only in source/thunderbird/components: myspell
Only in source/thunderbird/components: sidebar.xpt
Only in source/thunderbird/defaults: isp
diff -r source/thunderbird/defaults/pref/channel-prefs.js target/thunderbird/defaults/pref/channel-prefs.js
1c1< 
//@line 2 "/builds/tinderbox/Tb-Mozilla1.8.0-Release/Linux_2.4.18-14_Depend/mozilla/mail/app/profile/channel-prefs.js"
---
> //@line 2 "/builds/tinderbox/Tb-Mozilla1.8-Release/Linux_2.4.18-14_Depend/mozilla/mail/app/profile/channel-prefs.js"
Only in source/thunderbird/res: bloatcycle.html
Only in target/thunderbird: updates

channel-prefs, removed-files, and res/bloatcycle are harmless, and I suspect myspell is probably an empty directory. Not sure about uninstall.ini (the app hasn't run at this point, we just call the updater on the command line) or isp/ - probably harmless.

components/{downloadmanager.xpt,sidebar.xpt} are more perturbing and I'd be interested in bsmedberg's opinion. I'm pretty sure that we shipped the first major update with this, certainly there haven't been any changes to 
  mozilla/mail/installer/removed-files.in
since 2007-04-30.

Comment 27

[Nick Thomas [:nthomas] (UTC+12)]

Done and dusted