409166 - missing crop attribute in agenda checkbox

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Andreas Treumann]

Attachment: screenshoot

missing crop attribute in agenda checkbox. This yields sometimes a ugly line break, see screenshoot.

Comment 1

[Berend Cornelius]

Probably it would be better to make the containing richlistitem flexible in height so it adjusts when the checkbox label is using several lines

Comment 3

[Christian Jansen]

(In reply to comment #1)
> Probably it would be better to make the containing richlistitem flexible in
> height so it adjusts when the checkbox label is using several lines
> 

I suggest to display the tree only for "Today" on all other days
the agenda should be a flat list.

Comment 4

[Robert]

(In reply to comment #0)
> 
> missing crop attribute in agenda checkbox.
> 


Well, I changed and added attributes with DOM Inspector. Even by adding the "crop" attribute to the label (and some of its parent elements), nothing changed. However, when I copied the date from the "text" attribute to the "value" attribute, it worked. Maybe someone who is experienced knows how to make this work with "text" too; if this isn't possible, I'm afraid that this can't be changed without effects on other elements.

A fix would be to remove "overflow: hidden;" from "agenda-checkbox-richlist-item" in today-pane.css. This does what Berend proposed: If the label needs two lines, the item gets more height. However I'm not sure if Andreas dislikes the line break at all or just how it looks.


Btw, the label "agenda-event-title" has "crop" set to "end" and "value" is used, but still the text is cut off instead of showing "..." at its end.
If "overflow: hidden;" is removed from the other two richlist items as well, a scrollbar appears as soon as one of the items' title is too long.

Comment 5

[Berend Cornelius]

>If "overflow: hidden;" is removed from the other two richlist items as well, a
>scrollbar appears as soon as one of the items' title is too long.

Christian (and I agreed) did not want to have the horizontal scrollbar that's why I assigned the overflow. It would be good if we can find a solution without changing this. 
But did you consider Christian's comment #3? 
The lines are mostly destroyed if the todaypane is not in Today-mode because then you have this very long title displaying the date. Therefor I think we should follow Christian's proposal, because we don't need the date information when we are not in "Today-mode" - all date-related info is already in the minimonth.

Comment 6

[Robert]

I agree to you, this really seems to be a better solution.
Now the functions in agenda-listbox.js rely on the header for example when inserting or removing items. So completly removing the header would require special handling at all those places.
A much easier solution is just to hide the header and make sure the checkbox is checked. Is this considered as "dirty" or is it a way worth following?

Comment 7

[Berend Cornelius]

No, on the current codeline this is not possible. There is a known  Gecko bug that disturbs keyboard travelling over hidden richlistitems. That's why I could not hide the headers.

Comment 9

[Berend Cornelius]

Attachment: patch v. #1

This patch should resolve the issue. I did not follow Christian's suggestion in comment #3 to abandon the checkbox when the agenda-listbox is not in today's mode. The reason is that the user meanwhile may configure the todaypane without miniday or minimonth. In this case we would not have any date information without the checkbox label.

Comment 10

[Daniel Boelzle [:dbo]]

Comment on attachment 335371 [details] [diff] [review]
patch v. #1

r=dbo

Comment 11

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH
->FIXED

Comment 12

[Andreas Treumann]

Checked in lightning build 2008082619 -> VERIFIED.