409471 - Cleanup some GTK code for performance

Status: NEW

(Core :: Widget: Gtk, defect, P5)

Description

[Ian Spence]

We need to add

gOptionMenuWidget = NULL;
gSpinWidget = NULL;

to moz_gtk_shutdown()

Comment 1

[Teune van Steeg]

> We need to add
> 
> gOptionMenuWidget = NULL;
> gSpinWidget = NULL;
> 
> to moz_gtk_shutdown()
> 

Note that those objects have not been added in patches subject of causing 409410.

Comment 2

[Christian Persch (GNOME) (away; not receiving bug mail)]

Note that setting the pointers to NULL is just cleanup, since all widget were children of the GtkFixed in the gProtoWindow and thus destroyed when gProtoWindow is destroyed just above this code.

Comment 3

[Reed Loden [:reed]]

(In reply to comment #2)
> Note that setting the pointers to NULL is just cleanup, since all widget were
> children of the GtkFixed in the gProtoWindow and thus destroyed when
> gProtoWindow is destroyed just above this code.

Why is gTooltipWidget treated specially then in moz_gtk_shutdown()?

    if (gTooltipWidget)
        gtk_widget_destroy(gTooltipWidget);
    /* This will destroy all of our widgets */
    if (gProtoWindow)
        gtk_widget_destroy(gProtoWindow);

Comment 4

[Reed Loden [:reed]]

(In reply to comment #3)
> Why is gTooltipWidget treated specially then in moz_gtk_shutdown()?

Bug 216752 explains, so never mind, I guess.

Comment 5

[Reed Loden [:reed]]

(In reply to comment #0)
> We need to add
> 
> gOptionMenuWidget = NULL;
> gSpinWidget = NULL;
> 
> to moz_gtk_shutdown()

With roc's r+sr+a1.9 from IRC, I landed the addition of those two lines to moz_gtk_shutdown().

Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.62; previous revision: 1.61
done

Leaving this open for any other clean-up.

Comment 6

[Ian Spence]

Was just thinking.

Could any of this be caused by the fact I forget to set it so the state of toolbar separators don't change?  I think that means you get repaints on mouseover when you shouldn't

Comment 7

[Reed Loden [:reed]]

(In reply to comment #6)
> Could any of this be caused by the fact I forget to set it so the state of
> toolbar separators don't change?  I think that means you get repaints on
> mouseover when you shouldn't

Anything that will help perf is welcome.

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1552613