409655 - [gtk2] Toolbar dropdown buttons should visually be two adjacent, independent buttons on GTK

Status: RESOLVED INVALID

(Core :: Widget: Gtk, defect)

Description

[Fabien Tassin]

Attachment: foward button

When hovered, the history (bottom arrow) part of the forward and backward buttons have no left corners.

Attached a screenshot, the bottom is missing but it's just a screenshot issue.
Just look at the top. This bug is about the red circle part.

Comment 1

[Ian Spence]

** The following post is towards any developers who know more than I do about mozilla **
** So that's most developers **

I'm at least getting somewhere here, although I have one issue that isn't GTK related.

I have a box

+---------------------------------------+
| +--------------------------+ +------+ |
| |                          | |      | |
| |                          | |      | |
| |                          | |  __  | |
| |           A              | |  \/  | |
| |                          | |      | |
| |                          | |      | |
| |                          | |      | |
| +--------------------------+ +------+ |
+---------------------------------------+

Box A is the toolbutton containing the back/forward button, the box to the right is the xul:dropmarker button. They are both enclosed in another box which holds the state for the xul:dropmarker.

** Warning, I'm possibly about to misuse terms **
Both children are anonymous elements, so if I mouseover from one to the other, the state of the xul:dropmarker does not change.
Apparently using allowevents="true" fixes this, but it causes the xul:dropmarker to behave as the back button, no longer showing the dropdown.
So my question is... How do I make it so the xul:dropmarker causes state changes without using allowevents="true"?

Comment 2

[Julien "_FrnchFrgg_" RIVAUD]

In GTK such dual dropdown toolbar buttons seem not to be visually represented as a single object but rather as two adjacent buttons (tested in glade, since I didn't find any dualbutton in applications I had installed or quickly installable without using heaps of disk space).
We need to decide if we follow this style or not; twanno, ventnor, what do you think ?

Comment 4

[Daniel Luz]

This bug doesn't really apply anymore with the new unified look. Unless there is the possibility of reverting to the old style (either due to a rollback of the change or through options), I guess this should be closed.

Comment 5

[Daniel Luz]

My bad, sorry for the bugspam; before reading bug 175095, I didn't know there were other places where this kind of button was used. Maybe the description should be updated then, to reflect buttons with drop-downs as a whole.

Comment 6

[Julien "_FrnchFrgg_" RIVAUD]

Daniel: In fact, with the new unified look, on GTK they took the "two adjacent buttons" route, so my last question is answered. For other dropdown buttons, we could do the same.

I'm not sure I'll have time to write a patch for it, but if nobody does so soon, I'll try.

Comment 8

[u294409]

This should be now Thunderbird-only bug (not sure about Sunbird), since Firefox has merged the back and forward buttons.

Comment 9

[u294409]

_FrnchFrgg_: do not count on others. If you have ability to write a patch, just do it.

Comment 10

[Ian Spence]

This should remain a Core bug as it applies to all products.

Comment 11

[u294409]

Ok. This bug is almost one year old... OMG.

Comment 12

[Julien "_FrnchFrgg_" RIVAUD]

I take this bug. I'll be probably able to solve it next week or the week after; I think it's in fact really simple to solve, since we just need to remove the special casing for dropdowns and and modify some CSS.

Comment 13

[Magnus Melin [:mkmelin]]

Julien: any progress?

Comment 14

[Jonathan Watt [:jwatt]]

Closing GTK2 related bugs since we removed GTK2 support at the beginning of 2018 in bug 1278282. Probably best to open a new bug in the unlikely event that any of these are still relevant.