409845 - [Mac] 'Preferences' and 'Quit Thunderbird' are disabled in Calendar mode and Task mode

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Shinya Kuribayashi]

Thunderbird 2.0.0.9 + local Lightning 0.8pre build from the latest MOZILLA_1_8_BRANCH,

Steps to Reproduce:
1. Change to Calendar mode or Task mode
2. Press COMMAND+','  , but Preference dialogue doesn't apper.
3. Select Thunderbird -> Preferences..., ditto.
4. Press COMMAND+'q', but Thunderbird doesn't shut down.
5. Select Thunderbird -> Quit Thunderbird, ditto.

Other menus seem to work. I don't know whether this is expected behavior or not of Lightning 0.8pre.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Reporter, could you please provide more info on the language of localization for the devs to replicate?

Also, do test with the latest nightlies and post the build ID (date of build etc). Thanks!

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

And on today's test date, I confirm this bug.

Tested on a fresh profile, latest nightly (10 Jan 08 Lightning; TB 2.0.0.9). I had to run with Rosetta due to nightlies for PPC.

More investigation shows that any attempt to access preferences (no matter through mouse or keyboard) doesn't seem to succeed, and this only happens in calendar mode.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

but everything works correctly again when back to mail mode.

Comment 4

[Simon Paquet [:sipaq]]

This does not block the 0.8 release.

Comment 5

[daniel]

can confirm this bug in 17-Feb-2008 Nightly build

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Because this feels like pretty major functionality loss, it should at least be relnoted, I think.  I'm assuming that it can be worked around just by switching back to mail mode.

Comment 8

[Matthew (lilmatt) Willis]

(In reply to comment #7)
You assume correctly.  Once you switch back to Mail, the menu items and shortcut keys all work again.

Comment 9

[Simon Paquet [:sipaq]]

relnote added

Comment 11

[Shinya Kuribayashi]

I managed to tracked down with ppc mac-xpi binary using Rosetta. 

Regression range: Works in Lightning 0.8pre (2007-11-29-03)
                  Fails in Lightning 0.8pre (2007-11-30-04)

Checkins during regression range: http://tinyurl.com/4cnfxa

Hope this helps.

Comment 13

[Berend Cornelius]

Attachment: patch v. #1

I added some special treatment for the mentioned menuitems.

Comment 14

[Daniel Boelzle [:dbo]]

Comment on attachment 330930 [details] [diff] [review]
patch v. #1

add
+#ifdef XP_MACOSX
>+var quitMenu = null;
>+var prefMenu = null;
#endif

works on Mac; r=dbo

Comment 15

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 16

[Andreas Treumann]

Checked in nightly build 2008072321 -> bug is not fixed correctly

STR
===

- start thunderbird
- switch to calendar/task mode
- switch back to mail mode
- try to open the preferences dialog via menu or COMMAND+',' -> nothing happens ( same with 'Quit Thunderbird' or COMMAND+'q')

Without calendar/task mode switch it is possible to use the commands in mail mode. 

Comment 17

[Berend Cornelius]

Attachment: patch v. #2

This additional patch should fix it...

Comment 18

[Berend Cornelius]

patch v. #3 checked in on trunk and MOZILLA_1_8_BRANCH

->FIXED

Comment 19

[Andreas Treumann]

Checked again with nightly build 2008072420 -> VERIFIED