Closed Bug 409845 Opened 12 years ago Closed 12 years ago

[Mac] 'Preferences' and 'Quit Thunderbird' are disabled in Calendar mode and Task mode

Categories

(Calendar :: Lightning Only, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: skuribay, Assigned: berend.cornelius09)

References

Details

Attachments

(2 files)

Thunderbird 2.0.0.9 + local Lightning 0.8pre build from the latest MOZILLA_1_8_BRANCH,

Steps to Reproduce:
1. Change to Calendar mode or Task mode
2. Press COMMAND+','  , but Preference dialogue doesn't apper.
3. Select Thunderbird -> Preferences..., ditto.
4. Press COMMAND+'q', but Thunderbird doesn't shut down.
5. Select Thunderbird -> Quit Thunderbird, ditto.

Other menus seem to work. I don't know whether this is expected behavior or not of Lightning 0.8pre.
Target Milestone: 0.8 → ---
Version: Mozilla 1.8 Branch → unspecified
Reporter, could you please provide more info on the language of localization for the devs to replicate?

Also, do test with the latest nightlies and post the build ID (date of build etc). Thanks!
And on today's test date, I confirm this bug.

Tested on a fresh profile, latest nightly (10 Jan 08 Lightning; TB 2.0.0.9). I had to run with Rosetta due to nightlies for PPC.

More investigation shows that any attempt to access preferences (no matter through mouse or keyboard) doesn't seem to succeed, and this only happens in calendar mode.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-calendar0.8?
but everything works correctly again when back to mail mode.
This does not block the 0.8 release.
Flags: blocking-calendar0.8? → blocking-calendar0.8-
can confirm this bug in 17-Feb-2008 Nightly build
Duplicate of this bug: 418370
Flags: blocking-calendar0.8- → wanted-calendar0.9?
Flags: wanted-calendar0.9? → wanted-calendar0.9+
Because this feels like pretty major functionality loss, it should at least be relnoted, I think.  I'm assuming that it can be worked around just by switching back to mail mode.
Keywords: relnote
(In reply to comment #7)
You assume correctly.  Once you switch back to Mail, the menu items and shortcut keys all work again.
relnote added
Duplicate of this bug: 428143
I managed to tracked down with ppc mac-xpi binary using Rosetta. 

Regression range: Works in Lightning 0.8pre (2007-11-29-03)
                  Fails in Lightning 0.8pre (2007-11-30-04)

Checkins during regression range: http://tinyurl.com/4cnfxa

Hope this helps.
Duplicate of this bug: 429502
Flags: blocking-calendar0.9?
Flags: blocking-calendar0.9? → blocking-calendar0.9+
Assignee: nobody → daniel.boelzle
Attached patch patch v. #1Splinter Review
I added some special treatment for the mentioned menuitems.
Assignee: daniel.boelzle → Berend.Cornelius
Status: NEW → ASSIGNED
Attachment #330930 - Flags: review?(daniel.boelzle)
Comment on attachment 330930 [details] [diff] [review]
patch v. #1

add
+#ifdef XP_MACOSX
>+var quitMenu = null;
>+var prefMenu = null;
#endif

works on Mac; r=dbo
Attachment #330930 - Flags: review?(daniel.boelzle) → review+
patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Checked in nightly build 2008072321 -> bug is not fixed correctly

STR
===

- start thunderbird
- switch to calendar/task mode
- switch back to mail mode
- try to open the preferences dialog via menu or COMMAND+',' -> nothing happens ( same with 'Quit Thunderbird' or COMMAND+'q')

Without calendar/task mode switch it is possible to use the commands in mail mode. 
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch patch v. #2Splinter Review
This additional patch should fix it...
Attachment #331089 - Flags: review?(daniel.boelzle)
Attachment #331089 - Flags: review?(daniel.boelzle) → review+
patch v. #3 checked in on trunk and MOZILLA_1_8_BRANCH

->FIXED
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Keywords: relnote
Target Milestone: --- → 0.9
Checked again with nightly build 2008072420 -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.