412109 - TB xpcom null arg test suite, mostly to make it harder for extension authors to shoot themselves in the foot.

Status: NEW

(MailNews Core :: Backend, task)

Description

[Joey Minta]

Attachment: test-suite

Inspired by bug 411646, this is a test-suite for a global check to make sure all of tb's xpcom components and functions handle null arguments gracefully (ie. don't crash).

Bugs blocking this one are those which this test uncovered, since we can't enable it until they're fixed.  The test does have a known-failures option if a few turn out to be especially pesky.

Meant to be run from xpcshell.  I'll hook it into the normal |make check| routine as we get closer to enabling it.

Comment 1

[Joey Minta]

I should add that while we may catch a few live crashers in these tests, the vast majority of this is simply making it harder for extension authors to shoot themselves in the foot.

Comment 2

[Joey Minta]

Attachment: test-suite with known failures

This is the same test-suite, but with all the known failures not fixed by the blocking bugs.  There's still a shutdown crash that I haven't figured out yet though, if someone wants to poke at that.

Comment 3

[Serge Gautherie (:sgautherie)]

I was ping'ed in bug 413548,
I looked at this bug and related ones.

Joey's patches are nearly 3-year old and spread in multiple bugs, which confuses me a little, (I'll refer to them yet),
then I prefer to probably do more but one file at a time, as in bug 611233.

Comment 4

[:aceman]

Serge, when the blocking bugs will get closed, are you able to use the attached testsuite and check if everything got fixed? If yes, then you could take this bug.

Comment 5

[Wayne Mery (:wsmwk)]

Geoff, do you want to rerun the test suite as suggested in comment 4? Then perhaps we can close this out.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: test_interfaces.js

Here's a somewhat updated version, with a list of all the classes that fail. So closing this? I don't think so.

And no, I'm not offering to fix the listed classes. Perhaps Magnus has some manpower spare.

Comment 7

[Wayne Mery (:wsmwk)]

Is this relevant in the webextensions world?