Open Bug 412109 Opened 14 years ago Updated 1 year ago

TB xpcom null arg test suite, mostly to make it harder for extension authors to shoot themselves in the foot.

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: jminta, Unassigned)

References

Details

(Keywords: testcase)

Attachments

(2 files, 1 obsolete file)

Attached file test-suite (obsolete) —
Inspired by bug 411646, this is a test-suite for a global check to make sure all of tb's xpcom components and functions handle null arguments gracefully (ie. don't crash).

Bugs blocking this one are those which this test uncovered, since we can't enable it until they're fixed.  The test does have a known-failures option if a few turn out to be especially pesky.

Meant to be run from xpcshell.  I'll hook it into the normal |make check| routine as we get closer to enabling it.
Depends on: 412113
I should add that while we may catch a few live crashers in these tests, the vast majority of this is simply making it harder for extension authors to shoot themselves in the foot.
Depends on: 412134
Depends on: 412137
Depends on: 412138
Depends on: 412143
Depends on: 412144
Depends on: 413518
Depends on: 413521
Depends on: 413524
Depends on: 413544
Depends on: 413548
Depends on: 413578
Depends on: 413590
This is the same test-suite, but with all the known failures not fixed by the blocking bugs.  There's still a shutdown crash that I haven't figured out yet though, if someone wants to poke at that.
Attachment #296744 - Attachment is obsolete: true
Flags: wanted-thunderbird3+
Depends on: 611233
I was ping'ed in bug 413548,
I looked at this bug and related ones.

Joey's patches are nearly 3-year old and spread in multiple bugs, which confuses me a little, (I'll refer to them yet),
then I prefer to probably do more but one file at a time, as in bug 611233.
Version: unspecified → Trunk
Serge, when the blocking bugs will get closed, are you able to use the attached testsuite and check if everything got fixed? If yes, then you could take this bug.
Assignee: jminta → nobody
Status: ASSIGNED → NEW
Component: General → Backend
Product: Thunderbird → MailNews Core
QA Contact: general → backend
Depends on: 707306
Depends on: 717407
Keywords: testcase

Geoff, do you want to rerun the test suite as suggested in comment 4? Then perhaps we can close this out.

Flags: needinfo?(geoff)
Summary: TB xpcom null arg test suite → TB xpcom null arg test suite, mostly to make it harder for extension authors to shoot themselves in the foot.
Attached file test_interfaces.js

Here's a somewhat updated version, with a list of all the classes that fail. So closing this? I don't think so.

And no, I'm not offering to fix the listed classes. Perhaps Magnus has some manpower spare.

Flags: needinfo?(geoff)
You need to log in before you can comment on or make changes to this bug.