412386 - fixed and new Hungarian dictionary add-ons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Dictionaries, defect)

Description

[Németh László]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2) Gecko/2007121016 Firefox/3.0b2
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2) Gecko/2007121016 Firefox/3.0b2

1. Mozilla Add-on site contains a bad and badly licensed Hungarian dictionary add-on. The original MySpell dictionary (except its license) has been replaced with the incompatible Hunspell version in the add-on version 1.1.3.
The result is unacceptable spell checking in Firefox 2, see Bug 392011.
Also this add-on is old for Firefox 3 beta.

I have made two new Add-on, a fix for Firefox 2, and a Hunspell version (for Firefox 3 beta):

http://downloads.sourceforge.net/magyarispell/hungarian_dictionary-1.1.3.1-fx+zm+tb.xpi
http://downloads.sourceforge.net/magyarispell/hungarian_dictionary-1.1.4-fx+zm+tb.xpi

I tried to upload them, but I've got the "you don't have the permission to update this add-on" message. We need to replace the bad add-on with the new ones on Mozilla dictionary page.

2. We ask to add default Hungarian spelling dictionary to the localized version of Firefox and Thunderbird. The license of the Hungarian dictionary has been changed to LGPL/GPL/MPL tri-license on your request.


Reproducible: Always

Steps to Reproduce:
1/1. Install Hungarian dictionary add-on version 1.1.3 from https://addons.mozilla.org/en-US/firefox/browse/type:3 in Firefox 2.
1/2. Set Hungarian language in the context menu of a text area
1/3. Write the following Hungarian words in the text area: elmegy,  lenéz,  széttép,  kiszalad.

2/1. Install a localized Hungarian Firefox 2 (unfortunately, there is no localized 3 beta).

Actual Results:  
1. The words are underlined, and the spell checker suggests "el megy", "le néz" etc.

2. There is no Hungarian spell checking in Hungarian Firefox 2: see languages menu item of text are context menu.

Expected Results:  
1. Recognize elmegy, lenéz, etc. common Hungarian words. 

2. There is default Hungarian spell checking in Hungarian versions of Mozilla products.

Comment 1

[Németh László]

The second part of this issue (default spelling dictionaries in localized versions) needs a global solution: more and more MPL licensed spelling dictionaries will be there (we have already Hungarian, Polish, Arabic etc.).

Comment 2

[Axel Hecht [:Pike]]

File a separate bug on the Hungarian localization? https://bugzilla.mozilla.org/enter_bug.cgi?product=Mozilla%20Localizations

It'd be good to update http://wiki.mozilla.org/L10n:Dictionaries#Hungarian, too, as that's the central point of reference I use to find out if I have to worry about a particular dictionary or not.

Comment 3

[Németh László]

(In reply to comment #2)
> File a separate bug on the Hungarian localization?
> https://bugzilla.mozilla.org/enter_bug.cgi?product=Mozilla%20Localizations

I have made a new issue about the default dictionaries of localized products: Bug 414344.

> 
> It'd be good to update http://wiki.mozilla.org/L10n:Dictionaries#Hungarian,
> too, as that's the central point of reference I use to find out if I have to
> worry about a particular dictionary or not.

We do. Could you update the Hungarian add-on? It would be fantastic.

Thanks for your help,
László

> 

Comment 4

[Németh László]

(In reply to comment #2)
> File a separate bug on the Hungarian localization?
> https://bugzilla.mozilla.org/enter_bug.cgi?product=Mozilla%20Localizations

For the first part: András Tímár, the leader of the Hungarian localization has also no access or permission to update the Hungarian add-on. Please, help!

Comment 5

[Németh László]

Attachment: Fixed Hungarian Add-on for MySpell (Firefox 2, etc.)

Tested on Firefox 2 and Firefox 3 beta 2

Comment 6

[Németh László]

Attachment: Hungarian Add-on for Hunspell (Firefox 3)

Tested with Firefox 3 beta 2

Comment 7

[Németh László]

Hungarian localization team cannot update the broken Hungarian dictionary Add-on on Mozilla AMO site, so we need your help. Add-ons have been attached.

Comment 8

[Wil Clouser [:clouserw]]

(In reply to comment #7)
> Hungarian localization team cannot update the broken Hungarian dictionary
> Add-on on Mozilla AMO site, so we need your help. Add-ons have been attached.
> 

I replaced the currently hosted dictionary on AMO with your first attachment (for FF2, etc.).  I'll bring up FF3 support and dictionaries in the AMO meeting tomorrow to figure out how we're going to handle that.

Comment 9

[Németh László]

Attachment: Fixed Hungarian Add-on for MySpell (Firefox 2, etc.)

Also MySpell dictionary has been relicensed to GPL/LGPL/MPL.

Comment 10

[Németh László]

(In reply to comment #8)
> I replaced the currently hosted dictionary on AMO with your first attachment
> (for FF2, etc.).  

I'm very glad of your great help. Many thanks for it.

I'm sorry, I have just recognized, that I put the license file of the new Hunspell dictionary to the MySpell package. I fixed it, and relicensed the old
GPLed MySpell dictionary to GPL/LGPL/MPL, too. Now the license of the hosted Hungarian dictionary is ok.

> I'll bring up FF3 support and dictionaries in the AMO meeting
> tomorrow to figure out how we're going to handle that.
> 

The best for the users of the Hungarian localisation will be the default Hungarian dictionary (Bug 414344). Perhaps AMO dictionary page might have a button "dictionaries for Firefox 3 or newer", too.

By the way, now the product version numbers of Hungarian Add-ons constrain MySpell dictionary only for Firefox 2 and the new Hunspell dictionary for Firefox 3 (but Hunspell is backward compatible with MySpell).

Thanks again, László

Comment 11

[Wil Clouser [:clouserw]]

> > I'll bring up FF3 support and dictionaries in the AMO meeting
> > tomorrow to figure out how we're going to handle that.
> > 
> 
> The best for the users of the Hungarian localisation will be the default
> Hungarian dictionary (Bug 414344). Perhaps AMO dictionary page might have a
> button "dictionaries for Firefox 3 or newer", too.
> 
> By the way, now the product version numbers of Hungarian Add-ons constrain
> MySpell dictionary only for Firefox 2 and the new Hunspell dictionary for
> Firefox 3 (but Hunspell is backward compatible with MySpell).
> 

So, would it be best to replace what is there the Hunspell version and make it available to all versions of all applications?

Also, I'd be happy to add someone as an author for the add-on so they could update the dictionary and meta-data when needed.

Comment 12

[Németh László]

(In reply to comment #11)
> > Firefox 3 (but Hunspell is backward compatible with MySpell).
> > 
> 
> So, would it be best to replace what is there the Hunspell version and make it
> available to all versions of all applications?

I was wrong. Most of recent Hunspell dictionaries are backward compatible with MySpell (because they don't uses special features of Hunspell), but Hungarian is not. For example, the the preferred Hungarian Hunspell dictionary is UTF-8 encoded, but MySpell doesn't support Unicode encoding.

> 
> Also, I'd be happy to add someone as an author for the add-on so they could
> update the dictionary and meta-data when needed.

I'm happy to be this author. I'd like to update the old MySpell dictionary with the new words of the Hungarian Hunspell dictionary in the near future, so this permission would be a great help. Thanks, László

Comment 13

[Wil Clouser [:clouserw]]

I just added the current author of the dictionary for any comments before I add anyone else as an author.  Sorry for not having you on the discussion earlier.

Comment 14

[Németh László]

(In reply to comment #13)
> I just added the current author of the dictionary for any comments before I add
> anyone else as an author.  Sorry for not having you on the discussion earlier.
> 

Hi Lőrinc,

Unfortunately, we were not be able to inform you, that there were a lot of problems with your Hungarian Add-on update (see http://mozilla.fsf.hu).
If you don't mind, the Hungarian localization team will ensure the future Hungarian dictionary updates. Thanks, Laci

Comment 15

[Andras Timar]

Currently the Hungarian dictionary addon (http://releases.mozilla.org/pub/mozilla.org/addons/3386/) is not available at AMO. It simply does not appear on the list (neither for Firefox nor for Thunderbird). 

The maintaner of the Hungarian dictionary addon (Németh László) currently does not have right to update it on AMO.

Could you please advise how to improve the situation.

Thanks!

Comment 16

[Basil Hashem [:baz]]

I noticed that this add-on was disabled, I've re-enabled it. Now, to add the author, can you please add the AMO-registered email adddress(es) and I can add these as authors to the add-on.

Comment 17

[Németh László]

(In reply to comment #16)
> I noticed that this add-on was disabled, I've re-enabled it. Now, to add the
> author, can you please add the AMO-registered email adddress(es) and I can add
> these as authors to the add-on.
> 

Thank you very much. Our e-mail addresses:

András Tímár (lead of Hungarian language team): [e-mail]
László Németh (author of the dictionary): [e-mail]

We may have an other problem with the dictionary update: the Submit Add-on Step 1 (Upload File) form doesn't contain the "Hungarian" option in the Default Locale selection box. If it is a problem, could you help us in that, too? Thanks, László

Comment 18

[Andras Timar]

(In reply to comment #16)
> I noticed that this add-on was disabled, I've re-enabled it. Now, to add the
> author, can you please add the AMO-registered email adddress(es) and I can add
> these as authors to the add-on.

Hello Basil, 

Could you please add us at your earliest convenience. Thanks! The users of this extension are literally "crying and begging" for the update and we cannot do that. Unfortunately they think we are lazy and/or incompetent. We have tried to add a new extension but the system did not let to use the same ID ([e-mail]). I think we should update the original one.

Best regards,
Andras

Comment 19

[Myk Melez [:myk] [@mykmelez]]

Mike Morgan (morgamic) is taking over responsibility for AMO from Basil.  He or Rey Bango should be able to take care of this.  cc:ing both of them.

Comment 20

[Andras Timar]

Mike, Rey, do you think you can help us to fix this issue?

Comment 21

[Michael Morgan [:morgamic]]

I spoke with Andras and we are going to attempt to contact the current owner one last time and if he does not respond I will hand ownership over to Andras.

Comment 22

[Andras Timar]

Current owner (Pap Lorinc) responded, resigned, and agreed to hand ownership over to me and Laszlo. Mike, can you please proceed. Thanks.

Comment 23

[Michael Morgan [:morgamic]]

Ownership transferred to Andras.

Comment 24

[Andras Timar]

verified