412692 - Allow drag&drop for bookmarks to place them onto a tag under Tags

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008011304 Minefield/3.0b3pre ID:2008011304

Currently it's not possible to d&d a bookmark onto a tag under Tags. It would be a nice way of tagging. Just grab a bookmark under any bookmark folder and place it onto a tag. The bookmark should get tagged and not deleted on its original position.

Same could be done for an already tagged bookmark. Select a bookmark under Tags and d&d it to another tag. The bookmark should get moved to the new tag. Means the old one gets deleted. Further it could be enhanced by checking if shift, crtl, or whatever key is used under the OS, to add a new tag without removing the old one.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

>The bookmark should get moved to the new tag. Means the old one gets deleted.

I agree except for the part where the previous tag gets deleted.  Bookmarks may often have more than one tag, and removing all of the other tags feels both like data lose and more of a folder model than a tag model.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I don't meant removing all the other tags for that bookmark. Instead only the (source) tag should be removed. This would give a feeling like moving a bookmark between folders.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

>This would give a feeling like moving a bookmark between folders.

Yeah, I get what you are saying, and overall I'm not really sure.

Unfortunately we don't have a lot of external consistency to leverage here, I'll try to take a look at how Vista is dealing with this use case in their library-based applications, and what google docs does.

Just looking at the physical metaphor though, if you take something that has one physical tag on it, and bring it to another physical tag, is there an expectation that the thing will now have two tags on it, or still only one tag on it?  Certainly with folders you are taking the thing out of the folder and placing it in another folder, but with little tags with strings, I think it might be more intuitive that you are just adding another tag.

Ideally we would decorate the cursor with a + to make the interaction totally clear.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #3)
> Ideally we would decorate the cursor with a + to make the interaction totally
> clear.

Indeed, it's a point that seems to be not implemented at all. There is no difference between a copy and move action between folders. As I talked with Tracy yesterday it should be filed as a separate bug if there is none yet. I have to search for.

Comment 5

[Giles Weaver]

I would expect dragging bookmarks onto a tag would add that tag to the bookmark, but not remove existing tags.
The GMarks addon for FF2 has this behaviour and it works well. I would suggest that anyone who works on the tagging system should try GMarks for a while, as the new places manager comes up short in a few areas as compared to GMarks.

IMHO the whole point of tags is to be able to have multiple tags and not have to have a hierarchy. Otherwise we could all just use folders instead.

The other blindingly obvious thing with places is that it isn't possible to select multiple bookmarks and apply the same tag to all of them. Or if it is, it isn't obvious how to!

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

From a UI perspective, I agree with comment 3 (especially about decorating the cursor) and comment 5.

Doesn't block, nice-to-have.

Comment 7

[Marco Bonardo [:mak]]

well, actually you can add a tag dropping a bookmark over a tag container, and the element gets tagged. (for new profiles only, need to replace left pane queries for old profiles)

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #7)
> the element gets tagged. (for new profiles only, need to replace left pane
> queries for old profiles)

Could you add this bug as blocker? I'm not sure which bug is the correct one. Meanwhile adding bug 426340 to track the KB article.

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008041604 Minefield/3.0pre

Is this already in Litmus?

Comment 9

[Marco Bonardo [:mak]]

this has been fixed by bug 419731, left pane replace is always bug 425161. 

Comment 10

[Aakash Desai [:aakashd]]

Test case https://litmus.mozilla.org/show_test.cgi?id=7481 has been created on litmus for regression testing.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #10)
> Test case https://litmus.mozilla.org/show_test.cgi?id=7481 has been created on
> litmus for regression testing.

"Ensure there is at least one tag folder in your profile." That's a bit misleading I think. Please use "at least one tagged bookmark".

Please also add it to the 3.0 testrun. Thanks.

Comment 12

[Aakash Desai [:aakashd]]

The changes were made to test case 7481 and https://litmus.mozilla.org/show_test.cgi?id=7482 was created for regression testing on 3.0.

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv