Closed Bug 413868 Opened 12 years ago Closed 12 years ago

Lightning forces Thunderbird to English due to shipping sunbird-only files


(Calendar :: Build Config, defect, major)

Not set


(Not tracked)



(Reporter: ssitter, Assigned: Fallen)



(Keywords: regression)


(3 files, 1 obsolete file)

In the German forum it was reported that after installing Lightning nightly build into a German Thunderbird most other extensions switched from German to English too.

This is caused by Lightning shipping the en-US version of sunbird-l10n.js in <lightning.xpi\defaults\preferences\sunbird-l10n.js>.

Because this file contains the preference
   pref("general.useragent.locale", "en-US");
it overwrites Thunderbirds default value (e.g. "de")

This will also break the import of local specific categories names in Lightning from because sunbird-l10n.js already contains the en-US categories.

Other preferences in sunbird-l10n.js are also available from lightning.js file.

Other sunbird-only files in the lightning.xpi are e.g. README.txt and updater.ini and maybe more. They should be removed to reduce download size.

Expected Results:
Lightning doesn't break Thunderbird by shipping sunbird-l10n.js.

The first build that shows the issue is Lightning 0.8pre (2008-01-16-04).
Flags: blocking-calendar0.8?
Flags: blocking-calendar0.8? → blocking-calendar0.8+
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20071031 Lightning/0.8pre Thunderbird/ (2008012320) ID:2007103104

I can confirm it and let me say: this is really annoying.
This is most probably a regression from the makefile changes in Bug 352546.
Blocks: 352546
The problem from a technical side is that the prefs file is also added for lightning, while it is sunbird specific. Here is my proposed solution:

We should create a calendar/sunbird/locales/
  - contains sunbird specific PREF_JS_EXPORTS
  - contains any other sunbird specific stuff from the current 

ause, does this look like a good idea?
yes, moving sunbird specific processing into a sunbird specific directory sounds good.
Taking care. Lightning seems to work with, I need some fine tuning for Sunbird though.
Assignee: nobody → philipp
Attached patch The "small" solution (obsolete) β€” β€” Splinter Review
After some coding around ause and I have encountered some problems with the solution as noted earlier.

* LocaleProduct must be adjusted in
* calendar/installer could be moved to calendar/sunbird/installer
* calendar/locales/generic possibly needs a move to calendar/sunbird/locales

Also in some initial versions there were some missing variables. We think its better to make a "small" version of this patch to initially fix the bug, then after 0.8 is released, move the remaining sunbird specific locale stuff into sunbird/locales

This patch takes care of this and some other build system problems we have been having. I tested the following, and it works

* Lightning XPI in a en-US thunderbird
* Lightning XPI in a de thunderbird
* Localized Sunbird de
* Non-Localized Sunbird en

I have not tested langpacks, I'm not sure we support them though?
Attachment #301570 - Flags: review?(ause)
Attached patch The "small" solution - v4 β€” β€” Splinter Review
After lots of work and testing this seems to do it.
Attachment #301570 - Attachment is obsolete: true
Attachment #303999 - Flags: review?(ause)
Attachment #301570 - Flags: review?(ause)
Comment on attachment 303999 [details] [diff] [review]
The "small" solution - v4

given a clean build and some tweaks to the german localization, this is the first step in separating core/lightning/sunbird resources...
Attachment #303999 - Flags: review?(ause) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH

Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
All l10n tinderboxen are busted since the "Bustage fix for bug 413868" checkin at 2008-02-19 02:22; e.g. <>

make[3]: *** No rule to make target `libs'.  Stop.
make[2]: *** [libs-ca] Error 2
make[1]: *** [langpack-ca] Error 2
make: *** [installers-ca] Error 2
first bustage fix revealed next bustage:
a missing entry in causes l10n builds to miss a makefile in sunbird/locales. fix is on its way
Ause, please note that we need to split the necessary change between branch and trunk. On trunk this needs to go into mozilla/calendar/

On the branch into mozilla/
Additional allmakefiles are required.
Attachment #304211 - Flags: review?(ause)
Attachment #304210 - Flags: review? → review+
Attachment #304211 - Flags: review?(ause) → review+
Comment on attachment 304210 [details] [diff] [review]
[checked in] allmakefiles (branch)

r=me on build config change
Attachment #304210 - Flags: review+
Attachment #304210 - Attachment description: allmakefiles (branch) → [checked in] allmakefiles (branch)
Attachment #304211 - Attachment description: allmakefiles (trunk) → [checked in] allmakefiles (trunk)
Both additional fixes checked in
Reopening, see Bug 418585 comment#1.
Resolution: FIXED → ---
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Verified using Lightning 0.8pre (2008022001) + Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv: Gecko/2007103104 Thunderbird/

The lightning.xpi still contains the updater.ini file from Sunbird but this doesn't cause any trouble. I'll file a follow bug for this.
Depends on: 418792
You need to log in before you can comment on or make changes to this bug.