414161 - Quit & cancelation confirmation should not be displayed if downloads are resumable

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Shawn Wilsher :sdwilsh]

See Bug 401172 Comment 22

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

The previously mentioned bug can handle string changes if need be.

Comment 2

[Przemyslaw Bialik]

hmm looks similar to Bug 402436 ;)

Comment 3

[Ed Lee :Mardak]

Comment on attachment 299466 [details] [diff] [review]
v1.0

>-  // Count active downloads that aren't real-paused
>+  // Count active downloads
Just get rid of this comment
>   PRInt32 currDownloadCount = mCurrentDownloads.Count();
nit: add a new line here
>+  // but not downloads that are paused, nor downloads that are resumable, since
>+  // we can cancel those and resume them without a problem with the right
>+  // preference set.
Change the comment to something more like..
"If we don't need to cancel all the downloads on quit, only count the ones that aren't resumable"
>+  if (GetQuitBehavior() != QUIT_AND_CANCEL) {
>+    for (PRInt32 i = mCurrentDownloads.Count() - 1; i >= 0; --i) {
Reuse currDownloadCount (minus one) that we already have for initializing "i"
>+      nsDownload *dl = mCurrentDownloads[i];
>+      if (dl->IsPaused() || dl->IsResumable())
>+        currDownloadCount--;
No need to check IsPaused because it can only be paused if it's resumable. So no need to declare the temporary dl pointer.

Comment 4

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

Addresses review comments.

Comment 5

[Ed Lee :Mardak]

Comment on attachment 299859 [details] [diff] [review]
v1.1

r=Mardak

Comment 6

[Damon Sicore (:damons)]

Comment on attachment 299859 [details] [diff] [review]
v1.1

a1.9+=damons

Comment 7

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.158; previous revision: 1.157

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008013004 Minefield/3.0b3pre ID:2008013004

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+

https://litmus.mozilla.org/show_test.cgi?id=5211