401172 - "If you quit now [x] download(s) will be canceled" texts should be updated

Status: NEW

(Toolkit :: Downloads API, defect, P3)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Spun off from https://bugzilla.mozilla.org/show_bug.cgi?id=399816#c1

Now that we can--and do--resume/auto-resume download across sessions, the dialog text that comes up when attempting to quit while still downloading is inaccurate:

/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties, line 15 -- quitCancelDownloadsAlertMsgMac=If you quit now, 1 download will be canceled. Are you sure you want to quit?
/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties, line 16 -- quitCancelDownloadsAlertMsgMacMultiple=If you quit now, %S downloads will be canceled. Are you sure you want to quit?

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Just noticed that Madhava doesn't get notified on a cc; Madhava, can you recommend the new text strings?

This might get tricky, though, as you can have both user-paused downloads (which don't auto-resume upon app-restart), as well as downloads that simply get auto-paused by Firefox, and then auto-resumed upon restart.

The message would have to be agnostic enough such that it applies to both cases (or maybe we don't need it any longer?)

Comment 2

[Ed Lee :Mardak]

Madhava mentioned some time ago on irc that we should just have a general dialog notifying the user that there is some sort of active download. If a user has a download, most likely they meant to have it finish, so even if we can pause/resume it, we should show a message.

Comment 3

[Jesse Ruderman]

> This might get tricky, though, as you can have both user-paused downloads
> (which don't auto-resume upon app-restart), as well as downloads that simply
> get auto-paused by Firefox, and then auto-resumed upon restart.

Quitting Firefox shouldn't make Firefox warn about user-paused downloads.  They should just appear again (still the paused state) when Firefox is restarted.

Comment 4

[Steve England [:stevee]]

This sounds like a dupe of bug 395192 which has blocking‑firefox3+ set. Dupe forward or back, I don't mind ;>

Comment 5

[Ed Lee :Mardak]

(In reply to comment #3)
> Quitting Firefox shouldn't make Firefox warn about user-paused downloads.  They
> should just appear again (still the paused state) when Firefox is restarted.
For those curious, this is actually what trunk does now. ;)

I'm guessing the message should be along the lines of "Firefox is downloading X files, are you sure you want to quit?" or "Firefox is downloading <single file name>, are you sure you want to quit?" This doesn't mention pausing or resuming or canceling.. question is if the user will be pleasantly surprised that the download resumed and finished in the background when reopening or shocked that a download completed alert showed up..

The slightly tricky thing is that resumable downloads will be paused while fake-paused downloads will get canceled, but those downloads will automatically restart from 0 when opening the app.

Comment 6

[Ria Klaassen (not reading all bugmail)]

When I quit and I choose to cancel the download (by clicking the Cancel 1 download button), Firefox continues the download automatically after opening the Download Manager after a restart. There should be an option to *really* cancel the download, because this is what I mostly want when I quit, and for 100% sure if I chose that option. Maybe there should also be an option "Continue download(s) the next time I open Firefox" or so. And let "Cancel 1 download" really cancel the download. I wonder if the "Don't exit" option is still needed.

Comment 9

[Shawn Wilsher :sdwilsh]

We should also fix the offline case too (File->Work Offline).

Comment 10

[Madhava Enros [:madhava]]

Attachment: shutdown message flow

I've been back and forth on this for a while, but I think I've got something that works now -- see the attachment for the flow for different cases.

I think this addresses the issues regarding having too many (any?) successive nagging dialogs (as in 404572) while still making it clear, with a light touch, what the user's options are.  It also means that we always default to a safe state.

The other point is that if the user has Clear Private Data enabled, they probably shouldn't even get the "Save?" dialog.  Either way, we should _cancel_ their active ongoing downloads so that there's no partially completed file on disk.

Comment 11

[Ed Lee :Mardak]

What does 'do not ask' do for future quits? What's the notify -- like the download complete message?

Comment 12

[Håkan Waara]

See also bug 404572

Comment 15

[James Darpinian]

(In reply to comment #5)
> The slightly tricky thing is that resumable downloads will be paused while
> fake-paused downloads will get canceled, but those downloads will automatically
> restart from 0 when opening the app.

It would be nice if, when Firefox knows that a download is not resumable, then that information was passed on to the user in the quit confirmation dialog.  For example, "2 of your downloads ([time] spent downloading so far) will have to be started over."  I suppose there should also be a way to figure out which downloads those are.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please don't kill those strings. As you can see on bug 408979 downloads cannot be resumed at anytime, e.g. servers only supporting HTTP/1.0 don't give us an Etag we need to build up our EntityID. Downloads get canceled on shutdown and we have to inform the user about.

Comment 17

[Shawn Wilsher :sdwilsh]

Madhava -
What is meant by "notify service"?

Also, I'm not sure if this will be possible since the Download Manager is a toolkit app, we can't really hook into the quit dialog (that I know of).

Do we really want to leave the downloads paused?  Before it was decided to resume them automagically if they were downloading before.

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> > This might get tricky, though, as you can have both user-paused downloads
> > (which don't auto-resume upon app-restart), as well as downloads that simply
> > get auto-paused by Firefox, and then auto-resumed upon restart.
> 
> Quitting Firefox shouldn't make Firefox warn about user-paused downloads.  They
> should just appear again (still the paused state) when Firefox is restarted.

Sure; I was referring to the case in which you have a combination of both, though I certainly didn't make myself clear.

Comment 19

[Madhava Enros [:madhava]]

(In reply to comment #17)

> What is meant by "notify service"?

I'm probably using the wrong terminology here, but I'm referring to the system whereby we send messages through Growl on the Mac or the "toast" messages on Windows.

> Do we really want to leave the downloads paused?  Before it was decided to
> resume them automagically if they were downloading before.

The only case in the diagram where we leave things paused is if the user quits rather than says "Save and Quit."  In other words, they didn't really tell us to retain what's going on, but, by pausing rather than canceling, we can let them change their minds later if they made a mistake.

Comment 20

[Graeme McCutcheon [:graememcc]]

Should add "late-l10n" to the keywords on this

Comment 21

[Mike Beltzner [:beltzner, not reading bugmail]]

I believe that this will be fixed by bug 404572, but isn't exactly a dupe as it dictates the entire flow which might end up requiring other dependencies.

Comment 22

[Shawn Wilsher :sdwilsh]

Via comment 21, I think this should no longer be a blocker.  It'd be nice to better handle this, but we won't show this for anything that's it paused.  However, we should not count pauseable downloads in this count.  I'll file a bug for this now and get a patch up.  This way, the canceled text will only be displayed if there are active, non-resumable downloads (and downloads won't be canceled in the end).

Comment 23

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #22)
> Via comment 21, I think this should no longer be a blocker.  It'd be nice to
> better handle this, but we won't show this for anything that's it paused. 
> However, we should not count pauseable downloads in this count.  I'll file a
> bug for this now and get a patch up.  This way, the canceled text will only be
> displayed if there are active, non-resumable downloads (and downloads won't be
> canceled in the end).

Shawn: did you ever file this?  Anyway, something's up and I'm not being prompted on shutdown with active downloads, even though I have:

browser.download.manager.quitBehavior 0 (default)
browser.warnOnQuit true (default)

I need to take another look at bug 404572, it seems; sigh...

Comment 24

[Shawn Wilsher :sdwilsh]

(In reply to comment #23)
> Shawn: did you ever file this?  Anyway, something's up and I'm not being
> prompted on shutdown with active downloads, even though I have:
Yes, it was filed and fixed.  Bug 414161.

Comment 25

[Michael Schonfeld]

So to sum this up, heres what I got from all this:

No active downloads - > Normal quit dialog
Active Downloads (resumable downloads) -> Madhavas new quit dialog
Active Downloads (non-resumable downloads) -> Both the old download cancellation dialog & the old quit dialog
Active Downloads (resumable & non-resumable downloads) -> Both the old download cancellation dialog, followed by Madhavas new dialog

Any thoughts?

Comment 26

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)

Comment 27

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 3 duplicates.
:mak, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 28

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.