41445 - [RFE] Sidebar context menu items in sidebar tab header

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, enhancement, P2)

Description

[Henrik Gemal]

A context menu should be implemented for the sidebar.
Fx rightclick pressing in the title should give the user the option to "remove 
the sidebar", "add to the sidebar", and "customize the sidebar".

Rightclick pressing on one of the tabs should give the option to "reload the tab 
", "customize the tab" and to "remove the tab".

Comment 1

[Chris McAfee]

marking rfe, m19

Comment 2

[Blake Ross]

Reassigning 50 Sidebar bugs to Matt.  I was told this was going to be done 
shortly about two months ago, but it clearly hasn't been.  I think that's long 
enough for all these bugs to remain assigned to nobody.

Feel free to filter all this spam into the trashcan by looking for this string 
in the message body: ducksgoquack

Comment 3

[shrirang khanzode]

spam : changing qa to sujay (New Sidebar QA)

Comment 4

[Chris Lyon]

*** Bug 86557 has been marked as a duplicate of this bug. ***

Comment 5

[rbs]

Reproducing my comments from bug 86557:
All the tabs now have a convenient context menu, except the "My Sidebar" tab
itself. It would be nice if right-cliking on that tab could popup
the same menu that the "Tabs" has. So this bug is a RFE to allow the readily 
available "Tabs" menu appear as a context menu (i.e., next to the mouse) when 
right-clicking on the "My Sidebar" tab itself.

Comment 6

[Henrik Gemal]

RFE cleanup. RFE is already indicated by the Severity field...Sorry for the 
spam!

Comment 7

[Samir Gehani]

This is an RFE for remove and reload panels.  Customize, switch to, and hide
panel are already in.  Please file a separate bug for any sidebar main header
(My Sidebar/Sidebar item rbs alluded to above) context menu RFEs.

Comment 8

[rbs]

My bug was bug 86557 and it was marked as duplicate of this one. Feel free t
re-open it.

Comment 9

[Samir Gehani]

The current poropsed changes are reflected at:
<http://www.mozilla.org/xpapps/sidebar/proposals/ctx-menus.html>

The newsgroup discussion for this topic is at:
<news://news.mozilla.org:119/[e-mail]>

Comment 10

[Jesse Ruderman]

See also bug 84514, add "tab properties..." to this context menu.

Comment 11

[Alex Bishop]

A 'Remove tab' item is important. Right now you can hide a tab by using the
'Tabs' flyout menu. However, someone decided this was too much effort for the
user and that this should be possible by using the tab title's context menu.
Removing a tab, on the other hand, requires a trip to the 'Customize Sidebar'
dialogue, which is far more effort than needed to hide a tab, but there's no
context menu item for it.

Comment 12

[Samir Gehani]

Moving to mozilla0.9.7.

Comment 13

[Samir Gehani]

*** Bug 67719 has been marked as a duplicate of this bug. ***

Comment 14

[Samir Gehani]

-> mozilla0.9.8

Comment 15

[Jaime Rodriguez, Jr.]

what are the chances this will make the 098 milestone?

Comment 16

[Samir Gehani]

Sidebar triage team: nsbeta1+

Comment 17

[Samir Gehani]

Sidebar tab header context menus are addressed in the new context menu spec:
<http://www.mozilla.org/projects/ui/communicator/framework/contextmenus/cmrev2.html#Anchor-28250>

Comment 18

[Samir Gehani]

Attachment: Context menu items per spec (without Print Tabs cause that's not scheduled for now).

Comment 19

[Samir Gehani]

morse, please r.
alecf, please sr.

Comment 20

[Samir Gehani]

Attachment: Same patch as above but ``diff -w'' for reviewers' benefit.

Comment 21

[Stephen P. Morse]

Comment on attachment 68242 [details] [diff] [review]
Same patch as above but ``diff -w'' for reviewers' benefit.

r=morse

Comment 22

[Alec Flett]

Comment on attachment 68242 [details] [diff] [review]
Same patch as above but ``diff -w'' for reviewers' benefit.

comments comments and more comments!
code looks fine but you really need to document way more.

Comment 23

[Samir Gehani]

Attachment: Patch rev 2 with code commented now.

alecf, please sr.  Thanks.

Comment 24

[Alec Flett]

Comment on attachment 68362 [details] [diff] [review]
Patch rev 2 with code commented now.

I hate to keep belabor this but comments should explain WHY you're doing what
 you're doing .. i.e. 



// the current panel can be reloaded, but other panels are
// not showing any content, so we only allow you to switch to other panels..

>+  if (panel.is_selected()) 
>+  {
>+    // for the currently selected panel hide the ``Switch to Tab'' item
>+    // and enable the ``Reload'' item
>+    switchItem.setAttribute("collapsed", "true"); 
>+    reloadItem.removeAttribute("disabled");
>+  }
>+  else 
>+  {
>+    // for panels that aren't the currently selected one show the 
>+    // ``Switch to Tab'' item and disable the ``Reload'' item
>+    switchItem.removeAttribute("collapsed");
>+    reloadItem.setAttribute("disabled", "true");
>+  }
>+

Anyway, with that sort of comment, sr=alecf

Comment 25

[Samir Gehani]

OK, suggestion incorporated.  Thanks for the reviews.

Comment 26

[Samir Gehani]

Checked in.

Comment 27

[sujay]

okay now I see the following in the context menu for tab header:

Switch to Tab
Reload
Stop
Hide Tab
Customize My Sidebar

If this is not correct, then REOPEN.

verified in 2/20 build.