414617 - AMO integration search field doesn't highlight correctly when focused

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Dave Townsend [:mossop]]

There are a few UI tweaks to go on with the search field, particularly to make it fit in with proto. Also the puzzle piece needs to be replaced with something.

Comment 1

[Reed Loden [:reed]]

Also see bug 414605.

Comment 2

[u88484]

Also see the dependencies in bug 404024

Comment 3

[Michael Monreal [:micmon]]

For linux, we can use the same search icon as used in the main window search entry and gtk-clear for clearing the search.

What meaning does the faint extension icon have? I was wondering if it would allow me to switch between modes like "search for extensions, search for themes, search for translations..." but this does not seem to be the case. If it does not have any use, we should just remove it.

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #3)
> What meaning does the faint extension icon have? I was wondering if it would
> allow me to switch between modes like "search for extensions, search for
> themes, search for translations..." but this does not seem to be the case. If
> it does not have any use, we should just remove it.

Yes I'm going to be working on the search bar early next week to tidy up the styles for the different platforms, thanks for letting me know you have the icons in hand. The extension puzzle icon is to be dropped from the search bar so don't worry about it.

Comment 6

[Dave Townsend [:mossop]]

The search bar needs some platform loving, it's currently square on OSX and doesn't get focus highlights there or on linux. And the puzzle piece is not meant to be there anymore.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Again, I think this should be in Firefox::Theme ...

Comment 8

[is+mozilla]

Attachment: screen shot of highlighted search field

I'm not sure if what I'm seeing is this bug or a new bug, but I'm attaching a screenshot.  When the search-engine drop-down is selected, the search field loses its highlight around that part of search field. The rest of field remains highlighted.  Should I file a new bug for the issue in the screenshot?

Comment 9

[u294409]

Screenshot in PDF :> ?

Your bug seems to be Mac-only.

Comment 10

[Dave Townsend [:mossop]]

Fixed by bug 449317